Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upUpdate to rustc 1.7.0-nightly (b4707ebca 2015-12-27) #9093
Merged
+45
−39
Conversation
highfive
commented
Dec 30, 2015
|
|
|
@bors-servo r+ |
|
|
|
@bors-servo r- force |
|
@bors-servo r=saneyuki |
|
|
bors-servo
added a commit
that referenced
this pull request
Dec 31, 2015
Update to rustc 1.7.0-nightly (b4707ebca 2015-12-27) <!-- Reviewable:start --> [<img src="https://reviewable.io/review_button.png" height=40 alt="Review on Reviewable"/>](https://reviewable.io/reviews/servo/servo/9093) <!-- Reviewable:end -->
|
|
|
|
Gah. @larsbergstrom? |
|
I'll try to repro this on my local Linux box. I've only seen this before when attempting to do a cargoup. |
|
Few things going on here:
|
|
There's currently not a great way to disable gold without using a wrapper-rustc-script which passes I'd be pretty interested, however, in what the errors are with using gold. I'm sure that Servo would greatly improve link times using gold instead of the default ld, so it'd be great to investigate! |
|
cc @brson about gold issues as well |
|
@alexcrichton Hrm, this might be us. We've been using gold for a long time (August 15th - fb7a53c), but it breaks on cross-compiles, as in #7564 (totally fine on native builds). I think this is our fault - looking at the rustc code, you shouldn't be using gold on cross-compiles, so I should back out that commit with this rustc update, since we should no longer have to do the gold linker determination ourselves. |
|
@larsbergstrom that build error actually looks unrelated to the usage of gold to me, looking at the two errors it looks like you've seen that Other than that I think that it may be fine to just leave gold as-is. |
|
@bors-servo r+ |
|
|
bors-servo
added a commit
that referenced
this pull request
Jan 15, 2016
Update to rustc 1.7.0-nightly (b4707ebca 2015-12-27) <!-- Reviewable:start --> [<img src="https://reviewable.io/review_button.png" height=40 alt="Review on Reviewable"/>](https://reviewable.io/reviews/servo/servo/9093) <!-- Reviewable:end -->
|
|
|
|
@bors-servo retry |
|
|
|
@bors-servo retry |
|
|
|
|
|
Seems to be hitting #9286 pretty consistently... |
|
@bors-servo retry I'm going to retry again, third time's the trick hopefully... |
|
|
|
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Ms2ger commentedDec 30, 2015