Parse size attribute of HTMLInputElemnt correctly#9119
Parse size attribute of HTMLInputElemnt correctly#9119bors-servo merged 1 commit intoservo:masterfrom
Conversation
|
Thanks for the pull request, and welcome! The Servo team is excited to review your changes, and you should hear from @pcwalton (or someone else) soon. |
|
You can rearrange the order of the match statement to avoid duplicated code. A reftest would be nice. |
|
Sure, I'll try and learn how testing works. |
|
Feel free to take the tests I mentioned in the original issue: #8773 |
|
☔ The latest upstream changes (presumably #9076) made this pull request unmergeable. Please resolve the merge conflicts. |
|
Sorry, we're no longer accepting new tests under |
239d02b to
5559555
Compare
|
Ugh. Just land the manifest changes, I guess. Do remove my FIXME comment though, please. |
c4bff7e to
24c4e95
Compare
|
@TheKK As Ms2ger said, you can also delete the comment referring to this bug. ( |
|
Oh, my bad. I read it as "Do not remove" :p |
24c4e95 to
74905f0
Compare
|
@bors-servo r=eefriedman |
|
📌 Commit 74905f0 has been approved by |
Parse size attribute of HTMLInputElemnt correctly Should fix #8773 <!-- Reviewable:start --> [<img src="https://reviewable.io/review_button.png" height=40 alt="Review on Reviewable"/>](https://reviewable.io/reviews/servo/servo/9119) <!-- Reviewable:end -->
|
💔 Test failed - linux-rel |
|
⚡ Previous build results for android, gonk, mac-dev-ref-unit, mac-rel-wpt are reusable. Rebuilding only linux-dev, linux-rel, mac-rel-css... |
|
💔 Test failed - linux-rel |
|
⚡ Previous build results for android, gonk, linux-dev, mac-dev-ref-unit, mac-rel-css, mac-rel-wpt are reusable. Rebuilding only linux-rel... |
|
Just wondering. What happened after you tell the bot to rebuild with a certain issue number? |
|
@TheKK it's simply a way for us to track intermittent errors. We link it to an existing issue so that we know all of the instances where the intermittent errors happened. |
|
Thanks for explain. I thought the bot will magically skip the tests mentioned by these issues. |
|
☀️ Test successful - android, gonk, linux-dev, linux-rel, mac-dev-ref-unit, mac-rel-css, mac-rel-wpt |
Should fix #8773