Skip to content

/ servo

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add 'input' event for HTMLInputElement #9122

Merged
merged 2 commits into from Jan 2, 2016
Merged

Add 'input' event for HTMLInputElement #9122

merged 2 commits into from Jan 2, 2016

Conversation

@chkimes
Copy link
Contributor

chkimes commented Jan 2, 2016

Fixes #8613

Review on Reviewable
chkimes added 2 commits Jan 2, 2016
@chkimes
Add 'input' event for HTMLInputElement
12a0884
@chkimes
De-duplicate input event send code
Loading status checks…
0e663e0
@highfive
Copy link

highfive commented Jan 2, 2016

Thanks for the pull request, and welcome! The Servo team is excited to review your changes, and you should hear from @jdm (or someone else) soon.
@nox
Copy link
Member

nox commented Jan 2, 2016

@bors-servo r+

Reviewed 2 of 2 files at r1.
Review status: all files reviewed at latest revision, all discussions resolved.

Comments from the review on Reviewable.io
@bors-servo
Copy link
Contributor

bors-servo commented Jan 2, 2016

📌 Commit 0e663e0 has been approved by nox
@bors-servo
Copy link
Contributor

bors-servo commented Jan 2, 2016

⌛ Testing commit 0e663e0 with merge c0835ec...
bors-servo added a commit that referenced this pull request Jan 2, 2016
@bors-servo
Auto merge of #9122 - ckimes89:inputevent, r=nox
Loading status checks…
c0835ec 
Add 'input' event for HTMLInputElement

Fixes #8613

<!-- Reviewable:start -->
[<img src="https://reviewable.io/review_button.png" height=40 alt="Review on Reviewable"/>](https://reviewable.io/reviews/servo/servo/9122)
<!-- Reviewable:end -->
@nox nox self-assigned this Jan 2, 2016
@bors-servo
Copy link
Contributor

bors-servo commented Jan 2, 2016

💔 Test failed - linux-rel
@nox
Copy link
Member

nox commented Jan 2, 2016

@bors-servo retry #9124
@bors-servo
Copy link
Contributor

bors-servo commented Jan 2, 2016

⚡ Previous build results for android, gonk, linux-dev, mac-dev-ref-unit, mac-rel-css, mac-rel-wpt are reusable. Rebuilding only linux-rel...
@bors-servo
Copy link
Contributor

bors-servo commented Jan 2, 2016

☀️ Test successful - android, gonk, linux-dev, linux-rel, mac-dev-ref-unit, mac-rel-css, mac-rel-wpt
@bors-servo bors-servo merged commit 0e663e0 into servo:master Jan 2, 2016
3 checks passed
3 checks passed
code-review/reviewable Review complete: all files reviewed, all discussions resolved
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
homu Test successful
Details
@chkimes chkimes deleted the chkimes:inputevent branch Jan 2, 2016
@frewsxcv frewsxcv mentioned this pull request Jan 2, 2016
Open
@frewsxcv
Copy link
Member

frewsxcv commented Jan 2, 2016

There should be a regression test for this. Opened a new issue for it: #9131
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@nox nox

Labels
None yet
Projects
None yet
Milestone
No milestone
Linked issues

Successfully merging this pull request may close these issues.

None yet

6 participants
@chkimes @highfive @nox @bors-servo @frewsxcv @SimonSapin
You can’t perform that action at this time.