Add autoconf to build dependencies #9128
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`autoheader` from `autoconf` was necessary for the build on my system.
|
Is this due to harfbuzz failing to compile? |
|
As decided in the meeting today, we're going to accept this while continuing to think about better solutions than requiring autoconf. |
|
@bors-servo: r+ |
|
📌 Commit a244f78 has been approved by |
highfive
removed
the
S-awaiting-review
highfive
added
the
S-awaiting-merge
bors-servo
pushed a commit
that referenced
this pull request
Jan 5, 2016
Add autoconf to build dependencies `autoheader` from `autoconf` was necessary for the build on my system. <!-- Reviewable:start --> [<img src="https://reviewable.io/review_button.png" height=40 alt="Review on Reviewable"/>](https://reviewable.io/reviews/servo/servo/9128) <!-- Reviewable:end -->
This was referenced Jan 5, 2016
|
💔 Test failed - linux-rel |
highfive
added
S-tests-failed
|
⚡ Previous build results for android, gonk, linux-dev, mac-dev-ref-unit, mac-rel-css, mac-rel-wpt are reusable. Rebuilding only linux-rel... |
|
☀️ Test successful - android, gonk, linux-dev, linux-rel, mac-dev-ref-unit, mac-rel-css, mac-rel-wpt |
mbrubeck
added a commit
to mbrubeck/servo
that referenced
this pull request
Feb 5, 2016
This includes the fix for servo/rust-harfbuzz#54, and reverts servo#9128 which was a temporary workaround for that issue.
mbrubeck
added a commit
to mbrubeck/servo
that referenced
this pull request
Feb 5, 2016
This includes the fix for servo/rust-harfbuzz#54, and reverts servo#9128 which was a temporary workaround for that issue.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
autoheaderfromautoconfwas necessary for the build on my system.