Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upAdd autoconf to build dependencies #9128
Merged
+1
−1
Conversation
`autoheader` from `autoconf` was necessary for the build on my system.
|
Is this due to harfbuzz failing to compile? |
|
As decided in the meeting today, we're going to accept this while continuing to think about better solutions than requiring autoconf. |
|
@bors-servo: r+ |
|
|
bors-servo
added a commit
that referenced
this pull request
Jan 5, 2016
Add autoconf to build dependencies `autoheader` from `autoconf` was necessary for the build on my system. <!-- Reviewable:start --> [<img src="https://reviewable.io/review_button.png" height=40 alt="Review on Reviewable"/>](https://reviewable.io/reviews/servo/servo/9128) <!-- Reviewable:end -->
This was referenced Jan 5, 2016
|
|
|
@bors-servo retry |
|
|
|
|
mbrubeck
added a commit
to mbrubeck/servo
that referenced
this pull request
Feb 5, 2016
This includes the fix for servo/rust-harfbuzz#54, and reverts servo#9128 which was a temporary workaround for that issue.
mbrubeck
added a commit
to mbrubeck/servo
that referenced
this pull request
Feb 5, 2016
This includes the fix for servo/rust-harfbuzz#54, and reverts servo#9128 which was a temporary workaround for that issue.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
adrianheine commentedJan 2, 2016
autoheaderfromautoconfwas necessary for the build on my system.