Skip to content

/ servo

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable xmlhttprequest-timeout-worker-twice.html (fixes #4041) #9133

Merged
merged 1 commit into from Jan 3, 2016
Merged

Enable xmlhttprequest-timeout-worker-twice.html (fixes #4041) #9133

merged 1 commit into from Jan 3, 2016

Conversation

@nox
Copy link
Member

nox commented Jan 3, 2016

Review on Reviewable
@nox
Enable xmlhttprequest-timeout-worker-twice.html (fixes #4041)
Loading status checks…
5cb6810
@nox
Copy link
Member Author

nox commented Jan 3, 2016

@jdm Our XHR code changed a lot, shouldn't we enable this again?
@jdm
Copy link
Member

jdm commented Jan 3, 2016

@bors-servo: r+
@bors-servo
Copy link
Contributor

bors-servo commented Jan 3, 2016

📌 Commit 5cb6810 has been approved by jdm
@bors-servo
Copy link
Contributor

bors-servo commented Jan 3, 2016

⌛ Testing commit 5cb6810 with merge 9af9a2d...
bors-servo added a commit that referenced this pull request Jan 3, 2016
@bors-servo
Auto merge of #9133 - nox:enable-xmlhttprequest-timeout-worker-twice,…
9af9a2d 
… r=jdm

Enable xmlhttprequest-timeout-worker-twice.html (fixes #4041)

<!-- Reviewable:start -->
[<img src="https://reviewable.io/review_button.png" height=40 alt="Review on Reviewable"/>](https://reviewable.io/reviews/servo/servo/9133)
<!-- Reviewable:end -->
@nox nox assigned jdm Jan 3, 2016
@bors-servo
Copy link
Contributor

bors-servo commented Jan 3, 2016

💔 Test failed - mac-rel-wpt
@KiChjang
Copy link
Member

KiChjang commented Jan 3, 2016

@bors-servo retry
@nox nox added S-awaiting-merge and removed S-tests-failed labels Jan 3, 2016
@bors-servo
Copy link
Contributor

bors-servo commented Jan 3, 2016

⌛ Testing commit 5cb6810 with merge 550115a...
bors-servo added a commit that referenced this pull request Jan 3, 2016
@bors-servo
Auto merge of #9133 - nox:enable-xmlhttprequest-timeout-worker-twice,…
550115a 
… r=jdm

Enable xmlhttprequest-timeout-worker-twice.html (fixes #4041)

<!-- Reviewable:start -->
[<img src="https://reviewable.io/review_button.png" height=40 alt="Review on Reviewable"/>](https://reviewable.io/reviews/servo/servo/9133)
<!-- Reviewable:end -->
@bors-servo
Copy link
Contributor

bors-servo commented Jan 3, 2016

💔 Test failed - linux-rel
@KiChjang
Copy link
Member

KiChjang commented Jan 3, 2016 

Ran 3764 tests finished in 214.0 seconds.
  • 3763 ran as expected. 706 tests skipped.
  • 1 tests had unexpected subtest results

Tests with unexpected results:
  ▶ Unexpected subtest result in /_mozilla/mozilla/mime_sniffing_font_context.html:
  │ FAIL [expected PASS] Sniffed font is loaded and applied
  │   → assert_not_equals: got disallowed value 14
  │ 
  │ checkFontLoaded@http://web-platform.test:8000/_mozilla/mozilla/mime_sniffing_font_context.html:38:1
  │ Test.prototype.step_timeout/<@http://web-platform.test:8000/resources/testharness.js:1439:20
  │ Test.prototype.step@http://web-platform.test:8000/resources/testharness.js:1381:20
  └ Test.prototype.step_func/<@http://web-platform.test:8000/resources/testharness.js:1405:1

What is this?
@nox
Copy link
Member Author

nox commented Jan 3, 2016

@bors-servo retry #9124
@bors-servo
Copy link
Contributor

bors-servo commented Jan 3, 2016

⌛ Testing commit 5cb6810 with merge e13a25d...
bors-servo added a commit that referenced this pull request Jan 3, 2016
@bors-servo
Auto merge of #9133 - nox:enable-xmlhttprequest-timeout-worker-twice,…
Loading status checks…
e13a25d 
… r=jdm

Enable xmlhttprequest-timeout-worker-twice.html (fixes #4041)

<!-- Reviewable:start -->
[<img src="https://reviewable.io/review_button.png" height=40 alt="Review on Reviewable"/>](https://reviewable.io/reviews/servo/servo/9133)
<!-- Reviewable:end -->
@bors-servo
Copy link
Contributor

bors-servo commented Jan 3, 2016

☀️ Test successful - android, gonk, linux-dev, linux-rel, mac-dev-ref-unit, mac-rel-css, mac-rel-wpt
@bors-servo bors-servo merged commit 5cb6810 into servo:master Jan 3, 2016
2 checks passed
2 checks passed
continuous-integration/travis-ci/pr The Travis CI build passed
Details
homu Test successful
Details
@nox nox deleted the nox:enable-xmlhttprequest-timeout-worker-twice branch Jan 8, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@jdm jdm

Labels
S-awaiting-merge
Projects
None yet
Milestone
No milestone
Linked issues

Successfully merging this pull request may close these issues.

None yet

5 participants
@nox @jdm @bors-servo @KiChjang @highfive
You can’t perform that action at this time.