Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upPartial implementation of HTTP-network Fetch step #9153
Conversation
| @@ -4,16 +4,20 @@ | |||
|
|
|||
| use fetch::cors_cache::{BasicCORSCache, CORSCache, CacheRequestDetails}; | |||
| use fetch::response::ResponseMethods; | |||
| use http_loader::{NetworkHttpRequestFactory, WrappedHttpResponse}; | |||
| use http_loader::{create_http_connector, obtain_response}; | |||
This comment has been minimized.
This comment has been minimized.
KiChjang
Jan 5, 2016
Member
I'm not sure whether it's a good idea for the fetch infrastructure to depend upon http_loader.
|
components/net_traits/lib.rs, line 84 [r1] (raw file):
Comments from the review on Reviewable.io |
|
components/net/fetch/request.rs, line 784 [r1] (raw file): Comments from the review on Reviewable.io |
|
Nice work! With @frewsxcv's comments addressed, the first commit removed and the remaining ones squashed together, and the result rebased against master, I'd be happy to merge these changes. |
nikkisquared
force-pushed the
nikkisquared:http_network_fetch
branch
from
48eb508
to
1e8b840
|
@bors-servo: r+ |
|
|
highfive
added
S-awaiting-merge
and removed
S-awaiting-review
S-needs-rebase
S-needs-squash
labels
Partial implementation of HTTP-network Fetch step I've been working on making a partial implementation of HTTP-network Fetch[1] so that I can begin testing the entire Fetch protocol as implemented in Servo. The empty steps are intentionally so, including the incomplete Step 5, which I started without realizing I don't need to do basic testing. [1] https://fetch.spec.whatwg.org/#http-network-fetch <!-- Reviewable:start --> [<img src="https://reviewable.io/review_button.png" height=40 alt="Review on Reviewable"/>](https://reviewable.io/reviews/servo/servo/9153) <!-- Reviewable:end -->
nikkisquared
force-pushed the
nikkisquared:http_network_fetch
branch
from
1e8b840
to
af310f7
|
@bors-servo: r+ |
|
|
Partial implementation of HTTP-network Fetch step I've been working on making a partial implementation of HTTP-network Fetch[1] so that I can begin testing the entire Fetch protocol as implemented in Servo. The empty steps are intentionally so, including the incomplete Step 5, which I started without realizing I don't need to do basic testing. [1] https://fetch.spec.whatwg.org/#http-network-fetch <!-- Reviewable:start --> [<img src="https://reviewable.io/review_button.png" height=40 alt="Review on Reviewable"/>](https://reviewable.io/reviews/servo/servo/9153) <!-- Reviewable:end -->
|
|
nikkisquared commentedJan 5, 2016
I've been working on making a partial implementation of HTTP-network Fetch[1] so that I can begin testing the entire Fetch protocol as implemented in Servo. The empty steps are intentionally so, including the incomplete Step 5, which I started without realizing I don't need to do basic testing.
[1] https://fetch.spec.whatwg.org/#http-network-fetch