Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update pipeline url after redirections #9164

Merged
merged 1 commit into from Jan 6, 2016

Conversation

@paulrouget
Copy link
Contributor

paulrouget commented Jan 6, 2016

pipeline.url is not updated after a redirection.

Fixes #8902

Review on Reviewable

@jdm
Copy link
Member

jdm commented Jan 6, 2016

@bors-servo: r+
This makes me suspicious that we should be doing all loads in the constellation thread instead of the script thread, but that's a big change that requires further thought. Good enough for now!

@bors-servo
Copy link
Contributor

bors-servo commented Jan 6, 2016

📌 Commit 268e285 has been approved by jdm

@bors-servo
Copy link
Contributor

bors-servo commented Jan 6, 2016

Testing commit 268e285 with merge f4a2fe9...

bors-servo added a commit that referenced this pull request Jan 6, 2016
update pipeline url after redirections

`pipeline.url` is not updated after a redirection.

Fixes #8902

<!-- Reviewable:start -->
[<img src="https://reviewable.io/review_button.png" height=40 alt="Review on Reviewable"/>](https://reviewable.io/reviews/servo/servo/9164)
<!-- Reviewable:end -->
@jdm jdm self-assigned this Jan 6, 2016
@bors-servo
Copy link
Contributor

bors-servo commented Jan 6, 2016

💔 Test failed - mac-rel-css

@jdm
Copy link
Member

jdm commented Jan 6, 2016

@bors-servo
Copy link
Contributor

bors-servo commented Jan 6, 2016

Previous build results for android, gonk, linux-dev, linux-rel, mac-dev-ref-unit, mac-rel-wpt are reusable. Rebuilding only mac-rel-css...

@bors-servo
Copy link
Contributor

bors-servo commented Jan 6, 2016

@bors-servo bors-servo merged commit 268e285 into servo:master Jan 6, 2016
2 checks passed
2 checks passed
continuous-integration/travis-ci/pr The Travis CI build passed
Details
homu Test successful
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

5 participants
You can’t perform that action at this time.