Skip to content

/ servo

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Extract Response from net_traits/lib.rs #9165

Merged
merged 1 commit into from Jan 6, 2016
Merged

Extract Response from net_traits/lib.rs #9165

merged 1 commit into from Jan 6, 2016

Conversation

@KiChjang
Copy link
Member

KiChjang commented Jan 6, 2016

This puts them in a new file located at net_traits/response.rs.

Review on Reviewable
@Ms2ger
Copy link
Contributor

Ms2ger commented Jan 6, 2016

Add a newline to the end of the new file, and a module-level documentation comment that explains what the scope of this new module is.
@Ms2ger Ms2ger self-assigned this Jan 6, 2016
@KiChjang KiChjang force-pushed the KiChjang:extract-response branch from 36e849e to 0a8bb8b Jan 6, 2016
@KiChjang
Copy link
Member Author

KiChjang commented Jan 6, 2016

Done.
@Ms2ger
Copy link
Contributor

Ms2ger commented Jan 6, 2016

@bors-servo r+
@bors-servo
Copy link
Contributor

bors-servo commented Jan 6, 2016

📌 Commit 0a8bb8b has been approved by Ms2ger
@bors-servo
Copy link
Contributor

bors-servo commented Jan 6, 2016

⌛ Testing commit 0a8bb8b with merge ff33744...
bors-servo added a commit that referenced this pull request Jan 6, 2016
@bors-servo
Auto merge of #9165 - KiChjang:extract-response, r=Ms2ger
ff33744 
Extract Response from net_traits/lib.rs

This puts them in a new file located at `net_traits/response.rs`.

<!-- Reviewable:start -->
[<img src="https://reviewable.io/review_button.png" height=40 alt="Review on Reviewable"/>](https://reviewable.io/reviews/servo/servo/9165)
<!-- Reviewable:end -->
@KiChjang
Copy link
Member Author

KiChjang commented Jan 6, 2016

@nikkisquared be careful of where you locate the Response object now
@bors-servo
Copy link
Contributor

bors-servo commented Jan 6, 2016

💔 Test failed - linux-dev
@KiChjang KiChjang force-pushed the KiChjang:extract-response branch from 0a8bb8b to 4d63bf0 Jan 6, 2016
@KiChjang
Copy link
Member Author

KiChjang commented Jan 6, 2016

@bors-servo r=Ms2ger
@bors-servo
Copy link
Contributor

bors-servo commented Jan 6, 2016

📌 Commit 4d63bf0 has been approved by Ms2ger
@bors-servo
Copy link
Contributor

bors-servo commented Jan 6, 2016

⌛ Testing commit 4d63bf0 with merge 4f3a76a...
bors-servo added a commit that referenced this pull request Jan 6, 2016
@bors-servo
Auto merge of #9165 - KiChjang:extract-response, r=Ms2ger
4f3a76a 
Extract Response from net_traits/lib.rs

This puts them in a new file located at `net_traits/response.rs`.

<!-- Reviewable:start -->
[<img src="https://reviewable.io/review_button.png" height=40 alt="Review on Reviewable"/>](https://reviewable.io/reviews/servo/servo/9165)
<!-- Reviewable:end -->
@bors-servo
Copy link
Contributor

bors-servo commented Jan 6, 2016

💔 Test failed - mac-rel-wpt
@KiChjang
Copy link
Member Author

KiChjang commented Jan 6, 2016

Grrrrrr
@KiChjang
Extract Response from net_traits/lib.rs
Loading status checks…
05dc512
@KiChjang KiChjang force-pushed the KiChjang:extract-response branch from 4d63bf0 to 05dc512 Jan 6, 2016
@KiChjang
Copy link
Member Author

KiChjang commented Jan 6, 2016

@bors-servo r=Ms2ger
@bors-servo
Copy link
Contributor

bors-servo commented Jan 6, 2016

📌 Commit 05dc512 has been approved by Ms2ger
@bors-servo
Copy link
Contributor

bors-servo commented Jan 6, 2016

⌛ Testing commit 05dc512 with merge 99689bc...
bors-servo added a commit that referenced this pull request Jan 6, 2016
@bors-servo
Auto merge of #9165 - KiChjang:extract-response, r=Ms2ger
Loading status checks…
99689bc 
Extract Response from net_traits/lib.rs

This puts them in a new file located at `net_traits/response.rs`.

<!-- Reviewable:start -->
[<img src="https://reviewable.io/review_button.png" height=40 alt="Review on Reviewable"/>](https://reviewable.io/reviews/servo/servo/9165)
<!-- Reviewable:end -->
@bors-servo
Copy link
Contributor

bors-servo commented Jan 6, 2016

💔 Test failed - linux-rel
@KiChjang
Copy link
Member Author

KiChjang commented Jan 6, 2016

@bors-servo retry
@bors-servo
Copy link
Contributor

bors-servo commented Jan 6, 2016

⚡ Previous build results for android, gonk, mac-dev-ref-unit, mac-rel-css, mac-rel-wpt are reusable. Rebuilding only linux-dev, linux-rel...
@bors-servo
Copy link
Contributor

bors-servo commented Jan 6, 2016

☀️ Test successful - android, gonk, linux-dev, linux-rel, mac-dev-ref-unit, mac-rel-css, mac-rel-wpt
@bors-servo bors-servo merged commit 05dc512 into servo:master Jan 6, 2016
2 checks passed
2 checks passed
continuous-integration/travis-ci/pr The Travis CI build passed
Details
homu Test successful
Details
@KiChjang KiChjang deleted the KiChjang:extract-response branch Jan 6, 2016
@frewsxcv frewsxcv mentioned this pull request Jan 11, 2016
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@Ms2ger Ms2ger

Labels
None yet
Projects
None yet
Milestone
No milestone
Linked issues

Successfully merging this pull request may close these issues.

None yet

5 participants
@KiChjang @Ms2ger @bors-servo @SimonSapin @highfive
You can’t perform that action at this time.