Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upFix `linear_gradients_lengths_a.html` and fix Servo's use of "background-clip" to actually make it work. #9171
Conversation
`linear_gradients_lengths_ref.html` use `background-clip: content-box`. The tests clearly expect the background painting area to have width of 100px, but since the default value of `background-clip` is `border-box` and the boxes in question have a 1-pixel border the background painting areas are actually 102px. This commit fixes the tests so that the width of the background painting area is actually 100px.
determining the painting area for background images and gradients. See: https://drafts.csswg.org/css-backgrounds-3/#the-background-clip
|
Reviewed 3 of 3 files at r1. Comments from the review on Reviewable.io |
|
@bors-servo r+ |
|
|
bors-servo
added a commit
that referenced
this pull request
Jan 6, 2016
…rubeck Fix `linear_gradients_lengths_a.html` and fix Servo's use of "background-clip" to actually make it work. See the commit messages for details. r? @mbrubeck <!-- Reviewable:start --> [<img src="https://reviewable.io/review_button.png" height=40 alt="Review on Reviewable"/>](https://reviewable.io/reviews/servo/servo/9171) <!-- Reviewable:end -->
|
|
|
@bors-servo: retry |
|
|
|
test failure was #8769 |
|
|
|
@bors-servo: retry |
bors-servo
added a commit
that referenced
this pull request
Jan 6, 2016
…rubeck Fix `linear_gradients_lengths_a.html` and fix Servo's use of "background-clip" to actually make it work. See the commit messages for details. r? @mbrubeck <!-- Reviewable:start --> [<img src="https://reviewable.io/review_button.png" height=40 alt="Review on Reviewable"/>](https://reviewable.io/reviews/servo/servo/9171) <!-- Reviewable:end -->
|
@bors-servo: retry Infrastructure failure; tests were running forever on one builder and had to be aborted manually. |
bors-servo
added a commit
that referenced
this pull request
Jan 7, 2016
…rubeck Fix `linear_gradients_lengths_a.html` and fix Servo's use of "background-clip" to actually make it work. See the commit messages for details. r? @mbrubeck <!-- Reviewable:start --> [<img src="https://reviewable.io/review_button.png" height=40 alt="Review on Reviewable"/>](https://reviewable.io/reviews/servo/servo/9171) <!-- Reviewable:end -->
|
|
|
|
|
@bors-servo: retry |
bors-servo
added a commit
that referenced
this pull request
Jan 7, 2016
…rubeck Fix `linear_gradients_lengths_a.html` and fix Servo's use of "background-clip" to actually make it work. See the commit messages for details. r? @mbrubeck <!-- Reviewable:start --> [<img src="https://reviewable.io/review_button.png" height=40 alt="Review on Reviewable"/>](https://reviewable.io/reviews/servo/servo/9171) <!-- Reviewable:end -->
|
|
|
@bors-servo retry |
bors-servo
added a commit
that referenced
this pull request
Jan 8, 2016
…rubeck Fix `linear_gradients_lengths_a.html` and fix Servo's use of "background-clip" to actually make it work. See the commit messages for details. r? @mbrubeck <!-- Reviewable:start --> [<img src="https://reviewable.io/review_button.png" height=40 alt="Review on Reviewable"/>](https://reviewable.io/reviews/servo/servo/9171) <!-- Reviewable:end -->
|
|
|
@bors-servo retry |
|
@bors-servo p=4 |
bors-servo
added a commit
that referenced
this pull request
Jan 8, 2016
…rubeck Fix `linear_gradients_lengths_a.html` and fix Servo's use of "background-clip" to actually make it work. See the commit messages for details. r? @mbrubeck <!-- Reviewable:start --> [<img src="https://reviewable.io/review_button.png" height=40 alt="Review on Reviewable"/>](https://reviewable.io/reviews/servo/servo/9171) <!-- Reviewable:end -->
|
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
pcwalton commentedJan 6, 2016
See the commit messages for details.
r? @mbrubeck