Skip to content

/ servo

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

gfx: Eagerly transform clips into `ClippingRegion::max()` if possible. #9177

Merged
merged 1 commit into from Jan 8, 2016
Merged

gfx: Eagerly transform clips into `ClippingRegion::max()` if possible. #9177

merged 1 commit into from Jan 8, 2016

Conversation

@pcwalton
Copy link
Contributor

pcwalton commented Jan 7, 2016

This helps WebRender look for useless clips and optimize them out.

r? @glennw

Review on Reviewable
@highfive
Copy link

highfive commented Jan 7, 2016

warning Warning warning

  • These commits modify layout code, but no reftests are modified. Please consider adding a reftest!
@pcwalton
gfx: Eagerly transform clips into `ClippingRegion::max()` if possible.
Loading status checks…
3103b03 
This helps WebRender look for useless clips and optimize them out.
@glennw
Copy link
Member

glennw commented Jan 7, 2016

@bors-servo r+
@bors-servo
Copy link
Contributor

bors-servo commented Jan 7, 2016

📌 Commit 3103b03 has been approved by glennw
@Manishearth
Copy link
Member

Manishearth commented Jan 8, 2016

@bors-servo p=4
@bors-servo
Copy link
Contributor

bors-servo commented Jan 8, 2016

⌛ Testing commit 3103b03 with merge ab590dd...
bors-servo added a commit that referenced this pull request Jan 8, 2016
@bors-servo
Auto merge of #9177 - pcwalton:filter-out-useless-clips, r=glennw
ab590dd 
gfx: Eagerly transform clips into `ClippingRegion::max()` if possible.

This helps WebRender look for useless clips and optimize them out.

r? @glennw

<!-- Reviewable:start -->
[<img src="https://reviewable.io/review_button.png" height=40 alt="Review on Reviewable"/>](https://reviewable.io/reviews/servo/servo/9177)
<!-- Reviewable:end -->
@Ms2ger
Copy link
Contributor

Ms2ger commented Jan 8, 2016

@bors-servo retry force
@bors-servo
Copy link
Contributor

bors-servo commented Jan 8, 2016

⚡ Previous build results for android, gonk, linux-dev are reusable. Rebuilding only linux-rel, mac-dev-ref-unit, mac-rel-css, mac-rel-wpt...
@bors-servo
Copy link
Contributor

bors-servo commented Jan 8, 2016

⛄ The build was interrupted to prioritize another pull request.
@bors-servo
Copy link
Contributor

bors-servo commented Jan 8, 2016

⚡ Previous build results for android, gonk, linux-dev are reusable. Rebuilding only linux-rel, mac-dev-ref-unit, mac-rel-css, mac-rel-wpt...
@bors-servo
Copy link
Contributor

bors-servo commented Jan 8, 2016

💔 Test failed - linux-rel
@Ms2ger
Copy link
Contributor

Ms2ger commented Jan 8, 2016

@bors-servo retry
@nox
Copy link
Member

nox commented Jan 8, 2016

@bors-servo force
@bors-servo
Copy link
Contributor

bors-servo commented Jan 8, 2016

⚡ Previous build results for android, gonk, linux-dev are reusable. Rebuilding only linux-rel, mac-dev-ref-unit, mac-rel-css, mac-rel-wpt...
@nox nox mentioned this pull request Jan 8, 2016
Merged
@bors-servo
Copy link
Contributor

bors-servo commented Jan 8, 2016

💔 Test failed - linux-rel
@Ms2ger
Copy link
Contributor

Ms2ger commented Jan 8, 2016

@bors-servo retry force
@bors-servo
Copy link
Contributor

bors-servo commented Jan 8, 2016

⚡ Previous build results for android, gonk, linux-dev, mac-dev-ref-unit, mac-rel-css, mac-rel-wpt are reusable. Rebuilding only linux-rel...
@Ms2ger
Copy link
Contributor

Ms2ger commented Jan 8, 2016

@bors-servo retry
@bors-servo
Copy link
Contributor

bors-servo commented Jan 8, 2016

⚡ Previous build results for android, gonk, linux-dev, mac-dev-ref-unit, mac-rel-css, mac-rel-wpt are reusable. Rebuilding only linux-rel...
@bors-servo
Copy link
Contributor

bors-servo commented Jan 8, 2016

💔 Test failed - linux-rel
@Ms2ger
Copy link
Contributor

Ms2ger commented Jan 8, 2016

@bors-servo retry
@nox
Copy link
Member

nox commented Jan 8, 2016

@bors-servo force
@bors-servo
Copy link
Contributor

bors-servo commented Jan 8, 2016

⚡ Previous build results for android, gonk, linux-dev, mac-dev-ref-unit, mac-rel-css, mac-rel-wpt are reusable. Rebuilding only linux-rel...
@bors-servo
Copy link
Contributor

bors-servo commented Jan 8, 2016

💔 Test failed - linux-rel
@Ms2ger
Copy link
Contributor

Ms2ger commented Jan 8, 2016

@bors-servo retry
@bors-servo
Copy link
Contributor

bors-servo commented Jan 8, 2016

⌛ Testing commit 3103b03 with merge 58111a6...
bors-servo added a commit that referenced this pull request Jan 8, 2016
@bors-servo
Auto merge of #9177 - pcwalton:filter-out-useless-clips, r=glennw
Loading status checks…
58111a6 
gfx: Eagerly transform clips into `ClippingRegion::max()` if possible.

This helps WebRender look for useless clips and optimize them out.

r? @glennw

<!-- Reviewable:start -->
[<img src="https://reviewable.io/review_button.png" height=40 alt="Review on Reviewable"/>](https://reviewable.io/reviews/servo/servo/9177)
<!-- Reviewable:end -->
@bors-servo
Copy link
Contributor

bors-servo commented Jan 8, 2016

☀️ Test successful - android, gonk, linux-dev, linux-rel, mac-dev-ref-unit, mac-rel-css, mac-rel-wpt
@bors-servo bors-servo merged commit 3103b03 into servo:master Jan 8, 2016
2 checks passed
2 checks passed
continuous-integration/travis-ci/pr The Travis CI build passed
Details
homu Test successful
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@glennw glennw

Labels
S-awaiting-merge
Projects
None yet
Milestone
No milestone
Linked issues

Successfully merging this pull request may close these issues.

None yet

7 participants
@pcwalton @highfive @glennw @bors-servo @Manishearth @Ms2ger @nox
You can’t perform that action at this time.