Skip to content

/ servo

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

script_task.rs: Use self::MixedMessage in handle_msgs #9179

Merged
merged 1 commit into from Jan 7, 2016
Merged

script_task.rs: Use self::MixedMessage in handle_msgs #9179

merged 1 commit into from Jan 7, 2016

Conversation

@nerith
Copy link
Contributor

nerith commented Jan 7, 2016

handle_msgs contains many references to variants of MixedMessage.

The function should directly reference the variants instead of
prepending MixedMessage::.

Fixes #9169.

Review on Reviewable
@KiChjang KiChjang self-assigned this Jan 7, 2016
@KiChjang
Copy link
Member

KiChjang commented Jan 7, 2016

@bors-servo r+

Thanks for doing this!
@bors-servo
Copy link
Contributor

bors-servo commented Jan 7, 2016

📌 Commit d75021b has been approved by KiChjang
@bors-servo
Copy link
Contributor

bors-servo commented Jan 7, 2016

⌛ Testing commit d75021b with merge 8c03ea3...
bors-servo added a commit that referenced this pull request Jan 7, 2016
@bors-servo
Auto merge of #9179 - nerith:mixedmessage, r=KiChjang
8c03ea3 
script_task.rs: Use self::MixedMessage in handle_msgs

handle_msgs contains many references to variants of MixedMessage.

The function should directly reference the variants instead of
prepending `MixedMessage::`.

Fixes #9169.

<!-- Reviewable:start -->
[<img src="https://reviewable.io/review_button.png" height=40 alt="Review on Reviewable"/>](https://reviewable.io/reviews/servo/servo/9179)
<!-- Reviewable:end -->
@bors-servo
Copy link
Contributor

bors-servo commented Jan 7, 2016

💔 Test failed - linux-dev
@KiChjang KiChjang added S-fails-tidy and removed S-fails-tidy labels Jan 7, 2016
@KiChjang
Copy link
Member

KiChjang commented Jan 7, 2016 

./components/script/script_task.rs:864: use statement spans multiple lines
@KiChjang
Copy link
Member

KiChjang commented Jan 7, 2016

@bors-servo delegate+
r=me after you've fixed tidy
@bors-servo
Copy link
Contributor

bors-servo commented Jan 7, 2016

✌️ @nerith can now approve this pull request
@nerith
script_task.rs: Use self::MixedMessage in handle_msgs
Loading status checks…
0b25737 
handle_msgs contains many references to variants of MixedMessage.

The function should directly reference the variants instead of
prepending `MixedMessage::`.

Fixes #9169.
@nerith nerith force-pushed the nerith:mixedmessage branch from d75021b to 0b25737 Jan 7, 2016
@nerith
Copy link
Contributor Author

nerith commented Jan 7, 2016

@bors-servo r=KiChjang
@bors-servo
Copy link
Contributor

bors-servo commented Jan 7, 2016

📌 Commit 0b25737 has been approved by KiChjang
@bors-servo
Copy link
Contributor

bors-servo commented Jan 7, 2016

⌛ Testing commit 0b25737 with merge f3aa5b4...
bors-servo added a commit that referenced this pull request Jan 7, 2016
@bors-servo
Auto merge of #9179 - nerith:mixedmessage, r=KiChjang
Loading status checks…
f3aa5b4 
script_task.rs: Use self::MixedMessage in handle_msgs

handle_msgs contains many references to variants of MixedMessage.

The function should directly reference the variants instead of
prepending `MixedMessage::`.

Fixes #9169.

<!-- Reviewable:start -->
[<img src="https://reviewable.io/review_button.png" height=40 alt="Review on Reviewable"/>](https://reviewable.io/reviews/servo/servo/9179)
<!-- Reviewable:end -->
@bors-servo
Copy link
Contributor

bors-servo commented Jan 7, 2016

💔 Test failed - linux-rel
@KiChjang
Copy link
Member

KiChjang commented Jan 7, 2016

@bors-servo retry
@bors-servo
Copy link
Contributor

bors-servo commented Jan 7, 2016

⚡ Previous build results for android, gonk, linux-dev, mac-dev-ref-unit are reusable. Rebuilding only linux-rel, mac-rel-css, mac-rel-wpt...
@bors-servo
Copy link
Contributor

bors-servo commented Jan 7, 2016

💔 Test failed - linux-rel
@KiChjang
Copy link
Member

KiChjang commented Jan 7, 2016

@bors-servo retry
@bors-servo
Copy link
Contributor

bors-servo commented Jan 7, 2016

⚡ Previous build results for android, gonk, linux-dev, mac-dev-ref-unit, mac-rel-css, mac-rel-wpt are reusable. Rebuilding only linux-rel...
@bors-servo
Copy link
Contributor

bors-servo commented Jan 7, 2016

☀️ Test successful - android, gonk, linux-dev, linux-rel, mac-dev-ref-unit, mac-rel-css, mac-rel-wpt
@bors-servo bors-servo merged commit 0b25737 into servo:master Jan 7, 2016
2 checks passed
2 checks passed
continuous-integration/travis-ci/pr The Travis CI build passed
Details
homu Test successful
Details
@nerith nerith deleted the nerith:mixedmessage branch Jan 7, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@KiChjang KiChjang

Labels
S-fails-tidy
Projects
None yet
Milestone
No milestone
Linked issues

Successfully merging this pull request may close these issues.

None yet

5 participants
@nerith @KiChjang @bors-servo @SimonSapin @highfive
You can’t perform that action at this time.