Skip to content

/ servo

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove unneeded dict sorting functions in CodegenRust.py #9200

Merged
merged 1 commit into from Jan 10, 2016
Merged

Remove unneeded dict sorting functions in CodegenRust.py #9200

merged 1 commit into from Jan 10, 2016

Conversation

@frewsxcv
Copy link
Member

frewsxcv commented Jan 8, 2016

Review on Reviewable
@nox nox self-assigned this Jan 8, 2016
@nox
Copy link
Member

nox commented Jan 8, 2016

@bors-servo r+
@bors-servo
Copy link
Contributor

bors-servo commented Jan 8, 2016

📌 Commit db41dc2 has been approved by nox
@nox
Copy link
Member

nox commented Jan 8, 2016

@bors-servo r-

This changes the order as noticed by @Ms2ger. I can't read.
@frewsxcv
Copy link
Member Author

frewsxcv commented Jan 8, 2016

@bors-servo r-

This changes the sort order
@frewsxcv frewsxcv force-pushed the frewsxcv:unnecessary-sorting-functions branch from db41dc2 to c71dd98 Jan 8, 2016
@frewsxcv frewsxcv force-pushed the frewsxcv:unnecessary-sorting-functions branch 2 times, most recently from e3b5f88 to e6e13a9 Jan 8, 2016
@frewsxcv
Copy link
Member Author

frewsxcv commented Jan 8, 2016

@nox I force pushed a change that doesn't change the sort order, but still removes the functions. If it's no longer a desired change, feel free to close this
@nox nox removed the S-awaiting-review label Jan 10, 2016
@nox
Copy link
Member

nox commented Jan 10, 2016

-S-awaiting-review +S-needs-code-changes

Reviewed 1 of 1 files at r1.
Review status: all files reviewed at latest revision, 1 unresolved discussion.

components/script/dom/bindings/codegen/CodegenRust.py, line 2024 [r1] (raw file):
You should still use key=operator.itemgetter(0) (or a lambda that looks less weird) to really not sort according to the values.

Comments from the review on Reviewable.io
@frewsxcv
Remove unneeded dict sorting functions in CodegenRust.py
Loading status checks…
d63c9d7
@frewsxcv frewsxcv force-pushed the frewsxcv:unnecessary-sorting-functions branch from e6e13a9 to d63c9d7 Jan 10, 2016
@frewsxcv
Copy link
Member Author

frewsxcv commented Jan 10, 2016

Done
@nox
Copy link
Member

nox commented Jan 10, 2016

@bors-servo r+
@bors-servo
Copy link
Contributor

bors-servo commented Jan 10, 2016

📌 Commit d63c9d7 has been approved by nox
@bors-servo
Copy link
Contributor

bors-servo commented Jan 10, 2016

⌛ Testing commit d63c9d7 with merge 84333b8...
bors-servo added a commit that referenced this pull request Jan 10, 2016
@bors-servo
Auto merge of #9200 - frewsxcv:unnecessary-sorting-functions, r=nox
84333b8 
Remove unneeded dict sorting functions in CodegenRust.py

<!-- Reviewable:start -->
[<img src="https://reviewable.io/review_button.png" height=40 alt="Review on Reviewable"/>](https://reviewable.io/reviews/servo/servo/9200)
<!-- Reviewable:end -->
@Ms2ger
Copy link
Contributor

Ms2ger commented Jan 10, 2016

@bors-servo retry
@bors-servo
Copy link
Contributor

bors-servo commented Jan 10, 2016

⚡ Previous build results for android, gonk, linux-dev, mac-dev-ref-unit are reusable. Rebuilding only linux-rel, mac-rel-css, mac-rel-wpt...
@bors-servo
Copy link
Contributor

bors-servo commented Jan 10, 2016

💔 Test failed - linux-rel
@KiChjang
Copy link
Member

KiChjang commented Jan 10, 2016 

Ran 9335 tests finished in 360.0 seconds.
  • 9334 ran as expected. 55 tests skipped.
  • 1 tests passed unexpectedly

Tests with unexpected results:
  ▶ PASS [expected FAIL] /css21_dev/html4/floats-wrap-bfc-002-right-table.htm

An intermittent pass?
@frewsxcv
Copy link
Member Author

frewsxcv commented Jan 10, 2016

@bors-servo retry

#9014
@bors-servo
Copy link
Contributor

bors-servo commented Jan 10, 2016

⌛ Testing commit d63c9d7 with merge 85792d2...
bors-servo added a commit that referenced this pull request Jan 10, 2016
@bors-servo
Auto merge of #9200 - frewsxcv:unnecessary-sorting-functions, r=nox
Loading status checks…
85792d2 
Remove unneeded dict sorting functions in CodegenRust.py

<!-- Reviewable:start -->
[<img src="https://reviewable.io/review_button.png" height=40 alt="Review on Reviewable"/>](https://reviewable.io/reviews/servo/servo/9200)
<!-- Reviewable:end -->
@bors-servo
Copy link
Contributor

bors-servo commented Jan 10, 2016

☀️ Test successful - android, gonk, linux-dev, linux-rel, mac-dev-ref-unit, mac-rel-css, mac-rel-wpt
@bors-servo bors-servo merged commit d63c9d7 into servo:master Jan 10, 2016
2 checks passed
2 checks passed
continuous-integration/travis-ci/pr The Travis CI build passed
Details
homu Test successful
Details
@frewsxcv frewsxcv deleted the frewsxcv:unnecessary-sorting-functions branch Oct 16, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@nox nox

Labels
S-awaiting-merge
Projects
None yet
Milestone
No milestone
Linked issues

Successfully merging this pull request may close these issues.

None yet

6 participants
@frewsxcv @nox @bors-servo @Ms2ger @KiChjang @highfive
You can’t perform that action at this time.