Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upUse image metadata to lay out images #9208
Conversation
highfive
commented
Jan 8, 2016
|
|
|
|
|
Code reviewed, it looks pretty sweet. Only one niggle, which is that metadata width/height are being kept as u32, in px. Is there a sensible way of tracking units for metadata? Reviewed 12 of 13 files at r1, 1 of 1 files at r2. components/msg/constellation_msg.rs, line 334 [r2] (raw file): Comments from the review on Reviewable.io |
|
Great to hear! Are you thinking of something like a Pixel type to abstract the u32 choice? In that case it might be worthwhile changing Image's width/height from u32 as well |
|
On reflection, that issue is orthogonal to your PR, so I think we are good to go. @jdm: Can you delegate review privilege to me? |
|
@bors-servo: delegate=asajeffrey |
|
|
|
@bors-servo: r+ |
|
|
Use image metadata to lay out images Fixes #7047. cc: @jdm <!-- Reviewable:start --> [<img src="https://reviewable.io/review_button.png" height=40 alt="Review on Reviewable"/>](https://reviewable.io/reviews/servo/servo/9208) <!-- Reviewable:end -->
|
|
|
Ah, looks like this requires running |
Use image metadata to lay out images Fixes #7047. cc: @jdm <!-- Reviewable:start --> [<img src="https://reviewable.io/review_button.png" height=40 alt="Review on Reviewable"/>](https://reviewable.io/reviews/servo/servo/9208) <!-- Reviewable:end -->
|
|
|
@bors-servo: retry |
Use image metadata to lay out images Fixes #7047. cc: @jdm <!-- Reviewable:start --> [<img src="https://reviewable.io/review_button.png" height=40 alt="Review on Reviewable"/>](https://reviewable.io/reviews/servo/servo/9208) <!-- Reviewable:end -->
|
|
|
@bors-servo: retry |
Use image metadata to lay out images Fixes #7047. cc: @jdm <!-- Reviewable:start --> [<img src="https://reviewable.io/review_button.png" height=40 alt="Review on Reviewable"/>](https://reviewable.io/reviews/servo/servo/9208) <!-- Reviewable:end -->
|
|
PR servo#9208 added the ability to perform layout before an `<img>` resource is fully loaded. However, when we are rendering to an image file for testing purposes, we need to block until the image content is fully loaded (until issue servo#9441 is fixed). Fixes servo#9550.
PR servo#9208 added the ability to perform layout before an `<img>` resource is fully loaded. However, when we are rendering to an image file for testing purposes, we need to block until the image content is fully loaded (until issue servo#9441 is fixed). Fixes servo#9550.
PR servo#9208 added the ability to perform layout before an `<img>` resource is fully loaded. However, when we are rendering to an image file for testing purposes, we need to block until the image content is fully loaded (until issue servo#9441 is fixed). Fixes servo#9550.
jmr0 commentedJan 8, 2016
Fixes #7047.
cc: @jdm