Refactor WebGLPaintTask to prevent creating extra IPC channels - Issu…

[coder543]

closes #9228

and this time I have a separate branch.

[highfive]

Thanks for the pull request, and welcome! The Servo team is excited to review your changes, and you should hear from @Ms2ger (or someone else) soon.

[KiChjang]

r? @ecoal95

[KiChjang]

Fails tidy:

./components/canvas/webgl_paint_task.rs:233: trailing whitespace

NB: You can run ./mach test-tidy locally to check whether your source files are conforming to tidy rules.

[bors-servo]

☔ The latest upstream changes (presumably #9214) made this pull request unmergeable. Please resolve the merge conflicts.

[nox]

I'm pretty sure @ecoal95 meant to initialise the IPC channel in the last .map(|_| …) call in that function. You are still creating the channel for nothing if the context couldn't be initialised.

[emilio]

Yep, @nox is correct, you still always create the IPC channel.

It should be done if the recv() receives an Ok value, that is,
in the last .map call.

[emilio]

@coder543 Was this closed on purpose? You can rebase without creating a new PR, I'm happy to help you to do that if you want :P

[coder543]

Yeah, I was up to the 3 or 4 commit mark since a commit last night renamed all Tasks to Threads, and after rebasing I realized I needed to make another commit just to handle some whitespace issues. Things were getting messy. I know there's a way to squash commits, but I've never done that before, so I just cloned master again and pasted in my changes. Now there is only one commit in a new pull request... sorry about the number of PRs this has caused.

[emilio]

@coder543 No problem! :-)

[nox]

@coder543 Feel free to come on IRC, we can help you with Git.