Skip to content

/ servo

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement HTMLFormElement::Elements #9237

Merged
merged 1 commit into from Jan 10, 2016
Merged

Implement HTMLFormElement::Elements #9237

merged 1 commit into from Jan 10, 2016

Conversation

@frewsxcv
Copy link
Member

frewsxcv commented Jan 10, 2016

Fixes #8566

Review on Reviewable
@KiChjang KiChjang self-assigned this Jan 10, 2016
@KiChjang
Copy link
Member

KiChjang commented Jan 10, 2016

@bors-servo r+
@bors-servo
Copy link
Contributor

bors-servo commented Jan 10, 2016

📌 Commit b38b424 has been approved by KiChjang
@frewsxcv
Copy link
Member Author

frewsxcv commented Jan 10, 2016

@bors-servo r-

Sorry, I noticed something is wrong. I'll let you know when I fix it
@frewsxcv frewsxcv force-pushed the frewsxcv:htmlformelement-elements branch from b38b424 to 9b7ac7e Jan 10, 2016
@frewsxcv
Copy link
Member Author

frewsxcv commented Jan 10, 2016

Fixed the issue (incorrect comments). Reviewable again
@KiChjang
Copy link
Member

KiChjang commented Jan 10, 2016

Reviewed 14 of 14 files at r1.
Review status: all files reviewed at latest revision, all discussions resolved.

Comments from the review on Reviewable.io
@KiChjang
Copy link
Member

KiChjang commented Jan 10, 2016

@bors-servo r+
@bors-servo
Copy link
Contributor

bors-servo commented Jan 10, 2016

📌 Commit 9b7ac7e has been approved by KiChjang
@bors-servo
Copy link
Contributor

bors-servo commented Jan 10, 2016

⌛ Testing commit 9b7ac7e with merge 1031974...
bors-servo added a commit that referenced this pull request Jan 10, 2016
@bors-servo
Auto merge of #9237 - frewsxcv:htmlformelement-elements, r=KiChjang
1031974 
Implement HTMLFormElement::Elements

Fixes #8566

<!-- Reviewable:start -->
[<img src="https://reviewable.io/review_button.png" height=40 alt="Review on Reviewable"/>](https://reviewable.io/reviews/servo/servo/9237)
<!-- Reviewable:end -->
@bors-servo
Copy link
Contributor

bors-servo commented Jan 10, 2016

💔 Test failed - linux-dev
@KiChjang
Copy link
Member

KiChjang commented Jan 10, 2016

@bors-servo retry

  • SSL snafu
@frewsxcv
Implement HTMLFormElement::Elements
Loading status checks…
bff8947 
Fixes #8566
@frewsxcv frewsxcv force-pushed the frewsxcv:htmlformelement-elements branch from 9b7ac7e to bff8947 Jan 10, 2016
@frewsxcv
Copy link
Member Author

frewsxcv commented Jan 10, 2016

tidy issues addressed

@bors-servo r=KiChjang
@bors-servo
Copy link
Contributor

bors-servo commented Jan 10, 2016

📌 Commit bff8947 has been approved by KiChjang
@bors-servo
Copy link
Contributor

bors-servo commented Jan 10, 2016

⌛ Testing commit bff8947 with merge 99d0142...
bors-servo added a commit that referenced this pull request Jan 10, 2016
@bors-servo
Auto merge of #9237 - frewsxcv:htmlformelement-elements, r=KiChjang
Loading status checks…
99d0142 
Implement HTMLFormElement::Elements

Fixes #8566

<!-- Reviewable:start -->
[<img src="https://reviewable.io/review_button.png" height=40 alt="Review on Reviewable"/>](https://reviewable.io/reviews/servo/servo/9237)
<!-- Reviewable:end -->
@bors-servo
Copy link
Contributor

bors-servo commented Jan 10, 2016

💔 Test failed - mac-rel-css
@KiChjang
Copy link
Member

KiChjang commented Jan 10, 2016

@bors-servo retry
@bors-servo
Copy link
Contributor

bors-servo commented Jan 10, 2016

⚡ Previous build results for android, gonk, linux-dev, linux-rel, mac-dev-ref-unit, mac-rel-wpt are reusable. Rebuilding only mac-rel-css...
@bors-servo
Copy link
Contributor

bors-servo commented Jan 10, 2016

☀️ Test successful - android, gonk, linux-dev, linux-rel, mac-dev-ref-unit, mac-rel-css, mac-rel-wpt
@bors-servo bors-servo merged commit bff8947 into servo:master Jan 10, 2016
2 checks passed
2 checks passed
continuous-integration/travis-ci/pr The Travis CI build passed
Details
homu Test successful
Details
@bors-servo bors-servo mentioned this pull request Jan 10, 2016
Merged
@frewsxcv frewsxcv deleted the frewsxcv:htmlformelement-elements branch Oct 16, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@KiChjang KiChjang

Labels
None yet
Projects
None yet
Milestone
No milestone
Linked issues

Successfully merging this pull request may close these issues.

None yet

5 participants
@frewsxcv @KiChjang @bors-servo @SimonSapin @highfive
You can’t perform that action at this time.