Skip to content

/ servo

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Stop reexporting style types from layout_interface. #9245

Merged
merged 2 commits into from Jan 11, 2016
Merged

Stop reexporting style types from layout_interface. #9245

merged 2 commits into from Jan 11, 2016

Conversation

@Ms2ger
Copy link
Contributor

Ms2ger commented Jan 11, 2016

Review on Reviewable
Ms2ger added 2 commits Jan 11, 2016
@Ms2ger
Stop reexporting Animation from layout_interface.
39ba255
@Ms2ger
Stop reexporting ReflowGoal from layout_interface.
Loading status checks…
9dc85e0
@highfive
Copy link

highfive commented Jan 11, 2016

warning Warning warning

  • These commits modify layout code, but no reftests are modified. Please consider adding a reftest!
components/script/layout_interface.rs
use style::stylesheets::Stylesheet;
use url::Url;
use util::ipc::OptionalOpaqueIpcSender;

pub use style::animation::Animation;

This comment has been minimized.

Sign in to view
@KiChjang

KiChjang Jan 11, 2016

Member

Is this not being used anywhere in this source file at all?
@nox
Copy link
Member

nox commented Jan 11, 2016

@KiChjang It isn't.

@bors-servo r+
@bors-servo
Copy link
Contributor

bors-servo commented Jan 11, 2016

📌 Commit 9dc85e0 has been approved by nox
@nox nox self-assigned this Jan 11, 2016
@bors-servo
Copy link
Contributor

bors-servo commented Jan 11, 2016

⌛ Testing commit 9dc85e0 with merge 9180771...
bors-servo added a commit that referenced this pull request Jan 11, 2016
@bors-servo
Auto merge of #9245 - Ms2ger:reexports, r=nox
9180771 
Stop reexporting style types from layout_interface.

<!-- Reviewable:start -->
[<img src="https://reviewable.io/review_button.png" height=40 alt="Review on Reviewable"/>](https://reviewable.io/reviews/servo/servo/9245)
<!-- Reviewable:end -->
@bors-servo
Copy link
Contributor

bors-servo commented Jan 11, 2016

💔 Test failed - linux-rel
@nox
Copy link
Member

nox commented Jan 11, 2016

@bors-servo retry #9247
@bors-servo
Copy link
Contributor

bors-servo commented Jan 11, 2016

⚡ Previous build results for android, gonk, linux-dev, mac-dev-ref-unit, mac-rel-wpt are reusable. Rebuilding only linux-rel, mac-rel-css...
@nox nox added S-awaiting-merge and removed S-tests-failed labels Jan 11, 2016
@bors-servo
Copy link
Contributor

bors-servo commented Jan 11, 2016

⛄ The build was interrupted to prioritize another pull request.
@bors-servo
Copy link
Contributor

bors-servo commented Jan 11, 2016

⚡ Previous build results for android, gonk, linux-dev, mac-dev-ref-unit, mac-rel-wpt are reusable. Rebuilding only linux-rel, mac-rel-css...
@bors-servo
Copy link
Contributor

bors-servo commented Jan 11, 2016

⛄ The build was interrupted to prioritize another pull request.
@bors-servo
Copy link
Contributor

bors-servo commented Jan 11, 2016

⚡ Previous build results for android, gonk, linux-dev, mac-dev-ref-unit, mac-rel-wpt are reusable. Rebuilding only linux-rel, mac-rel-css...
@Ms2ger
Copy link
Contributor Author

Ms2ger commented Jan 11, 2016

@bors-servo force
@Ms2ger Ms2ger closed this Jan 11, 2016
@Ms2ger Ms2ger reopened this Jan 11, 2016
@Ms2ger
Copy link
Contributor Author

Ms2ger commented Jan 11, 2016

@bors-servo clean r=nox
@bors-servo
Copy link
Contributor

bors-servo commented Jan 11, 2016

📌 Commit 9dc85e0 has been approved by nox
@Manishearth
Copy link
Member

Manishearth commented Jan 11, 2016

@bors-servo retry clean
@bors-servo
Copy link
Contributor

bors-servo commented Jan 11, 2016

⌛ Testing commit 9dc85e0 with merge 4761757...
bors-servo added a commit that referenced this pull request Jan 11, 2016
@bors-servo
Auto merge of #9245 - Ms2ger:reexports, r=nox
Loading status checks…
4761757 
Stop reexporting style types from layout_interface.

<!-- Reviewable:start -->
[<img src="https://reviewable.io/review_button.png" height=40 alt="Review on Reviewable"/>](https://reviewable.io/reviews/servo/servo/9245)
<!-- Reviewable:end -->
@bors-servo
Copy link
Contributor

bors-servo commented Jan 11, 2016

☀️ Test successful - android, gonk, linux-dev, linux-rel, mac-dev-ref-unit, mac-rel-css, mac-rel-wpt
@bors-servo bors-servo merged commit 9dc85e0 into servo:master Jan 11, 2016
2 checks passed
2 checks passed
continuous-integration/travis-ci/pr The Travis CI build passed
Details
homu Test successful
Details
@Ms2ger Ms2ger deleted the Ms2ger:reexports branch Jan 12, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@nox nox

Labels
S-awaiting-merge
Projects
None yet
Milestone
No milestone
Linked issues

Successfully merging this pull request may close these issues.

None yet

6 participants
@Ms2ger @highfive @nox @bors-servo @Manishearth @KiChjang
You can’t perform that action at this time.