Skip to content

/ servo

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove unused dependencies from the msg crate. #9249

Merged
merged 1 commit into from Jan 11, 2016
Merged

Remove unused dependencies from the msg crate. #9249

merged 1 commit into from Jan 11, 2016

Conversation

@Ms2ger
Copy link
Contributor

Ms2ger commented Jan 11, 2016

Review on Reviewable
@Ms2ger
Remove unused dependencies from the msg crate.
Loading status checks…
7e3d1f8
@nox nox self-assigned this Jan 11, 2016
@nox
Copy link
Member

nox commented Jan 11, 2016

Good catch. How did you notice that?

@bors-servo r+
@emilio
Copy link
Member

emilio commented Jan 11, 2016

Nice! This will also help with @bholley's geckolib target
@nox
Copy link
Member

nox commented Jan 11, 2016

@bors-servo r+

Should be on first line?
@Ms2ger
Copy link
Contributor Author

Ms2ger commented Jan 11, 2016

@bors-servo r=nox
1 similar comment
@Ms2ger
Copy link
Contributor Author

Ms2ger commented Jan 11, 2016

@bors-servo r=nox
@Ms2ger Ms2ger closed this Jan 11, 2016
@Ms2ger Ms2ger reopened this Jan 11, 2016
@Ms2ger
Copy link
Contributor Author

Ms2ger commented Jan 11, 2016

@bors-servo r=nox
@bors-servo
Copy link
Contributor

bors-servo commented Jan 11, 2016

📌 Commit 7e3d1f8 has been approved by nox
@bors-servo
Copy link
Contributor

bors-servo commented Jan 11, 2016

⌛ Testing commit 7e3d1f8 with merge 9827e51...
bors-servo added a commit that referenced this pull request Jan 11, 2016
@bors-servo
Auto merge of #9249 - Ms2ger:msg, r=nox
9827e51 
Remove unused dependencies from the msg crate.

<!-- Reviewable:start -->
[<img src="https://reviewable.io/review_button.png" height=40 alt="Review on Reviewable"/>](https://reviewable.io/reviews/servo/servo/9249)
<!-- Reviewable:end -->
@bors-servo
Copy link
Contributor

bors-servo commented Jan 11, 2016

💔 Test failed - mac-rel-css
@KiChjang
Copy link
Member

KiChjang commented Jan 11, 2016

@bors-servo retry
@bholley
Copy link
Contributor

bholley commented Jan 11, 2016

Nice! This will also help with @bholley's geckolib target

I actually have a patch to remove the dependency of style on msg entirely.
@bors-servo
Copy link
Contributor

bors-servo commented Jan 11, 2016

⌛ Testing commit 7e3d1f8 with merge bd7255d...
bors-servo added a commit that referenced this pull request Jan 11, 2016
@bors-servo
Auto merge of #9249 - Ms2ger:msg, r=nox
Loading status checks…
bd7255d 
Remove unused dependencies from the msg crate.

<!-- Reviewable:start -->
[<img src="https://reviewable.io/review_button.png" height=40 alt="Review on Reviewable"/>](https://reviewable.io/reviews/servo/servo/9249)
<!-- Reviewable:end -->
@emilio
Copy link
Member

emilio commented Jan 11, 2016

@bholley Well, nvm then. Sorry for the noise :/, hopefully bors won't be too anoying
@bors-servo
Copy link
Contributor

bors-servo commented Jan 11, 2016

☀️ Test successful - android, gonk, linux-dev, linux-rel, mac-dev-ref-unit, mac-rel-css, mac-rel-wpt
@bors-servo bors-servo merged commit 7e3d1f8 into servo:master Jan 11, 2016
2 checks passed
2 checks passed
continuous-integration/travis-ci/pr The Travis CI build passed
Details
homu Test successful
Details
@bors-servo bors-servo mentioned this pull request Jan 11, 2016
Merged
@Ms2ger Ms2ger deleted the Ms2ger:msg branch Jan 12, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@nox nox

Labels
S-awaiting-merge
Projects
None yet
Milestone
No milestone
Linked issues

Successfully merging this pull request may close these issues.

None yet

7 participants
@Ms2ger @nox @emilio @bors-servo @KiChjang @bholley @highfive
You can’t perform that action at this time.