Skip to content

/ servo

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move IFrameLoadInfo and IFrameSandboxState to script_traits #9257

Merged
merged 1 commit into from Jan 11, 2016
Merged

Move IFrameLoadInfo and IFrameSandboxState to script_traits #9257

merged 1 commit into from Jan 11, 2016

Conversation

@fmmrtns
Copy link
Contributor

fmmrtns commented Jan 11, 2016

Hi, this should fix #8841!
Any change that might be needed please tell me

Review on Reviewable
@highfive
Copy link

highfive commented Jan 11, 2016

Thanks for the pull request, and welcome! The Servo team is excited to review your changes, and you should hear from @jdm (or someone else) soon.
@fmmrtns fmmrtns changed the title moved IFrameLoadInfo and IFrameSandboxState to script_traits Moved IFrameLoadInfo and IFrameSandboxState to script_traits Jan 11, 2016
@fmmrtns fmmrtns changed the title Moved IFrameLoadInfo and IFrameSandboxState to script_traits Move IFrameLoadInfo and IFrameSandboxState to script_traits Jan 11, 2016
components/script_traits/script_msg.rs Outdated
@@ -2,11 +2,12 @@
* License, v. 2.0. If a copy of the MPL was not distributed with this
* file, You can obtain one at http://mozilla.org/MPL/2.0/. */

use ::IFrameLoadInfo;

This comment has been minimized.

Sign in to view
@jdm

jdm Jan 11, 2016

Member

This :: shouldn't be necessary. Be sure to run ./mach test-tidy after removing it, because the expected sort ordering will change.
@jdm
Copy link
Member

jdm commented Jan 11, 2016

Looks great, with one small nit!
@fmmrtns
moved IFrameLoadInfo and IFrameSandboxState to script_traits
Loading status checks…
0ef003c
@fmmrtns fmmrtns force-pushed the fmmrtns:refactor-scripttraits branch from b043bca to 0ef003c Jan 11, 2016
@fmmrtns
Copy link
Contributor Author

fmmrtns commented Jan 11, 2016

Thanks, I applied the changes and made sure to mach test-tidy 😉 (however, it didn't need any sort after removing the :: bit, but other other lines required some sorting that I didn't do in my first commit)
@jdm
Copy link
Member

jdm commented Jan 11, 2016

@bors-servo: r+
Thanks!
@bors-servo
Copy link
Contributor

bors-servo commented Jan 11, 2016

📌 Commit 0ef003c has been approved by jdm
@bors-servo
Copy link
Contributor

bors-servo commented Jan 11, 2016

⌛ Testing commit 0ef003c with merge fed41a4...
bors-servo added a commit that referenced this pull request Jan 11, 2016
@bors-servo
Auto merge of #9257 - fmmartins:refactor-scripttraits, r=jdm
Loading status checks…
fed41a4 
Move IFrameLoadInfo and IFrameSandboxState to script_traits

Hi, this should fix #8841!
Any change that might be needed please tell me

<!-- Reviewable:start -->
[<img src="https://reviewable.io/review_button.png" height=40 alt="Review on Reviewable"/>](https://reviewable.io/reviews/servo/servo/9257)
<!-- Reviewable:end -->
@bors-servo
Copy link
Contributor

bors-servo commented Jan 11, 2016

☀️ Test successful - android, gonk, linux-dev, linux-rel, mac-dev-ref-unit, mac-rel-css, mac-rel-wpt
@bors-servo bors-servo mentioned this pull request Jan 11, 2016
Merged
@bors-servo bors-servo merged commit 0ef003c into servo:master Jan 11, 2016
2 checks passed
2 checks passed
continuous-integration/travis-ci/pr The Travis CI build passed
Details
homu Test successful
Details
@bors-servo bors-servo mentioned this pull request Jan 11, 2016
Closed
@fmmrtns fmmrtns deleted the fmmrtns:refactor-scripttraits branch Jan 12, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
S-awaiting-merge
Projects
None yet
Milestone
No milestone
Linked issues

Successfully merging this pull request may close these issues.

Move IFrameLoadInfo struct and IFrameSandboxState enum to script_traits
4 participants
@fmmrtns @highfive @jdm @bors-servo
You can’t perform that action at this time.