Skip to content

/ servo

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove the msg dependency from style #9261

Merged
merged 1 commit into from Jan 12, 2016
Merged

Remove the msg dependency from style #9261

merged 1 commit into from Jan 12, 2016

Conversation

@bholley
Copy link
Contributor

bholley commented Jan 11, 2016

This is part of slimming down the dependencies of geckolib.

Review on Reviewable
@highfive
Copy link

highfive commented Jan 11, 2016

warning Warning warning

  • These commits modify layout code, but no reftests are modified. Please consider adding a reftest!
@bholley
Copy link
Contributor Author

bholley commented Jan 11, 2016

@bors-servo try
@bors-servo
Copy link
Contributor

bors-servo commented Jan 11, 2016

⌛ Trying commit f99078f with merge ec41930...
bors-servo added a commit that referenced this pull request Jan 11, 2016
@bors-servo
Auto merge of #9261 - bholley:geckolib_nomsg, r=<try>
ec41930 
Remove the msg dependency from style

This is part of slimming down the dependencies of geckolib.

<!-- Reviewable:start -->
[<img src="https://reviewable.io/review_button.png" height=40 alt="Review on Reviewable"/>](https://reviewable.io/reviews/servo/servo/9261)
<!-- Reviewable:end -->
@bholley
Copy link
Contributor Author

bholley commented Jan 11, 2016

r? @SimonSapin
python/tidy.py Outdated
@@ -39,6 +39,7 @@
os.path.join(".", "target", "*"),
os.path.join(".", "ports", "gonk", "src", "native_window_glue.cpp"),
os.path.join(".", "ports", "cef", "*"),
os.path.join(".", "ports", "geckolib", "*"),

This comment has been minimized.

Sign in to view
@jdm

jdm Jan 11, 2016

Member

I don't think we need to ignore this, do we?

This comment has been minimized.

Sign in to view
@bholley

bholley Jan 12, 2016

Author Contributor

Good catch - that was an accidental leftover from rebasing this over what actually landed in #9209.
@bors-servo
Copy link
Contributor

bors-servo commented Jan 11, 2016

☔ The latest upstream changes (presumably #9249) made this pull request unmergeable. Please resolve the merge conflicts.
@bors-servo
Copy link
Contributor

bors-servo commented Jan 11, 2016

💔 Test failed - gonk
@bholley
Copy link
Contributor Author

bholley commented Jan 12, 2016

@bors-servo try
@bholley bholley force-pushed the bholley:geckolib_nomsg branch from f99078f to e93effe Jan 12, 2016
@bholley
Copy link
Contributor Author

bholley commented Jan 12, 2016

@bors-servo try
@bors-servo
Copy link
Contributor

bors-servo commented Jan 12, 2016

🔒 Merge conflict
@bholley bholley force-pushed the bholley:geckolib_nomsg branch from e93effe to 390d47e Jan 12, 2016
@bholley
Copy link
Contributor Author

bholley commented Jan 12, 2016

@bors-servo try
@bors-servo
Copy link
Contributor

bors-servo commented Jan 12, 2016

⌛ Trying commit 390d47e with merge 6385e34...
bors-servo added a commit that referenced this pull request Jan 12, 2016
@bors-servo
Auto merge of #9261 - bholley:geckolib_nomsg, r=<try>
6385e34 
Remove the msg dependency from style

This is part of slimming down the dependencies of geckolib.

<!-- Reviewable:start -->
[<img src="https://reviewable.io/review_button.png" height=40 alt="Review on Reviewable"/>](https://reviewable.io/reviews/servo/servo/9261)
<!-- Reviewable:end -->
@bors-servo
Copy link
Contributor

bors-servo commented Jan 12, 2016

💔 Test failed - mac-dev-ref-unit
@KiChjang
Copy link
Member

KiChjang commented Jan 12, 2016

This is puzzling... #9254 didn't even land yet!
@bholley bholley mentioned this pull request Jan 12, 2016
Closed
@bholley
Hoist ParseErrorReporter into style and remove the dependency on msg.
Loading status checks…
384cdfc 
The pipeline id stuff is currently unused. If someone needs it, they can add
an additional trait bound on their css error reporter to get the pipeline id.
@bholley bholley force-pushed the bholley:geckolib_nomsg branch from 390d47e to 384cdfc Jan 12, 2016
@bholley
Copy link
Contributor Author

bholley commented Jan 12, 2016

@bors-servo try
@bors-servo
Copy link
Contributor

bors-servo commented Jan 12, 2016

⌛ Trying commit 384cdfc with merge b26b4ab...
bors-servo added a commit that referenced this pull request Jan 12, 2016
@bors-servo
Auto merge of #9261 - bholley:geckolib_nomsg, r=<try>
b26b4ab 
Remove the msg dependency from style

This is part of slimming down the dependencies of geckolib.

<!-- Reviewable:start -->
[<img src="https://reviewable.io/review_button.png" height=40 alt="Review on Reviewable"/>](https://reviewable.io/reviews/servo/servo/9261)
<!-- Reviewable:end -->
@bors-servo
Copy link
Contributor

bors-servo commented Jan 12, 2016

☀️ Test successful - android, gonk, linux-dev, linux-rel, mac-dev-ref-unit, mac-rel-css, mac-rel-wpt
@Manishearth
Copy link
Member

Manishearth commented Jan 12, 2016

@bors-servo r+
@bors-servo
Copy link
Contributor

bors-servo commented Jan 12, 2016

📌 Commit 384cdfc has been approved by Manishearth
@bors-servo
Copy link
Contributor

bors-servo commented Jan 12, 2016

⌛ Testing commit 384cdfc with merge 3680e82...
bors-servo added a commit that referenced this pull request Jan 12, 2016
@bors-servo
Auto merge of #9261 - bholley:geckolib_nomsg, r=Manishearth
Loading status checks…
3680e82 
Remove the msg dependency from style

This is part of slimming down the dependencies of geckolib.

<!-- Reviewable:start -->
[<img src="https://reviewable.io/review_button.png" height=40 alt="Review on Reviewable"/>](https://reviewable.io/reviews/servo/servo/9261)
<!-- Reviewable:end -->
@bholley
Copy link
Contributor Author

bholley commented Jan 12, 2016

fixes #9246
@bors-servo
Copy link
Contributor

bors-servo commented Jan 12, 2016

☀️ Test successful - android, gonk, linux-dev, linux-rel, mac-dev-ref-unit, mac-rel-css, mac-rel-wpt
@bors-servo bors-servo mentioned this pull request Jan 12, 2016
Merged
@bors-servo bors-servo merged commit 384cdfc into servo:master Jan 12, 2016
2 checks passed
2 checks passed
continuous-integration/travis-ci/pr The Travis CI build passed
Details
homu Test successful
Details
@KiChjang KiChjang mentioned this pull request Jan 12, 2016
Closed
@bholley bholley deleted the bholley:geckolib_nomsg branch Oct 30, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@SimonSapin SimonSapin

Labels
S-awaiting-merge
Projects
None yet
Milestone
No milestone
Linked issues

Successfully merging this pull request may close these issues.

None yet

7 participants
@bholley @highfive @bors-servo @KiChjang @Manishearth @jdm @SimonSapin
You can’t perform that action at this time.