Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upAdd build-essential to Debian based Linuxes' requirements #9264
Conversation
highfive
commented
Jan 11, 2016
|
Thanks for the pull request, and welcome! The Servo team is excited to review your changes, and you should hear from @Ms2ger (or someone else) soon. |
|
@bors-servo: r+ |
|
|
bors-servo
added a commit
that referenced
this pull request
Jan 12, 2016
…-essential, r=jdm Add build-essential to Debian based Linuxes' requirements This is discovered here: #9262 Particularly `make` needs to be available. Usually on developer workstation `build-essential` is already installed. That is why it wasn't there in requirements. It occurs that if you use minimal ubuntu image for some kind of automated build, it doesn't have `build-essential` by default. So would be nice to still have `build-essential` there in the command. -- Kind Regards, Oleksii -- /cc @jdm <!-- Reviewable:start --> [<img src="https://reviewable.io/review_button.png" height=40 alt="Review on Reviewable"/>](https://reviewable.io/reviews/servo/servo/9264) <!-- Reviewable:end -->
|
|
|
hmm, that is strange. Is this failure related to the change? |
|
@bors-servo: retry
|
bors-servo
added a commit
that referenced
this pull request
Jan 12, 2016
…-essential, r=jdm Add build-essential to Debian based Linuxes' requirements This is discovered here: #9262 Particularly `make` needs to be available. Usually on developer workstation `build-essential` is already installed. That is why it wasn't there in requirements. It occurs that if you use minimal ubuntu image for some kind of automated build, it doesn't have `build-essential` by default. So would be nice to still have `build-essential` there in the command. -- Kind Regards, Oleksii -- /cc @jdm <!-- Reviewable:start --> [<img src="https://reviewable.io/review_button.png" height=40 alt="Review on Reviewable"/>](https://reviewable.io/reviews/servo/servo/9264) <!-- Reviewable:end -->
|
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
waterlink commentedJan 11, 2016
This is discovered here: #9262
Particularly
makeneeds to be available.Usually on developer workstation
build-essentialis already installed. That is why it wasn't there in requirements.It occurs that if you use minimal ubuntu image for some kind of automated build, it doesn't have
build-essentialby default. So would be nice to still havebuild-essentialthere in the command.Kind Regards,
Oleksii
/cc @jdm