Skip to content

/ servo

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use cargo features to reduce the dependencies of components/util in GeckoLib builds #9267

Merged
merged 2 commits into from Jan 12, 2016
Merged

Use cargo features to reduce the dependencies of components/util in GeckoLib builds #9267

merged 2 commits into from Jan 12, 2016

Conversation

@bholley
Copy link
Contributor

bholley commented Jan 12, 2016

Fixes #9260.

Review on Reviewable
bholley added 2 commits Jan 9, 2016
@bholley
Hoist ParseErrorReporter into style and remove the dependency on msg.
Loading status checks…
384cdfc 
The pipeline id stuff is currently unused. If someone needs it, they can add
an additional trait bound on their css error reporter to get the pipeline id.
@bholley
Use features to prevent the util component from entraining the world …
Loading status checks…
dec296d 
…in GeckoLib builds.
@highfive
Copy link

highfive commented Jan 12, 2016

warning Warning warning

  • These commits modify unsafe code. Please review it carefully!
  • These commits modify layout code, but no reftests are modified. Please consider adding a reftest!
@bholley
Copy link
Contributor Author

bholley commented Jan 12, 2016

@bors-servo try
@bors-servo
Copy link
Contributor

bors-servo commented Jan 12, 2016

⌛ Trying commit dec296d with merge 50521b7...
bors-servo added a commit that referenced this pull request Jan 12, 2016
@bors-servo
Auto merge of #9267 - bholley:geckolib_fixutil, r=<try>
50521b7 
Use cargo features to reduce the dependencies of components/util in GeckoLib builds

Fixes #9260.
@bholley
Copy link
Contributor Author

bholley commented Jan 12, 2016

r? @Manishearth
@Manishearth
Copy link
Member

Manishearth commented Jan 12, 2016

@bors-servo r+
@bors-servo
Copy link
Contributor

bors-servo commented Jan 12, 2016

📌 Commit dec296d has been approved by Manishearth
@bors-servo
Copy link
Contributor

bors-servo commented Jan 12, 2016

💔 Test failed - linux-rel
@bholley
Copy link
Contributor Author

bholley commented Jan 12, 2016

@bors-servo retry
@bors-servo
Copy link
Contributor

bors-servo commented Jan 12, 2016

⌛ Trying commit dec296d with merge 3cb2255...
bors-servo added a commit that referenced this pull request Jan 12, 2016
@bors-servo
Auto merge of #9267 - bholley:geckolib_fixutil, r=<try>
3cb2255 
Use cargo features to reduce the dependencies of components/util in GeckoLib builds

Fixes #9260.

<!-- Reviewable:start -->
[<img src="https://reviewable.io/review_button.png" height=40 alt="Review on Reviewable"/>](https://reviewable.io/reviews/servo/servo/9267)
<!-- Reviewable:end -->
@bors-servo
Copy link
Contributor

bors-servo commented Jan 12, 2016

☀️ Test successful - android, gonk, linux-dev, linux-rel, mac-dev-ref-unit, mac-rel-css, mac-rel-wpt
@bors-servo
Copy link
Contributor

bors-servo commented Jan 12, 2016

⌛ Testing commit dec296d with merge 6beebd3...
bors-servo added a commit that referenced this pull request Jan 12, 2016
@bors-servo
Auto merge of #9267 - bholley:geckolib_fixutil, r=Manishearth
Loading status checks…
6beebd3 
Use cargo features to reduce the dependencies of components/util in GeckoLib builds

Fixes #9260.

<!-- Reviewable:start -->
[<img src="https://reviewable.io/review_button.png" height=40 alt="Review on Reviewable"/>](https://reviewable.io/reviews/servo/servo/9267)
<!-- Reviewable:end -->
@bors-servo
Copy link
Contributor

bors-servo commented Jan 12, 2016

☀️ Test successful - android, gonk, linux-dev, linux-rel, mac-dev-ref-unit, mac-rel-css, mac-rel-wpt
@bors-servo bors-servo mentioned this pull request Jan 12, 2016
Closed
@bors-servo bors-servo merged commit dec296d into servo:master Jan 12, 2016
2 checks passed
2 checks passed
continuous-integration/travis-ci/pr The Travis CI build passed
Details
homu Test successful
Details
@bors-servo bors-servo mentioned this pull request Jan 12, 2016
Merged
@bholley bholley deleted the bholley:geckolib_fixutil branch Oct 30, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@Manishearth Manishearth

Labels
S-awaiting-merge
Projects
None yet
Milestone
No milestone
Linked issues

Successfully merging this pull request may close these issues.

None yet

4 participants
@bholley @highfive @bors-servo @Manishearth
You can’t perform that action at this time.