Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upMove `MozBrowserEvent` to `script_traits` #9271
Conversation
highfive
commented
Jan 12, 2016
|
Thanks for the pull request, and welcome! The Servo team is excited to review your changes, and you should hear from @Ms2ger (or someone else) soon. |
|
sry, overlooked the WIP and the rebase |
94f4faa
to
06911b6
|
-S-awaiting-review +S-needs-code-changes Thanks for taking up the issue! A couple of minor nits and this can be merged :) Reviewed 10 of 10 files at r1. components/compositing/constellation.rs, line 33 [r1] (raw file): components/compositing/constellation.rs, line 49 [r1] (raw file): components/compositing/pipeline.rs, line 28 [r1] (raw file): components/script/dom/htmliframeelement.rs, line 29 [r1] (raw file): components/script/dom/htmliframeelement.rs, line 34 [r1] (raw file): components/script/dom/htmllinkelement.rs, line 27 [r1] (raw file): components/script/dom/htmllinkelement.rs, line 30 [r1] (raw file): components/script/dom/window.rs, line 60 [r1] (raw file): components/script/script_thread.rs, line 86 [r1] (raw file): Comments from the review on Reviewable.io |
06911b6
to
0fb0615
|
-S-awaiting-review All good! Thanks for taking the time to work on this! @bors-servo r+ Reviewed 7 of 7 files at r2. Comments from the review on Reviewable.io |
|
|
Move `MozBrowserEvent` to `script_traits` close #9225 <!-- Reviewable:start --> [<img src="https://reviewable.io/review_button.png" height=40 alt="Review on Reviewable"/>](https://reviewable.io/reviews/servo/servo/9271) <!-- Reviewable:end -->
|
|
|
@bors-servo retry Git snafu. |
|
|
|
|
0fb0615
to
79e69c9
|
rebased |
|
@bors-servo r+ |
|
|
79e69c9
to
4b773ce
|
@KiChjang and another |
|
@bors-servo r+ |
|
|
Move `MozBrowserEvent` to `script_traits` close #9225 <!-- Reviewable:start --> [<img src="https://reviewable.io/review_button.png" height=40 alt="Review on Reviewable"/>](https://reviewable.io/reviews/servo/servo/9271) <!-- Reviewable:end -->
|
|
apopiak commentedJan 12, 2016
close #9225