Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove some unused extern crates. #9275

Merged
merged 1 commit into from Jan 13, 2016
Merged

Remove some unused extern crates. #9275

merged 1 commit into from Jan 13, 2016

Conversation

@Ms2ger
Copy link
Contributor

Ms2ger commented Jan 12, 2016

Review on Reviewable

@highfive
Copy link

highfive commented Jan 12, 2016

warning Warning warning

  • These commits modify layout code, but no reftests are modified. Please consider adding a reftest!
@larsbergstrom
Copy link
Contributor

larsbergstrom commented Jan 12, 2016

@bors-servo
Copy link
Contributor

bors-servo commented Jan 12, 2016

📌 Commit b830935 has been approved by larsbergstrom

@bors-servo
Copy link
Contributor

bors-servo commented Jan 12, 2016

Testing commit b830935 with merge 2cb0786...

bors-servo added a commit that referenced this pull request Jan 12, 2016
Remove some unused extern crates.

<!-- Reviewable:start -->
[<img src="https://reviewable.io/review_button.png" height=40 alt="Review on Reviewable"/>](https://reviewable.io/reviews/servo/servo/9275)
<!-- Reviewable:end -->
@bors-servo
Copy link
Contributor

bors-servo commented Jan 12, 2016

💔 Test failed - android

@larsbergstrom
Copy link
Contributor

larsbergstrom commented Jan 12, 2016

main.rs:28:1: 28:19 error: use of unstable library feature 'libc': use `libc` from crates.io (see issue #27783)
main.rs:28 extern crate libc;
           ^~~~~~~~~~~~~~~~~~
main.rs:28:1: 28:19 help: add #![feature(libc)] to the crate attributes to enable
main.rs:210:23: 210:35 error: use of unstable library feature 'libc': use `libc` from crates.io (see issue #27783)
main.rs:210     fn app_dummy() -> libc::c_void;
                                  ^~~~~~~~~~~~
main.rs:210:23: 210:35 help: add #![feature(libc)] to the crate attributes to enable
main.rs:224:5: 224:23 error: use of unstable library feature 'libc': use `libc` from crates.io (see issue #27783)
main.rs:224     extern crate libc;
                ^~~~~~~~~~~~~~~~~~
main.rs:224:5: 224:23 help: add #![feature(libc)] to the crate attributes to enable
main.rs:226:9: 226:26 error: use of unstable library feature 'libc': use `libc` from crates.io (see issue #27783)
main.rs:226     use self::libc::c_int;
                    ^~~~~~~~~~~~~~~~~
main.rs:226:9: 226:26 help: add #![feature(libc)] to the crate attributes to enable
main.rs:230:26: 230:39 error: use of unstable library feature 'libc': use `libc` from crates.io (see issue #27783)
main.rs:230         use self::libc::{STDERR_FILENO, STDOUT_FILENO};
                                     ^~~~~~~~~~~~~
main.rs:230:26: 230:39 help: add #![feature(libc)] to the crate attributes to enable
main.rs:230:41: 230:54 error: use of unstable library feature 'libc': use `libc` from crates.io (see issue #27783)
main.rs:230         use self::libc::{STDERR_FILENO, STDOUT_FILENO};
                                                    ^~~~~~~~~~~~~
main.rs:230:41: 230:54 help: add #![feature(libc)] to the crate attributes to enable
main.rs:234:25: 234:38 error: use of unstable library feature 'libc': use `libc` from crates.io (see issue #27783)
main.rs:234         redirect_output(STDERR_FILENO);
                                    ^~~~~~~~~~~~~
main.rs:234:25: 234:38 help: add #![feature(libc)] to the crate attributes to enable
main.rs:235:25: 235:38 error: use of unstable library feature 'libc': use `libc` from crates.io (see issue #27783)
main.rs:235         redirect_output(STDOUT_FILENO);
                                    ^~~~~~~~~~~~~
main.rs:235:25: 235:38 help: add #![feature(libc)] to the crate attributes to enable
main.rs:240:25: 240:41 error: use of unstable library feature 'libc': use `libc` from crates.io (see issue #27783)
main.rs:240     struct FilePtr(*mut self::libc::FILE);
                                    ^~~~~~~~~~~~~~~~
main.rs:240:25: 240:41 help: add #![feature(libc)] to the crate attributes to enable
main.rs:244:33: 244:38 error: use of unstable library feature 'libc': use `libc` from crates.io (see issue #27783)
main.rs:244     fn redirect_output(file_no: c_int) {
                                            ^~~~~
main.rs:244:33: 244:38 help: add #![feature(libc)] to the crate attributes to enable
main.rs:245:13: 245:31 error: use of unstable library feature 'libc': use `libc` from crates.io (see issue #27783)
main.rs:245         use self::libc::fdopen;
                        ^~~~~~~~~~~~~~~~~~
main.rs:245:13: 245:31 help: add #![feature(libc)] to the crate attributes to enable
main.rs:246:13: 246:30 error: use of unstable library feature 'libc': use `libc` from crates.io (see issue #27783)
main.rs:246         use self::libc::fgets;
                        ^~~~~~~~~~~~~~~~~
main.rs:246:13: 246:30 help: add #![feature(libc)] to the crate attributes to enable
main.rs:247:26: 247:30 error: use of unstable library feature 'libc': use `libc` from crates.io (see issue #27783)
main.rs:247         use self::libc::{pipe, dup2};
                                     ^~~~
main.rs:247:26: 247:30 help: add #![feature(libc)] to the crate attributes to enable
main.rs:247:32: 247:36 error: use of unstable library feature 'libc': use `libc` from crates.io (see issue #27783)
main.rs:247         use self::libc::{pipe, dup2};
                                           ^~~~
main.rs:247:32: 247:36 help: add #![feature(libc)] to the crate attributes to enable
main.rs:254:29: 254:34 error: use of unstable library feature 'libc': use `libc` from crates.io (see issue #27783)
main.rs:254             let mut pipes: [c_int; 2] = [ 0, 0 ];
                                        ^~~~~
main.rs:254:29: 254:34 help: add #![feature(libc)] to the crate attributes to enable
main.rs:255:13: 255:17 error: use of unstable library feature 'libc': use `libc` from crates.io (see issue #27783)
main.rs:255             pipe(pipes.as_mut_ptr());
                        ^~~~
main.rs:255:13: 255:17 help: add #![feature(libc)] to the crate attributes to enable
main.rs:256:13: 256:17 error: use of unstable library feature 'libc': use `libc` from crates.io (see issue #27783)
main.rs:256             dup2(pipes[1], file_no);
                        ^~~~
main.rs:256:13: 256:17 help: add #![feature(libc)] to the crate attributes to enable
main.rs:258:38: 258:44 error: use of unstable library feature 'libc': use `libc` from crates.io (see issue #27783)
main.rs:258             let input_file = FilePtr(fdopen(pipes[0], mode.as_ptr()));
                                                 ^~~~~~
main.rs:258:38: 258:44 help: add #![feature(libc)] to the crate attributes to enable
main.rs:264:21: 264:26 error: use of unstable library feature 'libc': use `libc` from crates.io (see issue #27783)
main.rs:264                     fgets(read_buffer.as_mut_ptr(), (read_buffer.len() as i32)-1, input_file);
                                ^~~~~
main.rs:264:21: 264:26 help: add #![feature(libc)] to the crate attributes to enable
main.rs:35:5: 35:14 warning: unused import, #[warn(unused_imports)] on by default
main.rs:35 use gleam::gl;
               ^~~~~~~~~
main.rs:36:28: 36:37 warning: unused import, #[warn(unused_imports)] on by default
main.rs:36 use offscreen_gl_context::{GLContext, NativeGLContext};
                                      ^~~~~~~~~
main.rs:36:39: 36:54 warning: unused import, #[warn(unused_imports)] on by default
main.rs:36 use offscreen_gl_context::{GLContext, NativeGLContext};
                                                 ^~~~~~~~~~~~~~~
error: aborting due to 19 previous errors
Could not compile `servo`.
@Ms2ger Ms2ger force-pushed the Ms2ger:extern-crate branch from b830935 to 86d3c57 Jan 13, 2016
@Ms2ger
Copy link
Contributor Author

Ms2ger commented Jan 13, 2016

Fixed

@KiChjang
Copy link
Member

KiChjang commented Jan 13, 2016

@bors-servo r=larsbergstrom

@bors-servo
Copy link
Contributor

bors-servo commented Jan 13, 2016

📌 Commit 86d3c57 has been approved by larsbergstrom

@bors-servo
Copy link
Contributor

bors-servo commented Jan 13, 2016

Testing commit 86d3c57 with merge d2b3c2a...

bors-servo added a commit that referenced this pull request Jan 13, 2016
Remove some unused extern crates.

<!-- Reviewable:start -->
[<img src="https://reviewable.io/review_button.png" height=40 alt="Review on Reviewable"/>](https://reviewable.io/reviews/servo/servo/9275)
<!-- Reviewable:end -->
@bors-servo
Copy link
Contributor

bors-servo commented Jan 13, 2016

💔 Test failed - linux-rel

@nox
Copy link
Member

nox commented Jan 13, 2016

@bors-servo
Copy link
Contributor

bors-servo commented Jan 13, 2016

Testing commit 86d3c57 with merge 0b5dda3...

bors-servo added a commit that referenced this pull request Jan 13, 2016
Remove some unused extern crates.

<!-- Reviewable:start -->
[<img src="https://reviewable.io/review_button.png" height=40 alt="Review on Reviewable"/>](https://reviewable.io/reviews/servo/servo/9275)
<!-- Reviewable:end -->
@bors-servo
Copy link
Contributor

bors-servo commented Jan 13, 2016

@bors-servo bors-servo merged commit 86d3c57 into servo:master Jan 13, 2016
2 checks passed
2 checks passed
continuous-integration/travis-ci/pr The Travis CI build passed
Details
homu Test successful
Details
@Ms2ger Ms2ger deleted the Ms2ger:extern-crate branch Feb 23, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

6 participants
You can’t perform that action at this time.