Skip to content

/ servo

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Call WPT lint directly in tidy, fixes #9189 #9277

Merged
merged 1 commit into from Jan 13, 2016
Merged

Call WPT lint directly in tidy, fixes #9189 #9277

merged 1 commit into from Jan 13, 2016

Conversation

@PythonNut
Copy link
Contributor

PythonNut commented Jan 12, 2016

This should be fairly straightforward. :)

Review on Reviewable
@wafflespeanut
Copy link
Member

wafflespeanut commented Jan 12, 2016

Mmm, beautiful! :)

@bors-servo r+

Thanks!
@bors-servo
Copy link
Contributor

bors-servo commented Jan 12, 2016

📌 Commit 700e35d has been approved by Wafflespeanut
@PythonNut
Copy link
Contributor Author

PythonNut commented Jan 12, 2016

Actually, I made a slight mistake refactoring, and lint.main() is called twice. Let me fix that.
@PythonNut
Call WPT lint directly in tidy, fixes #9189
Loading status checks…
fcd33e2
@PythonNut PythonNut force-pushed the PythonNut:master branch from 700e35d to fcd33e2 Jan 12, 2016
@PythonNut
Copy link
Contributor Author

PythonNut commented Jan 12, 2016

Sorry about that.
@wafflespeanut
Copy link
Member

wafflespeanut commented Jan 13, 2016

@bors-servo r-

never mind, I missed that too :)
@wafflespeanut
Copy link
Member

wafflespeanut commented Jan 13, 2016

@bors-servo r+
@bors-servo
Copy link
Contributor

bors-servo commented Jan 13, 2016

📌 Commit fcd33e2 has been approved by Wafflespeanut
@bors-servo
Copy link
Contributor

bors-servo commented Jan 13, 2016

⌛ Testing commit fcd33e2 with merge b6ecb0f...
bors-servo added a commit that referenced this pull request Jan 13, 2016
@bors-servo
Auto merge of #9277 - PythonNut:master, r=Wafflespeanut
b6ecb0f 
Call WPT lint directly in tidy, fixes #9189

This should be fairly straightforward. :)

<!-- Reviewable:start -->
[<img src="https://reviewable.io/review_button.png" height=40 alt="Review on Reviewable"/>](https://reviewable.io/reviews/servo/servo/9277)
<!-- Reviewable:end -->
@bors-servo
Copy link
Contributor

bors-servo commented Jan 13, 2016

💔 Test failed - linux-rel
@PythonNut
Copy link
Contributor Author

PythonNut commented Jan 13, 2016

▶ Unexpected subtest result in /html/infrastructure/terminology/plugins/text-plain.html:
└ PASS [expected FAIL] A user agent must not consider the type text/plain as having a registered plugin.

I'm not familiar with this testing framework. I went looking for references to that file in the test-wpt.log, but I couldn't find anything useful.

How can I look into resolving this?
@jdm
Copy link
Member

jdm commented Jan 13, 2016

@bors-servo: retry
@jdm
Copy link
Member

jdm commented Jan 13, 2016

It's just an unexpected, intermittent test result that's unrelated to these changes.
@bors-servo
Copy link
Contributor

bors-servo commented Jan 13, 2016

⌛ Testing commit fcd33e2 with merge 9c8382c...
bors-servo added a commit that referenced this pull request Jan 13, 2016
@bors-servo
Auto merge of #9277 - PythonNut:master, r=Wafflespeanut
Loading status checks…
9c8382c 
Call WPT lint directly in tidy, fixes #9189

This should be fairly straightforward. :)

<!-- Reviewable:start -->
[<img src="https://reviewable.io/review_button.png" height=40 alt="Review on Reviewable"/>](https://reviewable.io/reviews/servo/servo/9277)
<!-- Reviewable:end -->
@bors-servo
Copy link
Contributor

bors-servo commented Jan 13, 2016

☀️ Test successful - android, gonk, linux-dev, linux-rel, mac-dev-ref-unit, mac-rel-css, mac-rel-wpt
@bors-servo bors-servo merged commit fcd33e2 into servo:master Jan 13, 2016
2 checks passed
2 checks passed
continuous-integration/travis-ci/pr The Travis CI build passed
Details
homu Test successful
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@wafflespeanut wafflespeanut

Labels
S-awaiting-merge
Projects
None yet
Milestone
No milestone
Linked issues

Successfully merging this pull request may close these issues.

None yet

5 participants
@PythonNut @wafflespeanut @bors-servo @jdm @highfive
You can’t perform that action at this time.