Skip to content

/ servo

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement HTMLHyperlinkElementUtils for HTMLAnchorElement #9292

Closed
wants to merge 1 commit into from
Closed

Implement HTMLHyperlinkElementUtils for HTMLAnchorElement #9292

wants to merge 1 commit into from

Conversation

@Ms2ger
Copy link
Contributor

Ms2ger commented Jan 13, 2016

Fixes #7857.

Review on Reviewable
@jdramani @Ms2ger
Implement HTMLHyperlinkElementUtils for HTMLAnchorElement
Loading status checks…
c416b33
@highfive
Copy link

highfive commented Jan 13, 2016

warning Warning warning

  • These commits modify script code, but no tests are modified. Please consider adding a test!
@Ms2ger Ms2ger mentioned this pull request Jan 13, 2016
Closed
@nox
Copy link
Member

nox commented Jan 13, 2016

r=me but why don't we use AttrValue::Url?
@nox
Copy link
Member

nox commented Jan 13, 2016

Actually, r-. What happens if you try to set the password of a <a> element with no href attribute?
@nox nox self-assigned this Jan 13, 2016
@Ms2ger
Copy link
Contributor Author

Ms2ger commented Jan 13, 2016

This is a WIP; I might get around to finishing it at some point.
@jdm jdm mentioned this pull request Feb 26, 2016
Closed
@jdm
Copy link
Member

jdm commented Feb 26, 2016

Closed due to lack of updates.
@jdm jdm closed this Feb 26, 2016
@frewsxcv frewsxcv deleted the HTMLHyperlinkElementUtils branch Feb 28, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@nox nox

Labels
S-needs-code-changes
Projects
None yet
Milestone
No milestone
Linked issues

Successfully merging this pull request may close these issues.

None yet

5 participants
@Ms2ger @highfive @nox @jdm @jdramani
You can’t perform that action at this time.