Skip to content

/ servo

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add instructions to update create.rs when adding new DOM interfaces #9297

Merged
merged 1 commit into from Jan 14, 2016
Merged

Add instructions to update create.rs when adding new DOM interfaces #9297

merged 1 commit into from Jan 14, 2016

Conversation

@KiChjang
Copy link
Member

KiChjang commented Jan 13, 2016

Review on Reviewable
@highfive
Copy link

highfive commented Jan 13, 2016

warning Warning warning

  • These commits modify script code, but no tests are modified. Please consider adding a test!
@emilio
Copy link
Member

emilio commented Jan 13, 2016

Review status: 0 of 1 files reviewed at latest revision, 1 unresolved discussion.

components/script/dom/mod.rs, line 190 [r1] (raw file):
Please clarify that this is only needed when adding a new HTMLElement, no other kind of interfaces.

Comments from the review on Reviewable.io
@KiChjang KiChjang force-pushed the KiChjang:document-new-elements branch 2 times, most recently from d9132e3 to b4a0d5b Jan 13, 2016
@KiChjang
Add instructions to update create.rs when adding new DOM interfaces
Loading status checks…
b4a0d5b
@KiChjang
Copy link
Member Author

KiChjang commented Jan 13, 2016

Done.
@emilio
Copy link
Member

emilio commented Jan 13, 2016

@bors-servo: r+ rollup
@bors-servo
Copy link
Contributor

bors-servo commented Jan 13, 2016

📌 Commit b4a0d5b has been approved by ecoal95
@bors-servo
Copy link
Contributor

bors-servo commented Jan 14, 2016

⌛ Testing commit b4a0d5b with merge 396d411...
bors-servo added a commit that referenced this pull request Jan 14, 2016
@bors-servo
Auto merge of #9297 - KiChjang:document-new-elements, r=ecoal95
Loading status checks…
396d411 
Add instructions to update create.rs when adding new DOM interfaces

<!-- Reviewable:start -->
[<img src="https://reviewable.io/review_button.png" height=40 alt="Review on Reviewable"/>](https://reviewable.io/reviews/servo/servo/9297)
<!-- Reviewable:end -->
@bors-servo
Copy link
Contributor

bors-servo commented Jan 14, 2016

💔 Test failed - linux-rel
@KiChjang
Copy link
Member Author

KiChjang commented Jan 14, 2016

@bors-servo retry
@bors-servo
Copy link
Contributor

bors-servo commented Jan 14, 2016

⚡ Previous build results for android, gonk, linux-dev, mac-dev-ref-unit, mac-rel-css, mac-rel-wpt are reusable. Rebuilding only linux-rel...
@bors-servo
Copy link
Contributor

bors-servo commented Jan 14, 2016

☀️ Test successful - android, gonk, linux-dev, linux-rel, mac-dev-ref-unit, mac-rel-css, mac-rel-wpt
@bors-servo bors-servo merged commit b4a0d5b into servo:master Jan 14, 2016
2 checks passed
2 checks passed
continuous-integration/travis-ci/pr The Travis CI build passed
Details
homu Test successful
Details
@KiChjang KiChjang deleted the KiChjang:document-new-elements branch Jan 14, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Linked issues

Successfully merging this pull request may close these issues.

None yet

5 participants
@KiChjang @highfive @emilio @bors-servo @SimonSapin
You can’t perform that action at this time.