Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upUpdate cargo #9314
Update cargo #9314
Conversation
|
@bors-servo try |
Update cargo r? @Manishearth (wait for a try run first - I can't repro the -fPIC stuff from the previous one right now, but we'll see...)
|
r=me |
|
This is another attempt at #8375, but I'll actually dig into the problem this time :-) |
|
|
|
Fascinating! Our build machines have fontconfig version 2.11 installed. As you can see in the build.rs here: https://github.com/servo/libfontconfig/blob/master/build.rs, if there is not a system fontconfig >= 2.11.1, we'll compile locally. So here's where it gets interesting! With an older cargo, we still link fine (these are our CI machines, and it's what we do today, with our ~9/30/2015 cargo). With an updated cargo, though, we do not! The only idea I have is that maybe older cargo had some sort of bug around still adding system directories to the search path and picking up libfontconfig.a that was version 2.11 instead of the newly built one anyway. I will keep looking into this today/tomorrow. CC @alexcrichton, since I assume he'll be morbidly curious what I find out :-) Also CC @AutomatedTester since he's been hitting this on his machine. |
|
Oh dear that does seem interesting... I guess the most useful output would be the build script of the |
AutomatedTester
commented
Jan 15, 2016
|
I think @andreastt was hitting this ( I havent built servo in a while |
|
@AutomatedTester Sorry about the mis-mention! My "IRC nick to GH username" map is not great :-/ |
|
If my bisecting is correct (I had to skip a few commits that didn’t compile), the bad commit in cargo is rust-lang/cargo@8995f30: I haven’t had time to look at that changeset yet. |
|
Verbose output from the build is here: https://gist.github.com/larsbergstrom/54d9fc2169ff93896a12 It appears that |
|
Sorry, disregard my comment above about the sinning commit in cargo, as it only contained test changes. I ran my bisect again, not skipping any commits, and I ended up hitting rust-lang/cargo@659f824, which… unfortunately is not entirely trivial. |
|
Hm I'm not 100% sure how that would lead to the bug being seen here (or the regression more accurately), but I suspect that understanding what's going on under the hood would also help |
|
@alexcrichton So. I may have a "fix" for this problem, but it confuses me a bit. Can you provide some insight? If I remove the line: I noticed from the verbose build logs that we were getting an additional I'm not really sure how that leads to this error, though it can't be good that there's both a static copy of fontconfig that we've built being linked into an rlib PLUS another copy of fontconfig being linked in, which is either coming from the same build directory OR from the link lib search path (I have no idea which one). |
|
Based on IRC, I went to look for other places where we also attempt to link in |
|
After some discussion on IRC, we managed to track this down to a cargo bug: rust-lang/cargo#2354 |
|
@bors-servo try |
|
|
Update cargo r? @Manishearth (wait for a try run first - I can't repro the -fPIC stuff from the previous one right now, but we'll see...) <!-- Reviewable:start --> [<img src="https://reviewable.io/review_button.png" height=40 alt="Review on Reviewable"/>](https://reviewable.io/reviews/servo/servo/9314) <!-- Reviewable:end -->
|
|
|
@bors-servo try- retry p=10 |
|
@bors-servo r=Manishearth |
|
|
|
Update cargo r? @Manishearth (wait for a try run first - I can't repro the -fPIC stuff from the previous one right now, but we'll see...) <!-- Reviewable:start --> [<img src="https://reviewable.io/review_button.png" height=40 alt="Review on Reviewable"/>](https://reviewable.io/reviews/servo/servo/9314) <!-- Reviewable:end -->
|
|
|
|
|
@bors-servo retry |
|
|
|
|
|
@bors-servo: retry |
|
|
|
|
|
@bors-servo retry |
|
|
|
|
|
@bors-servo: retry |
Update cargo r? @Manishearth (wait for a try run first - I can't repro the -fPIC stuff from the previous one right now, but we'll see...) <!-- Reviewable:start --> [<img src="https://reviewable.io/review_button.png" height=40 alt="Review on Reviewable"/>](https://reviewable.io/reviews/servo/servo/9314) <!-- Reviewable:end -->
|
|
larsbergstrom commentedJan 14, 2016
r? @Manishearth
(wait for a try run first - I can't repro the -fPIC stuff from the previous one right now, but we'll see...)