Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upImplement the rest of 'text-decoration' property. #932
+98
−30
Conversation
|
This work is excellent. A few minor things:
|
|
@metajack Fixed your comments. Thanks! |
This comment has been minimized.
This comment has been minimized.
metajack
commented on 7436c10
Sep 16, 2013
|
r+ |
This comment has been minimized.
This comment has been minimized.
|
saw approval from metajack |
This comment has been minimized.
This comment has been minimized.
|
merging june0cho/servo/text_deco = 7436c107 into auto |
This comment has been minimized.
This comment has been minimized.
|
june0cho/servo/text_deco = 7436c107 merged ok, testing candidate = 2223eac |
This comment has been minimized.
This comment has been minimized.
|
some tests failed: |
bors-servo
pushed a commit
that referenced
this pull request
Sep 16, 2013
Implement 'overline' and 'line-through' in 'text-decoration' property. Add a test case.
|
I didn't declare one module in macos/font.rs so it occured the error. I fixed it now. Please test it again :) |
This comment has been minimized.
This comment has been minimized.
metajack
commented on d4ab2fc
Sep 16, 2013
|
r+ |
This comment has been minimized.
This comment has been minimized.
|
saw approval from metajack |
This comment has been minimized.
This comment has been minimized.
|
merging june0cho/servo/text_deco = d4ab2fc into auto |
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
|
fast-forwarding master to auto = 77a09b2 |
bors-servo
pushed a commit
that referenced
this pull request
Sep 16, 2013
Implement 'overline' and 'line-through' in 'text-decoration' property. Add a test case.
bors-servo
merged commit d4ab2fc
into
servo:master
1 check passed
1 check passed
default
all tests passed
ChrisParis
pushed a commit
to ChrisParis/servo
that referenced
this pull request
Sep 7, 2014
Remove support for falling back to an external domain since it was rather broken.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
june0cho commentedSep 13, 2013
Implement 'overline' and 'line-through' in 'text-decoration' property. Add a test case.