Add a script to list all CSS properties parsed by Servo. #9333

SimonSapin · 2016-01-15T14:52:15Z

I’ve been asked for that list by two different people this week :)


        Add a script to list all CSS properties parsed by Servo.

highfive · 2016-01-15T14:52:18Z

Heads up! This PR modifies the following files:

@bholley: components/style/list_properties.py

highfive · 2016-01-15T14:52:19Z

Warning

These commits modify style code, but no tests are modified. Please consider adding a test!

SimonSapin · 2016-01-15T14:58:33Z

@larsbergstrom could we run this on CI and publish the output somewhere?

nox · 2016-01-15T15:00:54Z

Could that be a mach command?

SimonSapin · 2016-01-15T15:11:05Z

Command that prints the list, or runs the smoke test?

nox · 2016-01-15T15:11:42Z

That prints the list.

SimonSapin · 2016-01-15T15:14:06Z

It didn’t seem worth the bother since I don’t expect people to use it interactively (as opposed to a script that maintains some other data), but it could.

larsbergstrom · 2016-01-15T15:17:11Z

@SimonSapin Seems like something we could add to the doc builder - https://github.com/servo/saltfs/blob/master/buildbot/master/master.cfg#L280-L287

larsbergstrom · 2016-01-15T15:18:07Z

@bors-servo r+

bors-servo · 2016-01-15T15:18:08Z

📌 Commit 9d29c3d has been approved by larsbergstrom

bors-servo · 2016-01-15T15:18:10Z

⌛ Testing commit 9d29c3d with merge c705e8e...


        Auto merge of #9333 - servo:list-properties, r=larsbergstrom

@larsbergstrom

Add a script to list all CSS properties parsed by Servo. I’ve been asked for that list by two different people this week :) r? @larsbergstrom  [<img src="https://reviewable.io/review_button.png" height=40 alt="Review on Reviewable"/>](https://reviewable.io/reviews/servo/servo/9333)

larsbergstrom · 2016-01-15T15:24:19Z

@bors-servo r+

bors-servo · 2016-01-15T15:24:21Z

📌 Commit 0d4330f has been approved by larsbergstrom

frewsxcv · 2016-01-15T15:35:50Z

components/style/list_properties.py

+
+template = Template(filename=os.path.join(style, "properties.mako.rs"), input_encoding='utf8')
+template.render()
+properties = dict(


Not worth changing, but FYI: https://www.python.org/dev/peps/pep-0274/

Yes, old habits of writing code that runs on 2.6 :)

bors-servo · 2016-01-15T17:06:14Z

⌛ Testing commit 0d4330f with merge b0de61d...


        Auto merge of #9333 - servo:list-properties, r=larsbergstrom

@larsbergstrom

Add a script to list all CSS properties parsed by Servo. I’ve been asked for that list by two different people this week :) r? @larsbergstrom  [<img src="https://reviewable.io/review_button.png" height=40 alt="Review on Reviewable"/>](https://reviewable.io/reviews/servo/servo/9333)


        Make the properties list JSON and add some more info.

SimonSapin · 2016-01-15T17:13:36Z

Oops tidy.

@bors-servo r=larsbergstrom

bors-servo · 2016-01-15T17:13:38Z

📌 Commit 2222f34 has been approved by larsbergstrom

bors-servo · 2016-01-15T17:55:54Z

⌛ Testing commit 2222f34 with merge 157b366...


        Auto merge of #9333 - servo:list-properties, r=larsbergstrom

@larsbergstrom

Add a script to list all CSS properties parsed by Servo. I’ve been asked for that list by two different people this week :) r? @larsbergstrom  [<img src="https://reviewable.io/review_button.png" height=40 alt="Review on Reviewable"/>](https://reviewable.io/reviews/servo/servo/9333)

LifeIsStrange · 2016-01-15T18:31:38Z

https://docs.google.com/spreadsheets/d/tdfNeB1mZP5gkgKpd3TWIAQ/htmlview#gid=555855884
There is currently this :)

bors-servo · 2016-01-15T18:59:49Z

💔 Test failed - mac-rel-css

KiChjang · 2016-01-15T19:04:03Z

@bors-servo retry

#9336

bors-servo · 2016-01-15T19:36:04Z

⌛ Testing commit 2222f34 with merge dba1f27...


        Auto merge of #9333 - servo:list-properties, r=larsbergstrom

@larsbergstrom

Add a script to list all CSS properties parsed by Servo. I’ve been asked for that list by two different people this week :) r? @larsbergstrom  [<img src="https://reviewable.io/review_button.png" height=40 alt="Review on Reviewable"/>](https://reviewable.io/reviews/servo/servo/9333)

bors-servo · 2016-01-15T20:16:36Z

💔 Test failed - linux-rel

KiChjang · 2016-01-15T20:19:21Z

@bors-servo retry

#9286

bors-servo · 2016-01-15T20:59:00Z

⚡ Previous build results for android, gonk, linux-dev, mac-dev-unit, mac-rel-css are reusable. Rebuilding only linux-rel, mac-rel-wpt...

bors-servo · 2016-01-15T21:44:38Z

☀️ Test successful - android, gonk, linux-dev, linux-rel, mac-dev-unit, mac-rel-css, mac-rel-wpt

SimonSapin · 2016-01-16T01:28:11Z

@LifeIsStrange that spreadsheet has to be maintained manually. The point of this script is that its output is always up to date.

LifeIsStrange · 2016-01-17T15:00:58Z

Oh sorry, I had misunderstood !

Add a script to list all CSS properties parsed by Servo.

Loading status checks…

9d29c3d

highfive added the S-awaiting-review label Jan 15, 2016

highfive removed the S-awaiting-review label Jan 15, 2016

highfive added the S-awaiting-merge label Jan 15, 2016

highfive added S-awaiting-review and removed S-awaiting-merge labels Jan 15, 2016

highfive added S-awaiting-merge and removed S-awaiting-review labels Jan 15, 2016

frewsxcv reviewed Jan 15, 2016
View changes

Make the properties list JSON and add some more info.

Loading status checks…

2222f34

SimonSapin force-pushed the list-properties branch from 0d4330f to 2222f34 Jan 15, 2016

highfive added S-awaiting-review and removed S-awaiting-merge labels Jan 15, 2016

highfive added S-awaiting-merge and removed S-awaiting-review labels Jan 15, 2016

highfive added S-tests-failed and removed S-awaiting-merge labels Jan 15, 2016

highfive added S-awaiting-merge and removed S-tests-failed labels Jan 15, 2016

highfive added S-tests-failed and removed S-awaiting-merge labels Jan 15, 2016

bors-servo merged commit 2222f34 into master Jan 15, 2016
2 checks passed

2 checks passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

homu Test successful
Details

SimonSapin deleted the list-properties branch Jan 16, 2016

SimonSapin removed the S-tests-failed label Jan 27, 2016

larsbergstrom mentioned this pull request Mar 25, 2016

Publish the CSS support list during doc builds #10196

Closed

servo / servo

Add a script to list all CSS properties parsed by Servo. #9333

Add a script to list all CSS properties parsed by Servo. #9333

SimonSapin commented Jan 15, 2016

highfive commented Jan 15, 2016

highfive commented Jan 15, 2016

SimonSapin commented Jan 15, 2016

nox commented Jan 15, 2016

SimonSapin commented Jan 15, 2016

nox commented Jan 15, 2016

SimonSapin commented Jan 15, 2016

larsbergstrom commented Jan 15, 2016

larsbergstrom commented Jan 15, 2016

bors-servo commented Jan 15, 2016

bors-servo commented Jan 15, 2016

larsbergstrom commented Jan 15, 2016

bors-servo commented Jan 15, 2016

This comment has been minimized.

This comment has been minimized.

bors-servo commented Jan 15, 2016

SimonSapin commented Jan 15, 2016

bors-servo commented Jan 15, 2016

bors-servo commented Jan 15, 2016

LifeIsStrange commented Jan 15, 2016

bors-servo commented Jan 15, 2016

KiChjang commented Jan 15, 2016

bors-servo commented Jan 15, 2016

bors-servo commented Jan 15, 2016

KiChjang commented Jan 15, 2016

bors-servo commented Jan 15, 2016

bors-servo commented Jan 15, 2016

SimonSapin commented Jan 16, 2016

LifeIsStrange commented Jan 17, 2016

servo / servo

Join GitHub today

Add a script to list all CSS properties parsed by Servo. #9333

Add a script to list all CSS properties parsed by Servo. #9333

Conversation

SimonSapin commented Jan 15, 2016

highfive commented Jan 15, 2016

highfive commented Jan 15, 2016

SimonSapin commented Jan 15, 2016

nox commented Jan 15, 2016

SimonSapin commented Jan 15, 2016

nox commented Jan 15, 2016

SimonSapin commented Jan 15, 2016

larsbergstrom commented Jan 15, 2016

larsbergstrom commented Jan 15, 2016

bors-servo commented Jan 15, 2016

bors-servo commented Jan 15, 2016

larsbergstrom commented Jan 15, 2016

bors-servo commented Jan 15, 2016

This comment has been minimized.

frewsxcv Jan 15, 2016

This comment has been minimized.

SimonSapin Jan 15, 2016

bors-servo commented Jan 15, 2016

SimonSapin commented Jan 15, 2016

bors-servo commented Jan 15, 2016

bors-servo commented Jan 15, 2016

LifeIsStrange commented Jan 15, 2016

bors-servo commented Jan 15, 2016

KiChjang commented Jan 15, 2016

bors-servo commented Jan 15, 2016

bors-servo commented Jan 15, 2016

KiChjang commented Jan 15, 2016

bors-servo commented Jan 15, 2016

bors-servo commented Jan 15, 2016

SimonSapin commented Jan 16, 2016

LifeIsStrange commented Jan 17, 2016