Skip to content

/ servo

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DOMContentLoaded event should be trusted #9334

Merged
merged 1 commit into from Jan 16, 2016
Merged

DOMContentLoaded event should be trusted #9334

merged 1 commit into from Jan 16, 2016

Conversation

@MonsieurLanza
Copy link
Contributor

MonsieurLanza commented Jan 15, 2016

Hopefully resolves #9332.

Review on Reviewable
@highfive
Copy link

highfive commented Jan 15, 2016

warning Warning warning

  • These commits modify script code, but no tests are modified. Please consider adding a test!
@MonsieurLanza MonsieurLanza force-pushed the MonsieurLanza:DomContentLoadedBubbles branch 3 times, most recently from aa4bcd0 to f9a4c10 Jan 15, 2016
@Ms2ger
Copy link
Contributor

Ms2ger commented Jan 15, 2016

@bors-servo r+

Thank you!
@bors-servo
Copy link
Contributor

bors-servo commented Jan 15, 2016

📌 Commit f9a4c10 has been approved by Ms2ger
@bors-servo
Copy link
Contributor

bors-servo commented Jan 15, 2016

⌛ Testing commit f9a4c10 with merge b290de4...
bors-servo added a commit that referenced this pull request Jan 15, 2016
@bors-servo
Auto merge of #9334 - MonsieurLanza:DomContentLoadedBubbles, r=Ms2ger
b290de4 
 DOMContentLoaded event should be trusted

Hopefully resolves #9332.

<!-- Reviewable:start -->
[<img src="https://reviewable.io/review_button.png" height=40 alt="Review on Reviewable"/>](https://reviewable.io/reviews/servo/servo/9334)
<!-- Reviewable:end -->
@bors-servo
Copy link
Contributor

bors-servo commented Jan 15, 2016

💔 Test failed - linux-rel
@KiChjang
Copy link
Member

KiChjang commented Jan 15, 2016 

Ran 3837 tests finished in 234.0 seconds.
  • 3835 ran as expected. 690 tests skipped.
  • 2 tests had unexpected subtest results

Tests with unexpected results:
  ▶ Unexpected subtest result in /dom/events/Event-dispatch-redispatch.html:
  └ PASS [expected FAIL] EventTarget#dispatchEvent(): redispatching a native event

  ▶ Unexpected subtest result in /html/infrastructure/terminology/plugins/text-plain.html:
  └ PASS [expected FAIL] A user agent must not consider the type text/plain as having a registered plugin.

The first one is a PASS that is fixed by this PR, the second one is #9286.
@KiChjang
Copy link
Member

KiChjang commented Jan 15, 2016

Perhaps I wasn't clear, but the test expectations for /dom/events/Event-dispatch-redispatch.html needs to be updated.
@MonsieurLanza
Copy link
Contributor Author

MonsieurLanza commented Jan 15, 2016

Done.
@KiChjang
Copy link
Member

KiChjang commented Jan 16, 2016

Could you also squash the commits?
@MonsieurLanza
Use fire_event instead of DispatchEvent to make DOMContentLoaded trusted
Loading status checks…
27b78f3 
Removed unused import.

Update expectations for EventTarget#dispatchEvent()
@MonsieurLanza MonsieurLanza force-pushed the MonsieurLanza:DomContentLoadedBubbles branch from 4f2e74f to 27b78f3 Jan 16, 2016
@MonsieurLanza
Copy link
Contributor Author

MonsieurLanza commented Jan 16, 2016

Done also. Seems I have to get some habits...
@KiChjang
Copy link
Member

KiChjang commented Jan 16, 2016

@bors-servo r+

Thanks for working on this!
@bors-servo
Copy link
Contributor

bors-servo commented Jan 16, 2016

📌 Commit 27b78f3 has been approved by KiChjang
@Ms2ger
Copy link
Contributor

Ms2ger commented Jan 16, 2016

@bors-servo p=1
@bors-servo
Copy link
Contributor

bors-servo commented Jan 16, 2016

⌛ Testing commit 27b78f3 with merge e7f6b47...
bors-servo added a commit that referenced this pull request Jan 16, 2016
@bors-servo
Auto merge of #9334 - MonsieurLanza:DomContentLoadedBubbles, r=KiChjang
e7f6b47 
 DOMContentLoaded event should be trusted

Hopefully resolves #9332.

<!-- Reviewable:start -->
[<img src="https://reviewable.io/review_button.png" height=40 alt="Review on Reviewable"/>](https://reviewable.io/reviews/servo/servo/9334)
<!-- Reviewable:end -->
@bors-servo
Copy link
Contributor

bors-servo commented Jan 16, 2016

💔 Test failed - linux-rel
@KiChjang
Copy link
Member

KiChjang commented Jan 16, 2016

@bors-servo retry
@bors-servo
Copy link
Contributor

bors-servo commented Jan 16, 2016

⌛ Testing commit 27b78f3 with merge 5a954d2...
bors-servo added a commit that referenced this pull request Jan 16, 2016
@bors-servo
Auto merge of #9334 - MonsieurLanza:DomContentLoadedBubbles, r=KiChjang
Loading status checks…
5a954d2 
 DOMContentLoaded event should be trusted

Hopefully resolves #9332.

<!-- Reviewable:start -->
[<img src="https://reviewable.io/review_button.png" height=40 alt="Review on Reviewable"/>](https://reviewable.io/reviews/servo/servo/9334)
<!-- Reviewable:end -->
@bors-servo
Copy link
Contributor

bors-servo commented Jan 16, 2016

☀️ Test successful - android, gonk, linux-dev, linux-rel, mac-dev-unit, mac-rel-css, mac-rel-wpt
@bors-servo bors-servo merged commit 27b78f3 into servo:master Jan 16, 2016
2 checks passed
2 checks passed
continuous-integration/travis-ci/pr The Travis CI build passed
Details
homu Test successful
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@KiChjang KiChjang

Labels
S-awaiting-merge
Projects
None yet
Milestone
No milestone
Linked issues

Successfully merging this pull request may close these issues.

DOMContentLoaded event should be trusted
6 participants
@MonsieurLanza @highfive @Ms2ger @bors-servo @KiChjang @jdm
You can’t perform that action at this time.