Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade servo-glutin to latest published version (0.4.7) #9339

Merged
merged 1 commit into from Jan 18, 2016

Conversation

@frewsxcv
Copy link
Member

frewsxcv commented Jan 16, 2016

servo/glutin@servo-v0.4.5...servo-v0.4.7

The primary reason I'm updating servo-glutin is to indirectly pick up
these changes:

Smithay/wayland-kbd#9

Daggerbot/x11-rs#32

...which results in two fewer libc 0.1.x dependency

#8608

Review on Reviewable

@frewsxcv
Copy link
Member Author

frewsxcv commented Jan 16, 2016

@bors-servo
Copy link
Contributor

bors-servo commented Jan 16, 2016

Trying commit 18f2da8 with merge 9ebd0fa...

bors-servo added a commit that referenced this pull request Jan 16, 2016
Upgrade servo-glutin to latest published version (0.4.6)

servo/glutin@servo-v0.4.5...servo-v0.4.6

The primary reason I'm updating servo-glutin is to indirectly pick up
this change:

Smithay/wayland-kbd#9

...which results in one fewer libc 0.1.x dependency

#8608
@bors-servo
Copy link
Contributor

bors-servo commented Jan 16, 2016

💔 Test failed - linux-rel

@frewsxcv
Copy link
Member Author

frewsxcv commented Jan 16, 2016

@bors-servo
Copy link
Contributor

bors-servo commented Jan 16, 2016

Trying commit 18f2da8 with merge 6c392d1...

bors-servo added a commit that referenced this pull request Jan 16, 2016
Upgrade servo-glutin to latest published version (0.4.6)

servo/glutin@servo-v0.4.5...servo-v0.4.6

The primary reason I'm updating servo-glutin is to indirectly pick up
this change:

Smithay/wayland-kbd#9

...which results in one fewer libc 0.1.x dependency

#8608

<!-- Reviewable:start -->
[<img src="https://reviewable.io/review_button.png" height=40 alt="Review on Reviewable"/>](https://reviewable.io/reviews/servo/servo/9339)
<!-- Reviewable:end -->
@bors-servo
Copy link
Contributor

bors-servo commented Jan 16, 2016

💔 Test failed - linux-rel

@frewsxcv
Copy link
Member Author

frewsxcv commented Jan 16, 2016

@bors-servo
Copy link
Contributor

bors-servo commented Jan 16, 2016

Trying commit 18f2da8 with merge 29faf15...

bors-servo added a commit that referenced this pull request Jan 16, 2016
Upgrade servo-glutin to latest published version (0.4.6)

servo/glutin@servo-v0.4.5...servo-v0.4.6

The primary reason I'm updating servo-glutin is to indirectly pick up
this change:

Smithay/wayland-kbd#9

...which results in one fewer libc 0.1.x dependency

#8608

<!-- Reviewable:start -->
[<img src="https://reviewable.io/review_button.png" height=40 alt="Review on Reviewable"/>](https://reviewable.io/reviews/servo/servo/9339)
<!-- Reviewable:end -->
@bors-servo
Copy link
Contributor

bors-servo commented Jan 16, 2016

💔 Test failed - linux-rel

@Ms2ger
Copy link
Contributor

Ms2ger commented Jan 16, 2016

@bors-servo
Copy link
Contributor

bors-servo commented Jan 16, 2016

Trying commit 18f2da8 with merge c3d6acc...

bors-servo added a commit that referenced this pull request Jan 16, 2016
Upgrade servo-glutin to latest published version (0.4.6)

servo/glutin@servo-v0.4.5...servo-v0.4.6

The primary reason I'm updating servo-glutin is to indirectly pick up
this change:

Smithay/wayland-kbd#9

...which results in one fewer libc 0.1.x dependency

#8608

<!-- Reviewable:start -->
[<img src="https://reviewable.io/review_button.png" height=40 alt="Review on Reviewable"/>](https://reviewable.io/reviews/servo/servo/9339)
<!-- Reviewable:end -->
@bors-servo
Copy link
Contributor

bors-servo commented Jan 16, 2016

💔 Test failed - linux-rel

@emilio
Copy link
Member

emilio commented Jan 16, 2016

There was a problem updating to the latest glutin (see #9115).

I actually have a computer that can reproduce it, so I'll take a look at it, but I don't think we should update glutin until that gets solved.

@emilio
Copy link
Member

emilio commented Jan 16, 2016

@frewsxcv
Copy link
Member Author

frewsxcv commented Jan 16, 2016

@frewsxcv
Copy link
Member Author

frewsxcv commented Jan 16, 2016

This is now blocked on servo/glutin#62

@frewsxcv
Copy link
Member Author

frewsxcv commented Jan 16, 2016

Reminder to myself to update the commit message of this commit to mention the x11-dl update which gets rid of another libc 0.1.x dep

servo/glutin@servo-v0.4.5...servo-v0.4.7

The primary reason I'm updating servo-glutin is to indirectly pick up
these changes:

Smithay/wayland-kbd#9

https://github.com/Daggerbot/x11-rs/pull/32

...which results in two fewer libc 0.1.x dependency

#8608
@frewsxcv frewsxcv force-pushed the frewsxcv:bump-glutin branch from 18f2da8 to f5c6c60 Jan 16, 2016
@frewsxcv
Copy link
Member Author

frewsxcv commented Jan 16, 2016

@frewsxcv frewsxcv changed the title Upgrade servo-glutin to latest published version (0.4.6) Upgrade servo-glutin to latest published version (0.4.7) Jan 16, 2016
@nox
Copy link
Member

nox commented Jan 16, 2016

@emilio
Copy link
Member

emilio commented Jan 17, 2016

@bors-servo: try (it seems to be up again)

@frewsxcv there are still libc 1.x deps, right? If there aren't we could remove libc from the dependency check that tidy does.

@emilio
Copy link
Member

emilio commented Jan 17, 2016

@SimonSapin
Copy link
Member

SimonSapin commented Jan 17, 2016

According to components/servo/Cargo.lock in this branch, libc 0.1 still has two dependents: malloc_buf and objc-foundation.

@SimonSapin
Copy link
Member

SimonSapin commented Jan 17, 2016

@bors-servo
Copy link
Contributor

bors-servo commented Jan 17, 2016

📌 Commit 18f2da8 has been approved by SimonSapin

@frewsxcv
Copy link
Member Author

frewsxcv commented Jan 18, 2016

@bors-servo r=SimonSapin

@bors-servo
Copy link
Contributor

bors-servo commented Jan 18, 2016

📌 Commit f5c6c60 has been approved by SimonSapin

@bors-servo
Copy link
Contributor

bors-servo commented Jan 18, 2016

Testing commit f5c6c60 with merge 6b81a72...

bors-servo added a commit that referenced this pull request Jan 18, 2016
Upgrade servo-glutin to latest published version (0.4.7)

servo/glutin@servo-v0.4.5...servo-v0.4.7

The primary reason I'm updating servo-glutin is to indirectly pick up
these changes:

Smithay/wayland-kbd#9

Daggerbot/x11-rs#32

...which results in two fewer libc 0.1.x dependency

#8608

<!-- Reviewable:start -->
[<img src="https://reviewable.io/review_button.png" height=40 alt="Review on Reviewable"/>](https://reviewable.io/reviews/servo/servo/9339)
<!-- Reviewable:end -->
@bors-servo
Copy link
Contributor

bors-servo commented Jan 18, 2016

💔 Test failed - linux-rel

@frewsxcv
Copy link
Member Author

frewsxcv commented Jan 18, 2016

@bors-servo
Copy link
Contributor

bors-servo commented Jan 18, 2016

Previous build results for android, gonk, linux-dev, mac-dev-unit, mac-rel-css, mac-rel-wpt are reusable. Rebuilding only linux-rel...

@bors-servo
Copy link
Contributor

bors-servo commented Jan 18, 2016

@bors-servo bors-servo merged commit f5c6c60 into servo:master Jan 18, 2016
2 checks passed
2 checks passed
continuous-integration/travis-ci/pr The Travis CI build passed
Details
homu Test successful
Details
@frewsxcv frewsxcv deleted the frewsxcv:bump-glutin branch Jan 18, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

7 participants
You can’t perform that action at this time.