Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove multiple unused imports in gfx #9344

Merged
merged 1 commit into from Jan 17, 2016
Merged

Remove multiple unused imports in gfx #9344

merged 1 commit into from Jan 17, 2016

Conversation

@nerith
Copy link
Contributor

nerith commented Jan 16, 2016

Fixes #9342.

Review on Reviewable

@highfive
Copy link

highfive commented Jan 16, 2016

warning Warning warning

  • These commits modify gfx code, but no tests are modified. Please consider adding a test!
@wafflespeanut
Copy link
Member

wafflespeanut commented Jan 16, 2016

@wafflespeanut
Copy link
Member

wafflespeanut commented Jan 16, 2016

@@ -23,7 +23,7 @@ use layers::platform::surface::{NativeDisplay, NativeSurface};
use msg::constellation_msg::{ConstellationChan, Failure, PipelineId};
use paint_context::PaintContext;
use profile_traits::mem::{self, ReportsChan};
use profile_traits::time::{self, profile};
use profile_traits::time::{self};

This comment has been minimized.

@wafflespeanut

wafflespeanut Jan 16, 2016

Member

This should just be use profile_traits::time;

Fixes #9342.
@wafflespeanut
Copy link
Member

wafflespeanut commented Jan 16, 2016

@bors-servo r+

Thanks!

@wafflespeanut
Copy link
Member

wafflespeanut commented Jan 17, 2016

@bors-servo r+

meh?

@wafflespeanut
Copy link
Member

wafflespeanut commented Jan 17, 2016

Oops, buildbot is down, I forgot -_-

@wafflespeanut
Copy link
Member

wafflespeanut commented Jan 17, 2016

@bors-servo
Copy link
Contributor

bors-servo commented Jan 17, 2016

📌 Commit dce7c7b has been approved by Wafflespeanut

@nox
Copy link
Member

nox commented Jan 17, 2016

@bors-servo rollup

@bors-servo
Copy link
Contributor

bors-servo commented Jan 17, 2016

Testing commit dce7c7b with merge 41a3961...

bors-servo added a commit that referenced this pull request Jan 17, 2016
Remove multiple unused imports in gfx

Fixes #9342.

<!-- Reviewable:start -->
[<img src="https://reviewable.io/review_button.png" height=40 alt="Review on Reviewable"/>](https://reviewable.io/reviews/servo/servo/9344)
<!-- Reviewable:end -->
@bors-servo
Copy link
Contributor

bors-servo commented Jan 17, 2016

💔 Test failed - linux-rel

@nox
Copy link
Member

nox commented Jan 17, 2016

@bors-servo
Copy link
Contributor

bors-servo commented Jan 17, 2016

Previous build results for android, gonk, linux-dev, mac-dev-unit, mac-rel-css, mac-rel-wpt are reusable. Rebuilding only linux-rel...

@bors-servo
Copy link
Contributor

bors-servo commented Jan 17, 2016

@bors-servo bors-servo merged commit dce7c7b into servo:master Jan 17, 2016
2 checks passed
2 checks passed
continuous-integration/travis-ci/pr The Travis CI build passed
Details
homu Test successful
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

6 participants
You can’t perform that action at this time.