Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove unused imports in script #9348

Merged
merged 1 commit into from Jan 17, 2016
Merged

Remove unused imports in script #9348

merged 1 commit into from Jan 17, 2016

Conversation

@kishorbhat
Copy link
Contributor

kishorbhat commented Jan 17, 2016

Fixes #9345.

Review on Reviewable

@highfive
Copy link

highfive commented Jan 17, 2016

Thanks for the pull request, and welcome! The Servo team is excited to review your changes, and you should hear from @jdm (or someone else) soon.

@highfive
Copy link

highfive commented Jan 17, 2016

Heads up! This PR modifies the following files:

  • @ecoal95: components/script/dom/webglrenderingcontext.rs
@highfive
Copy link

highfive commented Jan 17, 2016

warning Warning warning

  • These commits modify script code, but no tests are modified. Please consider adding a test!
@wafflespeanut
Copy link
Member

wafflespeanut commented Jan 17, 2016

@bors-servo r+

Thanks!

@bors-servo
Copy link
Contributor

bors-servo commented Jan 17, 2016

📌 Commit 1ca2073 has been approved by Wafflespeanut

@nox
Copy link
Member

nox commented Jan 17, 2016

@bors-servo rollup

@bors-servo
Copy link
Contributor

bors-servo commented Jan 17, 2016

Testing commit 1ca2073 with merge a447e91...

bors-servo added a commit that referenced this pull request Jan 17, 2016
Remove unused imports in script

Fixes #9345.

<!-- Reviewable:start -->
[<img src="https://reviewable.io/review_button.png" height=40 alt="Review on Reviewable"/>](https://reviewable.io/reviews/servo/servo/9348)
<!-- Reviewable:end -->
@bors-servo
Copy link
Contributor

bors-servo commented Jan 17, 2016

💔 Test failed - linux-rel

@KiChjang
Copy link
Member

KiChjang commented Jan 17, 2016

@bors-servo
Copy link
Contributor

bors-servo commented Jan 17, 2016

Testing commit 1ca2073 with merge 42cce1b...

bors-servo added a commit that referenced this pull request Jan 17, 2016
Remove unused imports in script

Fixes #9345.

<!-- Reviewable:start -->
[<img src="https://reviewable.io/review_button.png" height=40 alt="Review on Reviewable"/>](https://reviewable.io/reviews/servo/servo/9348)
<!-- Reviewable:end -->
@bors-servo
Copy link
Contributor

bors-servo commented Jan 17, 2016

💔 Test failed - linux-rel

@emilio
Copy link
Member

emilio commented Jan 17, 2016

@bors-servo
Copy link
Contributor

bors-servo commented Jan 17, 2016

Testing commit 1ca2073 with merge 7f16b4e...

bors-servo added a commit that referenced this pull request Jan 17, 2016
Remove unused imports in script

Fixes #9345.

<!-- Reviewable:start -->
[<img src="https://reviewable.io/review_button.png" height=40 alt="Review on Reviewable"/>](https://reviewable.io/reviews/servo/servo/9348)
<!-- Reviewable:end -->
@bors-servo
Copy link
Contributor

bors-servo commented Jan 17, 2016

@bors-servo bors-servo merged commit 1ca2073 into servo:master Jan 17, 2016
2 checks passed
2 checks passed
continuous-integration/travis-ci/pr The Travis CI build passed
Details
homu Test successful
Details
@kishorbhat kishorbhat deleted the kishorbhat:script-cleanup branch Jan 18, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

7 participants
You can’t perform that action at this time.