Skip to content

/ servo

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update XMLHTTPRequest FetchBodyInit and related Impl (#9291) #9354

Merged
merged 1 commit into from Jan 18, 2016
Merged

Update XMLHTTPRequest FetchBodyInit and related Impl (#9291) #9354

merged 1 commit into from Jan 18, 2016

Conversation

@stspyder
Copy link
Contributor

stspyder commented Jan 17, 2016

Fixes #9291.

Review on Reviewable
@highfive
Copy link

highfive commented Jan 17, 2016

Thanks for the pull request, and welcome! The Servo team is excited to review your changes, and you should hear from @SimonSapin (or someone else) soon.
@highfive
Copy link

highfive commented Jan 17, 2016

warning Warning warning

  • These commits modify script code, but no tests are modified. Please consider adding a test!
@KiChjang
Copy link
Member

KiChjang commented Jan 17, 2016

@bors-servo try

No tests are failing/passing?
@bors-servo
Copy link
Contributor

bors-servo commented Jan 17, 2016

⌛ Trying commit 43ea39b with merge 58cfd6a...
bors-servo added a commit that referenced this pull request Jan 17, 2016
@bors-servo
Auto merge of #9354 - stspyder:master, r=<try>
58cfd6a 
 Update XMLHTTPRequest FetchBodyInit and related Impl (#9291)

<!-- Reviewable:start -->
[<img src="https://reviewable.io/review_button.png" height=40 alt="Review on Reviewable"/>](https://reviewable.io/reviews/servo/servo/9354)
<!-- Reviewable:end -->
@stspyder
Copy link
Contributor Author

stspyder commented Jan 17, 2016

No failing wpt tests.
@bors-servo
Copy link
Contributor

bors-servo commented Jan 17, 2016

💔 Test failed - linux-rel
@KiChjang KiChjang self-assigned this Jan 17, 2016
@KiChjang
Copy link
Member

KiChjang commented Jan 17, 2016

Can you squash the commits together, please?
@stspyder
Copy link
Contributor Author

stspyder commented Jan 17, 2016

Sure will do.
@nox nox added the S-needs-squash label Jan 17, 2016
@stspyder stspyder force-pushed the stspyder:master branch from 43ea39b to 242525e Jan 17, 2016
@Ms2ger
Copy link
Contributor

Ms2ger commented Jan 17, 2016

@KiChjang, can you file an issue about the missing test coverage here?
@stspyder
Update XHR BodyInit, update extract method impl
Loading status checks…
763b992
@stspyder stspyder force-pushed the stspyder:master branch from 242525e to 763b992 Jan 17, 2016
@stspyder
Copy link
Contributor Author

stspyder commented Jan 17, 2016

squashed the commits
@KiChjang
Copy link
Member

KiChjang commented Jan 17, 2016

@Ms2ger Filed #9357.

@bors-servo r+
@bors-servo
Copy link
Contributor

bors-servo commented Jan 17, 2016

📌 Commit 763b992 has been approved by KiChjang
@bors-servo
Copy link
Contributor

bors-servo commented Jan 17, 2016

⌛ Testing commit 763b992 with merge 55d8228...
bors-servo added a commit that referenced this pull request Jan 17, 2016
@bors-servo
Auto merge of #9354 - stspyder:master, r=KiChjang
Loading status checks…
55d8228 
 Update XMLHTTPRequest FetchBodyInit and related Impl (#9291)

Fixes #9291.

<!-- Reviewable:start -->
[<img src="https://reviewable.io/review_button.png" height=40 alt="Review on Reviewable"/>](https://reviewable.io/reviews/servo/servo/9354)
<!-- Reviewable:end -->
@bors-servo
Copy link
Contributor

bors-servo commented Jan 17, 2016

💔 Test failed - linux-rel
@KiChjang
Copy link
Member

KiChjang commented Jan 17, 2016

@bors-servo retry
@bors-servo
Copy link
Contributor

bors-servo commented Jan 17, 2016

⚡ Previous build results for android, gonk, linux-dev, mac-dev-unit, mac-rel-css, mac-rel-wpt are reusable. Rebuilding only linux-rel...
@bors-servo
Copy link
Contributor

bors-servo commented Jan 18, 2016

💔 Test failed - linux-rel
@KiChjang
Copy link
Member

KiChjang commented Jan 18, 2016

@bors-servo retry
@bors-servo
Copy link
Contributor

bors-servo commented Jan 18, 2016

⚡ Previous build results for android, gonk, linux-dev, mac-dev-unit, mac-rel-css, mac-rel-wpt are reusable. Rebuilding only linux-rel...
@bors-servo
Copy link
Contributor

bors-servo commented Jan 18, 2016

☀️ Test successful - android, gonk, linux-dev, linux-rel, mac-dev-unit, mac-rel-css, mac-rel-wpt
@bors-servo bors-servo merged commit 763b992 into servo:master Jan 18, 2016
2 checks passed
2 checks passed
continuous-integration/travis-ci/pr The Travis CI build passed
Details
homu Test successful
Details
@KiChjang KiChjang mentioned this pull request Jan 18, 2016
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@KiChjang KiChjang

Labels
None yet
Projects
None yet
Milestone
No milestone
Linked issues

Successfully merging this pull request may close these issues.

None yet

7 participants
@stspyder @highfive @KiChjang @bors-servo @Ms2ger @nox @SimonSapin
You can’t perform that action at this time.