Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upImplement inline-table #9355
Implement inline-table #9355
Conversation
highfive
commented
Jan 17, 2016
|
|
|
r? @pcwalton |
|
Travis is dissatisfied |
|
I assume you can point to a spec statement for all the code in this PR? |
KiChjang
force-pushed the
KiChjang:display-inline-table
branch
5 times, most recently
from
bee1329
to
a583a65
|
Does this result in any CSS WPT tests being fixed? |
|
I think it should; we'll see. @bors-servo try |
Implement inline-table A lot of what I'm doing here is "monkey-see-monkey-do", so I only have a slight idea of what I'm doing. Mistakes will be made. Don't be gentle on me, and whip me when I do something wrong. Fixes #8003. <!-- Reviewable:start --> [<img src="https://reviewable.io/review_button.png" height=40 alt="Review on Reviewable"/>](https://reviewable.io/reviews/servo/servo/9355) <!-- Reviewable:end -->
|
|
|
Wow, I messed up pretty bad - 102 timed out tests and no passes. |
|
@bors-servo try |
Implement inline-table A lot of what I'm doing here is "monkey-see-monkey-do", so I only have a slight idea of what I'm doing. Mistakes will be made. Don't be gentle on me, and whip me when I do something wrong. Fixes #8003. <!-- Reviewable:start --> [<img src="https://reviewable.io/review_button.png" height=40 alt="Review on Reviewable"/>](https://reviewable.io/reviews/servo/servo/9355) <!-- Reviewable:end -->
|
@bors-servo try |
Implement inline-table A lot of what I'm doing here is "monkey-see-monkey-do", so I only have a slight idea of what I'm doing. Mistakes will be made. Don't be gentle on me, and whip me when I do something wrong. Fixes #8003. <!-- Reviewable:start --> [<img src="https://reviewable.io/review_button.png" height=40 alt="Review on Reviewable"/>](https://reviewable.io/reviews/servo/servo/9355) <!-- Reviewable:end -->
|
|
|
@bors-servo try |
Implement inline-table A lot of what I'm doing here is "monkey-see-monkey-do", so I only have a slight idea of what I'm doing. Mistakes will be made. Don't be gentle on me, and whip me when I do something wrong. Fixes #8003. <!-- Reviewable:start --> [<img src="https://reviewable.io/review_button.png" height=40 alt="Review on Reviewable"/>](https://reviewable.io/reviews/servo/servo/9355) <!-- Reviewable:end -->
|
|
|
|
|
@Ms2ger Here are a couple of scattered pieces of the specs that I've managed to gather: |
|
@bors-servo: r+ |
|
|
Implement inline-table A lot of what I'm doing here is "monkey-see-monkey-do", so I only have a slight idea of what I'm doing. Mistakes will be made. Don't be gentle on me, and whip me when I do something wrong. Fixes #8003. <!-- Reviewable:start --> [<img src="https://reviewable.io/review_button.png" height=40 alt="Review on Reviewable"/>](https://reviewable.io/reviews/servo/servo/9355) <!-- Reviewable:end -->
|
|
|
That's... a lot of test failures. |
|
Huh... I'm not sure what I did that caused so many test failures. @pcwalton do you have any ideas? |
|
Closing since it's not clear that this is making forward progress. |
KiChjang commentedJan 17, 2016
A lot of what I'm doing here is "monkey-see-monkey-do", so I only have a slight idea of what I'm doing. Mistakes will be made. Don't be gentle on me, and whip me when I do something wrong.
Fixes #8003.