Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upClean up websocket closing code #9358
Conversation
|
|
|
This is so much more readable! |
|
@jdm: Will do! |
|
@jdm: I just submitted web-platform-tests/wpt#2498 with this change. |
jsanders
force-pushed the
jsanders:refactor-websocket-closing
branch
from
6b5dbd0
to
482d23b
jdm
added
S-awaiting-review
and removed
S-awaiting-review
S-needs-rebase
S-blocked-on-external
labels
|
@bors-servo: r+ |
|
|
Clean up websocket closing code Fixes #7860. This also changes quite a bit about how close codes are implemented, I believe bringing them closer in line with the spec. Instead of saving off the close code sent by the client, it uses the code from the server's closing handshake. It also handles `NO_STATUS` in what I believe is the correct manner. Making this work required a change to the test harness to make the `/echo` websocket handler echo the code sent by the client and handle `NO_STATUS` properly, rather than always replying with `NORMAL`. <!-- Reviewable:start --> [<img src="https://reviewable.io/review_button.png" height=40 alt="Review on Reviewable"/>](https://reviewable.io/reviews/servo/servo/9358) <!-- Reviewable:end -->
|
|
|
@bors-servo: retry |
|
|
|
@jdm: Should I go ahead and squash this now? |
|
No, I think it's fine the way it is. The merging process is already on its way. |
|
|
|
|
jsanders commentedJan 18, 2016
Fixes #7860.
This also changes quite a bit about how close codes are implemented, I believe bringing them closer in line with the spec. Instead of saving off the close code sent by the client, it uses the code from the server's closing handshake. It also handles
NO_STATUSin what I believe is the correct manner. Making this work required a change to the test harness to make the/echowebsocket handler echo the code sent by the client and handleNO_STATUSproperly, rather than always replying withNORMAL.