Skip to content

/ servo

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow horizontal scrolling with left/right arrow keys. #9359

Merged
merged 1 commit into from Jan 18, 2016
Merged

Allow horizontal scrolling with left/right arrow keys. #9359

merged 1 commit into from Jan 18, 2016

Conversation

@glennw
Copy link
Member

glennw commented Jan 18, 2016

Review on Reviewable
@gw3583
Allow horizontal scrolling with left/right arrow keys.
Loading status checks…
d9c6431
@glennw
Copy link
Member Author

glennw commented Jan 18, 2016

This is needed to debug some of the scrolling issues in browser.html on linux - such as #9306.
@glennw
Copy link
Member Author

glennw commented Jan 18, 2016

r? @mbrubeck (or anyone)
ports/glutin/window.rs
self.scroll_window(LINE_HEIGHT, 0.0);
}
(NONE, Key::Right) => {
self.scroll_window(-LINE_HEIGHT, 0.0);

This comment has been minimized.

Sign in to view
@KiChjang

KiChjang Jan 18, 2016

Member

Should these be 3.0 * LINE_HEIGHT instead (similar to the Up and Down keys above)?

This comment has been minimized.

Sign in to view
@glennw

glennw Jan 18, 2016

Author Member

I think it's preferable for the horizontal scroll to be more fine grained than the vertical scroll, by default.
@KiChjang
Copy link
Member

KiChjang commented Jan 18, 2016

@bors-servo r+
@bors-servo
Copy link
Contributor

bors-servo commented Jan 18, 2016

📌 Commit d9c6431 has been approved by KiChjang
@bors-servo
Copy link
Contributor

bors-servo commented Jan 18, 2016

⌛ Testing commit d9c6431 with merge 2cfed41...
bors-servo added a commit that referenced this pull request Jan 18, 2016
@bors-servo
Auto merge of #9359 - glennw:scroll-horizontal, r=KiChjang
Loading status checks…
2cfed41 
Allow horizontal scrolling with left/right arrow keys.

<!-- Reviewable:start -->
[<img src="https://reviewable.io/review_button.png" height=40 alt="Review on Reviewable"/>](https://reviewable.io/reviews/servo/servo/9359)
<!-- Reviewable:end -->
@bors-servo
Copy link
Contributor

bors-servo commented Jan 18, 2016

☀️ Test successful - android, gonk, linux-dev, linux-rel, mac-dev-unit, mac-rel-css, mac-rel-wpt
@bors-servo bors-servo merged commit d9c6431 into servo:master Jan 18, 2016
2 checks passed
2 checks passed
continuous-integration/travis-ci/pr The Travis CI build passed
Details
homu Test successful
Details
@mdinger mdinger mentioned this pull request Jan 22, 2016
Closed
@glennw glennw deleted the glennw:scroll-horizontal branch Dec 12, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@mbrubeck mbrubeck

Labels
S-awaiting-merge
Projects
None yet
Milestone
No milestone
Linked issues

Successfully merging this pull request may close these issues.

None yet

6 participants
@glennw @KiChjang @bors-servo @mbrubeck @highfive @gw3583
You can’t perform that action at this time.