Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add an `Unserializable` type to utils #9379

Closed
wants to merge 4 commits into from
Closed

Conversation

@emilio
Copy link
Member

emilio commented Jan 19, 2016

This allows unifying the way we prevent the serialisation of things that
can't be sent over IPC for their in-process nature.

This is a proposed solution to things like #9373

Where something like the following can be used:

    Exit(Unserializable<Sender<()>>),

Review on Reviewable

@emilio
Copy link
Member Author

emilio commented Jan 19, 2016

r? @jdm or @Ms2ger

emilio added 2 commits Jan 19, 2016
This allows unifying the way we prevent the serialisation of things that
can't be sent over IPC for their in-process nature.

This is a proposed solution to things like:
#9373

Where something like the following can be used:

```rust
    Exit(Unserializable<Sender<()>>),
```
@emilio emilio force-pushed the emilio:unserializable branch from f668849 to 3c452c3 Jan 19, 2016
@emilio emilio force-pushed the emilio:unserializable branch from 881a74a to 0662100 Jan 19, 2016
@emilio emilio force-pushed the emilio:unserializable branch from 0662100 to 5677d50 Jan 19, 2016
@jdm
Copy link
Member

jdm commented Jan 19, 2016

Thank you for doing this experiment; it's useful to see what it looks like in practice! I think the result doesn't end up being more readable, however, so I'm inclined to put this aside.

@jdm jdm closed this Jan 19, 2016
@emilio
Copy link
Member Author

emilio commented Jan 19, 2016

Yeah, I agree, maybe calling it InProcess or similar could make it
way more readable, but I understand if you don't agree with that :P

I think that at some point more use cases for something like this could
arise, to the point it could be a good option to remove multiple
panicking serialize implementations.

While it isn't the case I'm fine with leaving this closed though.

On Tue, Jan 19, 2016 at 02:00:29PM -0800, Josh Matthews wrote:

Thank you for doing this experiment; it's useful to see what it looks like in practice! I think the result doesn't end up being more readable, however, so I'm inclined to put this aside.


Reply to this email directly or view it on GitHub:
#9379 (comment)

@jdm
Copy link
Member

jdm commented Jan 19, 2016

Yes, if there turn out to be more of them in the future we can resurrect this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants
You can’t perform that action at this time.