Skip to content

/ servo

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update HTMLScriptElement::prepare to match the changed specification. #9393

Merged
merged 1 commit into from Jan 21, 2016
Merged

Update HTMLScriptElement::prepare to match the changed specification. #9393

merged 1 commit into from Jan 21, 2016
+58 −48

Conversation

@Ms2ger
Copy link
Contributor

Ms2ger commented Jan 21, 2016

Review on Reviewable
@Ms2ger
Update HTMLScriptElement::prepare to match the changed specification.
Loading status checks…
678cb9d
@highfive
Copy link

highfive commented Jan 21, 2016

warning Warning warning

  • These commits modify script code, but no tests are modified. Please consider adding a test!
@jdm
Copy link
Member

jdm commented Jan 21, 2016

@bors-servo: r+
@bors-servo
Copy link
Contributor

bors-servo commented Jan 21, 2016

📌 Commit 678cb9d has been approved by jdm
@jdm jdm self-assigned this Jan 21, 2016
@bors-servo
Copy link
Contributor

bors-servo commented Jan 21, 2016

⌛ Testing commit 678cb9d with merge 0ac77f9...
bors-servo added a commit that referenced this pull request Jan 21, 2016
@bors-servo
Auto merge of #9393 - Ms2ger:renumber-prepare, r=jdm
0ac77f9 
Update HTMLScriptElement::prepare to match the changed specification.

<!-- Reviewable:start -->
[<img src="https://reviewable.io/review_button.png" height=40 alt="Review on Reviewable"/>](https://reviewable.io/reviews/servo/servo/9393)
<!-- Reviewable:end -->
@bors-servo
Copy link
Contributor

bors-servo commented Jan 21, 2016

💔 Test failed - linux-rel
@jdm
Copy link
Member

jdm commented Jan 21, 2016

@bors-servo: retry
@bors-servo
Copy link
Contributor

bors-servo commented Jan 21, 2016

⌛ Testing commit 678cb9d with merge 52da517...
bors-servo added a commit that referenced this pull request Jan 21, 2016
@bors-servo
Auto merge of #9393 - Ms2ger:renumber-prepare, r=jdm
Loading status checks…
52da517 
Update HTMLScriptElement::prepare to match the changed specification.

<!-- Reviewable:start -->
[<img src="https://reviewable.io/review_button.png" height=40 alt="Review on Reviewable"/>](https://reviewable.io/reviews/servo/servo/9393)
<!-- Reviewable:end -->
@bors-servo
Copy link
Contributor

bors-servo commented Jan 21, 2016

💔 Test failed - mac-rel-css
@jdm
Copy link
Member

jdm commented Jan 21, 2016

@bors-servo: retry
@bors-servo
Copy link
Contributor

bors-servo commented Jan 21, 2016

⚡ Previous build results for android, gonk, linux-dev, linux-rel, mac-dev-unit, mac-rel-wpt are reusable. Rebuilding only mac-rel-css...
@bors-servo
Copy link
Contributor

bors-servo commented Jan 21, 2016

☀️ Test successful - android, gonk, linux-dev, linux-rel, mac-dev-unit, mac-rel-css, mac-rel-wpt
@bors-servo bors-servo mentioned this pull request Jan 21, 2016
Merged
@bors-servo bors-servo merged commit 678cb9d into servo:master Jan 21, 2016
2 checks passed
2 checks passed
continuous-integration/travis-ci/pr The Travis CI build passed
Details
homu Test successful
Details
@Ms2ger Ms2ger deleted the Ms2ger:renumber-prepare branch Feb 23, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@jdm jdm

Labels
None yet
Projects
None yet
Milestone
No milestone
Linked issues

Successfully merging this pull request may close these issues.

None yet

5 participants
@Ms2ger @highfive @jdm @bors-servo @SimonSapin
You can’t perform that action at this time.