Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upCheck if root page exist before handling DOM events #9418
Merged
Conversation
highfive
commented
Jan 25, 2016
|
|
|
I don't think there's a way to test it automatically without webdriver support which doesn't exist yet. |
|
@bors-servo: r+ |
|
|
bors-servo
added a commit
that referenced
this pull request
Jan 25, 2016
Check if root page exist before handling DOM events Fix #9417 For the test, I'm not sure how to simulate a mouse event or a key event in a way that it would be forwarded to the iframe. Any idea? <!-- Reviewable:start --> [<img src="https://reviewable.io/review_button.png" height=40 alt="Review on Reviewable"/>](https://reviewable.io/reviews/servo/servo/9418) <!-- Reviewable:end -->
|
|
|
@bors-servo: retry |
|
|
|
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
paulrouget commentedJan 25, 2016
Fix #9417
For the test, I'm not sure how to simulate a mouse event or a key event in a way that it would be forwarded to the iframe.
Any idea?