Skip to content

/ servo

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Expand the block size of the root flow's margin box to the viewport size instead of expanding the block size of its border box. #9438

Merged
merged 1 commit into from Jan 29, 2016
Merged

Expand the block size of the root flow's margin box to the viewport size instead of expanding the block size of its border box. #9438

merged 1 commit into from Jan 29, 2016

Conversation

@pcwalton
Copy link
Contributor

pcwalton commented Jan 27, 2016

Closes #9308.

r? @mbrubeck

Review on Reviewable
@mbrubeck mbrubeck self-assigned this Jan 27, 2016
@jdm
Copy link
Member

jdm commented Jan 27, 2016

@pcwalton Looks like you didn't create the new test using ./mach create-wpt, so the manifest changes aren't correct.
@jdm
Copy link
Member

jdm commented Jan 27, 2016

Also the reftest file is missing the HTML element that links to the reference file (which create-wpt adds by default in the template).
@pcwalton pcwalton force-pushed the pcwalton:root-margins branch from 0d2428c to ce1dd57 Jan 27, 2016
@pcwalton
Copy link
Contributor Author

pcwalton commented Jan 27, 2016

OK, updated the test. r? @mbrubeck
tests/wpt/mozilla/meta/MANIFEST.json
@@ -4032,6 +4032,18 @@
"url": "/_mozilla/css/root_margin_collapse_a.html"
}
],
"css/root_margins_a.html": [

This comment has been minimized.

Sign in to view
Copy link
@jdm

jdm Jan 27, 2016

Member

This file needs a copy of this information down around line 10127.
@mbrubeck
Copy link
Contributor

mbrubeck commented Jan 27, 2016

r=mbrubeck for the layout code.

-S-awaiting-review

Reviewed 3 of 4 files at r1.
Review status: 3 of 4 files reviewed at latest revision, 1 unresolved discussion, some commit checks failed.

Comments from the review on Reviewable.io
@pcwalton pcwalton force-pushed the pcwalton:root-margins branch from ce1dd57 to 2332fd5 Jan 27, 2016
@pcwalton
Copy link
Contributor Author

pcwalton commented Jan 27, 2016

OK, I updated the WPT manifest and verified that the test works.

r? @jdm
@highfive highfive assigned jdm and unassigned mbrubeck Jan 27, 2016
@jdm
Copy link
Member

jdm commented Jan 27, 2016

@bors-servo: r=mbrubeck
@bors-servo
Copy link
Contributor

bors-servo commented Jan 27, 2016

📌 Commit 2332fd5 has been approved by mbrubeck
@bors-servo
Copy link
Contributor

bors-servo commented Jan 27, 2016

⌛ Testing commit 2332fd5 with merge fe4e7f5...
bors-servo added a commit that referenced this pull request Jan 27, 2016
@bors-servo
Auto merge of #9438 - pcwalton:root-margins, r=mbrubeck
fe4e7f5 
Expand the block size of the root flow's margin box to the viewport size instead of expanding the block size of its border box.

Closes #9308.

r? @mbrubeck

<!-- Reviewable:start -->
[<img src="https://reviewable.io/review_button.svg" height="40" alt="Review on Reviewable"/>](https://reviewable.io/reviews/servo/servo/9438)
<!-- Reviewable:end -->
@bors-servo
Copy link
Contributor

bors-servo commented Jan 27, 2016

💔 Test failed - linux-rel
@frewsxcv
Copy link
Member

frewsxcv commented Jan 28, 2016

@bors-servo retry #8815
@bors-servo
Copy link
Contributor

bors-servo commented Jan 28, 2016

⌛ Testing commit 2332fd5 with merge 35efe7b...
bors-servo added a commit that referenced this pull request Jan 28, 2016
@bors-servo
Auto merge of #9438 - pcwalton:root-margins, r=mbrubeck
35efe7b 
Expand the block size of the root flow's margin box to the viewport size instead of expanding the block size of its border box.

Closes #9308.

r? @mbrubeck

<!-- Reviewable:start -->
[<img src="https://reviewable.io/review_button.svg" height="40" alt="Review on Reviewable"/>](https://reviewable.io/reviews/servo/servo/9438)
<!-- Reviewable:end -->
@pcwalton
Expand the block size of the root flow's margin box to the viewport size
Loading status checks…
777c46f 
instead of expanding the block size of its border box.

Closes #9308.
@bors-servo
Copy link
Contributor

bors-servo commented Jan 28, 2016

⌛ Testing commit 777c46f with merge ae6b503...
bors-servo added a commit that referenced this pull request Jan 28, 2016
@bors-servo
Auto merge of #9438 - pcwalton:root-margins, r=mbrubeck
ae6b503 
Expand the block size of the root flow's margin box to the viewport size instead of expanding the block size of its border box.

Closes #9308.

r? @mbrubeck

<!-- Reviewable:start -->
[<img src="https://reviewable.io/review_button.svg" height="40" alt="Review on Reviewable"/>](https://reviewable.io/reviews/servo/servo/9438)
<!-- Reviewable:end -->
@bors-servo
Copy link
Contributor

bors-servo commented Jan 28, 2016

💔 Test failed - mac-rel-css
@KiChjang
Copy link
Member

KiChjang commented Jan 28, 2016

@bors-servo retry
@bors-servo
Copy link
Contributor

bors-servo commented Jan 28, 2016

⌛ Testing commit 777c46f with merge 430123f...
bors-servo added a commit that referenced this pull request Jan 28, 2016
@bors-servo
Auto merge of #9438 - pcwalton:root-margins, r=mbrubeck
430123f 
Expand the block size of the root flow's margin box to the viewport size instead of expanding the block size of its border box.

Closes #9308.

r? @mbrubeck

<!-- Reviewable:start -->
[<img src="https://reviewable.io/review_button.svg" height="40" alt="Review on Reviewable"/>](https://reviewable.io/reviews/servo/servo/9438)
<!-- Reviewable:end -->
@bors-servo
Copy link
Contributor

bors-servo commented Jan 28, 2016

💔 Test failed - mac-rel-wpt
@pcwalton
Copy link
Contributor Author

pcwalton commented Jan 29, 2016

Huh? About half of the Mozilla CSS tests failed. I don't think that happened locally...
@frewsxcv
Copy link
Member

frewsxcv commented Jan 29, 2016

@bors-servo retry
@bors-servo
Copy link
Contributor

bors-servo commented Jan 29, 2016

⌛ Testing commit 777c46f with merge c8dfe16...
bors-servo added a commit that referenced this pull request Jan 29, 2016
@bors-servo
Auto merge of #9438 - pcwalton:root-margins, r=mbrubeck
c8dfe16 
Expand the block size of the root flow's margin box to the viewport size instead of expanding the block size of its border box.

Closes #9308.

r? @mbrubeck

<!-- Reviewable:start -->
[<img src="https://reviewable.io/review_button.svg" height="40" alt="Review on Reviewable"/>](https://reviewable.io/reviews/servo/servo/9438)
<!-- Reviewable:end -->
@bors-servo
Copy link
Contributor

bors-servo commented Jan 29, 2016

💔 Test failed - mac-rel-css
@frewsxcv
Copy link
Member

frewsxcv commented Jan 29, 2016

@bors-servo retry #9163
@bors-servo
Copy link
Contributor

bors-servo commented Jan 29, 2016

⌛ Testing commit 777c46f with merge d1ff330...
bors-servo added a commit that referenced this pull request Jan 29, 2016
@bors-servo
Auto merge of #9438 - pcwalton:root-margins, r=mbrubeck
Loading status checks…
d1ff330 
Expand the block size of the root flow's margin box to the viewport size instead of expanding the block size of its border box.

Closes #9308.

r? @mbrubeck

<!-- Reviewable:start -->
[<img src="https://reviewable.io/review_button.svg" height="40" alt="Review on Reviewable"/>](https://reviewable.io/reviews/servo/servo/9438)
<!-- Reviewable:end -->
@bors-servo
Copy link
Contributor

bors-servo commented Jan 29, 2016

☀️ Test successful - android, gonk, linux-dev, linux-rel, mac-dev-unit, mac-rel-css, mac-rel-wpt
@bors-servo bors-servo merged commit 777c46f into servo:master Jan 29, 2016
2 checks passed
2 checks passed
continuous-integration/travis-ci/pr The Travis CI build passed
Details
homu Test successful
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@jdm jdm

Labels
S-awaiting-merge
Projects
None yet
Milestone
No milestone
Linked issues

Successfully merging this pull request may close these issues.

None yet

7 participants
@pcwalton @jdm @mbrubeck @bors-servo @frewsxcv @KiChjang @highfive
You can’t perform that action at this time.