Skip to content

/ servo

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "Remove gold hack, since it's in rustc automatically now" #9449

Merged
merged 1 commit into from Feb 1, 2016
Merged

Revert "Remove gold hack, since it's in rustc automatically now" #9449

merged 1 commit into from Feb 1, 2016
+8 −0

Conversation

@larsbergstrom
Copy link
Contributor

larsbergstrom commented Jan 28, 2016

This reverts commit 2955d89.

r? @mbrubeck

Review on Reviewable
@larsbergstrom
Revert "Remove gold hack, since it's in rustc automatically now"
Loading status checks…
864fe53 
This reverts commit 2955d89.
@mbrubeck
Copy link
Contributor

mbrubeck commented Jan 28, 2016

@bors-servo r+
@bors-servo
Copy link
Contributor

bors-servo commented Jan 28, 2016

📌 Commit 864fe53 has been approved by mbrubeck
@bors-servo
Copy link
Contributor

bors-servo commented Jan 29, 2016

⌛ Testing commit 864fe53 with merge dd5c4c9...
bors-servo added a commit that referenced this pull request Jan 29, 2016
@bors-servo
Auto merge of #9449 - larsbergstrom:revert_gold_removal, r=mbrubeck
dd5c4c9 
Revert "Remove gold hack, since it's in rustc automatically now"

This reverts commit 2955d89.

r? @mbrubeck

<!-- Reviewable:start -->
[<img src="https://reviewable.io/review_button.svg" height="40" alt="Review on Reviewable"/>](https://reviewable.io/reviews/servo/servo/9449)
<!-- Reviewable:end -->
@bors-servo
Copy link
Contributor

bors-servo commented Jan 29, 2016

💔 Test failed - mac-rel-css
@notriddle
Copy link
Contributor

notriddle commented Jan 31, 2016

This is probably doing to sound dumb, but why is this being reverted?
@KiChjang
Copy link
Member

KiChjang commented Jan 31, 2016

@bors-servo retry

@notriddle See the conversation here. @mbrubeck indicated that we're still on an earlier version of Rust, so the rustc we currently have doesn't have the ability to automatically choose between gold and non-gold builds.
@bors-servo
Copy link
Contributor

bors-servo commented Jan 31, 2016

⌛ Testing commit 864fe53 with merge 84a263a...
bors-servo added a commit that referenced this pull request Jan 31, 2016
@bors-servo
Auto merge of #9449 - larsbergstrom:revert_gold_removal, r=mbrubeck
84a263a 
Revert "Remove gold hack, since it's in rustc automatically now"

This reverts commit 2955d89.

r? @mbrubeck

<!-- Reviewable:start -->
[<img src="https://reviewable.io/review_button.svg" height="40" alt="Review on Reviewable"/>](https://reviewable.io/reviews/servo/servo/9449)
<!-- Reviewable:end -->
@bors-servo
Copy link
Contributor

bors-servo commented Jan 31, 2016

💔 Test failed - mac-rel-wpt
@KiChjang
Copy link
Member

KiChjang commented Feb 1, 2016

@bors-servo retry
@bors-servo
Copy link
Contributor

bors-servo commented Feb 1, 2016

⌛ Testing commit 864fe53 with merge c379b0b...
bors-servo added a commit that referenced this pull request Feb 1, 2016
@bors-servo
Auto merge of #9449 - larsbergstrom:revert_gold_removal, r=mbrubeck
c379b0b 
Revert "Remove gold hack, since it's in rustc automatically now"

This reverts commit 2955d89.

r? @mbrubeck

<!-- Reviewable:start -->
[<img src="https://reviewable.io/review_button.svg" height="40" alt="Review on Reviewable"/>](https://reviewable.io/reviews/servo/servo/9449)
<!-- Reviewable:end -->
@bors-servo
Copy link
Contributor

bors-servo commented Feb 1, 2016

💔 Test failed - linux-rel
@KiChjang
Copy link
Member

KiChjang commented Feb 1, 2016

@bors-servo retry
@bors-servo
Copy link
Contributor

bors-servo commented Feb 1, 2016

⚡ Previous build results for android, gonk, mac-dev-unit, mac-rel-css, mac-rel-wpt are reusable. Rebuilding only linux-dev, linux-rel...
@bors-servo
Copy link
Contributor

bors-servo commented Feb 1, 2016

💔 Test failed - linux-rel
@KiChjang
Copy link
Member

KiChjang commented Feb 1, 2016

@bors-servo retry
@bors-servo
Copy link
Contributor

bors-servo commented Feb 1, 2016

⌛ Testing commit 864fe53 with merge 220ead1...
bors-servo added a commit that referenced this pull request Feb 1, 2016
@bors-servo
Auto merge of #9449 - larsbergstrom:revert_gold_removal, r=mbrubeck
Loading status checks…
220ead1 
Revert "Remove gold hack, since it's in rustc automatically now"

This reverts commit 2955d89.

r? @mbrubeck

<!-- Reviewable:start -->
[<img src="https://reviewable.io/review_button.svg" height="40" alt="Review on Reviewable"/>](https://reviewable.io/reviews/servo/servo/9449)
<!-- Reviewable:end -->
@bors-servo
Copy link
Contributor

bors-servo commented Feb 1, 2016

💔 Test failed - linux-rel
@jdm
Copy link
Member

jdm commented Feb 1, 2016

@bors-servo: retry
@larsbergstrom
Copy link
Contributor Author

larsbergstrom commented Feb 1, 2016

@notriddle We have to revert the removal of the gold linker support because Rust reverted their detection/use of the gold linker.

Or in less obtuse language (too many negatives & removals!), we need to add back the code to detect when we can use the gold linker, since it no longer exists in Rust.
@bors-servo
Copy link
Contributor

bors-servo commented Feb 1, 2016

⚡ Previous build results for android, gonk, mac-dev-unit are reusable. Rebuilding only linux-dev, linux-rel, mac-rel-css, mac-rel-wpt...
@notriddle
Copy link
Contributor

notriddle commented Feb 1, 2016

Yeah, I get it.

On Mon, Feb 1, 2016, 07:17 bors-servo notifications@github.com wrote:

[image: ⚡] Previous build results for android
http://build.servo.org/builders/android/builds/1487, gonk
http://build.servo.org/builders/gonk/builds/1518, mac-dev-unit
http://build.servo.org/builders/mac-dev-unit/builds/185 are reusable.
Rebuilding only linux-dev
http://build.servo.org/builders/linux-dev/builds/1496, linux-rel
http://build.servo.org/builders/linux-rel/builds/1693, mac-rel-css
http://build.servo.org/builders/mac-rel-css/builds/1530, mac-rel-wpt
http://build.servo.org/builders/mac-rel-wpt/builds/1562...

—
Reply to this email directly or view it on GitHub
#9449 (comment).
@bors-servo
Copy link
Contributor

bors-servo commented Feb 1, 2016

☀️ Test successful - android, gonk, linux-dev, linux-rel, mac-dev-unit, mac-rel-css, mac-rel-wpt
@bors-servo bors-servo merged commit 864fe53 into servo:master Feb 1, 2016
2 checks passed
2 checks passed
continuous-integration/travis-ci/pr The Travis CI build passed
Details
homu Test successful
Details
@UK992 UK992 mentioned this pull request Feb 2, 2016
Closed
@larsbergstrom larsbergstrom deleted the larsbergstrom:revert_gold_removal branch Sep 29, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@mbrubeck mbrubeck

Labels
S-tests-failed
Projects
None yet
Milestone
No milestone
Linked issues

Successfully merging this pull request may close these issues.

None yet

7 participants
@larsbergstrom @mbrubeck @bors-servo @notriddle @KiChjang @jdm @highfive
You can’t perform that action at this time.