Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump rust-selectors #9453

Closed
wants to merge 1 commit into from
Closed

Bump rust-selectors #9453

wants to merge 1 commit into from

Conversation

@emilio
Copy link
Member

emilio commented Jan 28, 2016

Depends on servo/rust-selectors#65.

I kept the commits splitted in order to simplify reviewing them, but they should arguably be squashed (the intermediate ones are broken builds).

Review on Reviewable

@highfive
Copy link

highfive commented Jan 28, 2016

Heads up! This PR modifies the following files:

  • @bholley: components/style/selector_matching.rs, components/style/matching.rs, components/style/lib.rs, components/style/restyle_hints.rs, components/style/element_state.rs, components/style/dom.rs, components/style/stylesheets.rs, components/style/selector_impl.rs
@highfive
Copy link

highfive commented Jan 28, 2016

warning Warning warning

  • These commits modify unsafe code. Please review it carefully!
  • These commits modify style, layout, and script code, but no tests are modified. Please consider adding a test!
@emilio
Copy link
Member Author

emilio commented Jan 28, 2016

@SimonSapin
Copy link
Member

SimonSapin commented Jan 28, 2016

Please squash so that each commit compiles. (In this case this maybe everything in one commit.) r=me with that


Reviewed 1 of 1 files at r1, 5 of 5 files at r2, 6 of 6 files at r3, 15 of 15 files at r4, 3 of 3 files at r5.
Review status: all files reviewed at latest revision, all discussions resolved, some commit checks failed.


Comments from the review on Reviewable.io

@SimonSapin
Copy link
Member

SimonSapin commented Jan 28, 2016

Also ./mach test-tidy reports some errors: https://travis-ci.org/servo/servo/jobs/105528079

@jdm jdm added the S-fails-tidy label Jan 29, 2016
This commits updates rust-selectors to use the generic parser, and as
such it moves the element state into the style crate.
@emilio emilio force-pushed the emilio:selectors-up-take-2 branch from 0803e9a to da952ea Jan 29, 2016
@emilio
Copy link
Member Author

emilio commented Jan 29, 2016

Hrrmm...

Happened to me locally right now, but I thought it was just some corruption of the cargo directory or similar:

unable to get packages from source
Caused by:
  Failed to unpack package `selectors v0.4.0`
Caused by:
  No such file or directory (os error 2)
@emilio
Copy link
Member Author

emilio commented Jan 29, 2016

For the record:

This is failing because of rust-lang/cargo#2326, so we're either blocked by the cargoup or by another rust-selector's release.

@nox
Copy link
Member

nox commented Feb 2, 2016

Superseded by #9510.

@nox nox closed this Feb 2, 2016
@nox nox mentioned this pull request Feb 2, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

5 participants
You can’t perform that action at this time.