Skip to content

/ servo

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add mach test-webidl command #9459

Merged
merged 2 commits into from Jan 30, 2016
Merged

Add mach test-webidl command #9459

merged 2 commits into from Jan 30, 2016

Conversation

@shinglyu
Copy link
Member

shinglyu commented Jan 29, 2016

I updated the WebIDL.py from latest mozilla-central. And add a ./mach test-webidl command. For #9397

Review on Reviewable
@shinglyu
Add mach test-webidl command
Loading status checks…
18b6817
@highfive
Copy link

highfive commented Jan 29, 2016

warning Warning warning

  • These commits modify script code, but no tests are modified. Please consider adding a test!
@nxnfufunezn
Copy link
Contributor

nxnfufunezn commented Jan 29, 2016

python/servo/testing_commands.py, line 245 [r1] (raw file):
reduce this line to 120 chars add \ after "script", move rest to newline

Comments from the review on Reviewable.io
@nxnfufunezn
Copy link
Contributor

nxnfufunezn commented Jan 29, 2016

python/servo/testing_commands.py, line 246 [r1] (raw file):
move the comment above this line...

Comments from the review on Reviewable.io
@nxnfufunezn
Copy link
Contributor

nxnfufunezn commented Jan 29, 2016

You can run tidy checks by running this command ./mach test-tidy 😄
@jdm jdm added the S-fails-tidy label Jan 29, 2016
@shinglyu
Fixed nits
Loading status checks…
83a492a
@wafflespeanut
Copy link
Member

wafflespeanut commented Jan 30, 2016

The changes look good :)

@nox do we have to update update.sh here, or could that be an E-easy follow-up?
@wafflespeanut
Copy link
Member

wafflespeanut commented Jan 30, 2016

-S-awaiting-review

Reviewed 4 of 6 files at r1, 1 of 1 files at r2.
Review status: 5 of 6 files reviewed at latest revision, 2 unresolved discussions.

Comments from the review on Reviewable.io
@nox
Copy link
Member

nox commented Jan 30, 2016

It can probably be an E-Easy thing.
@wafflespeanut
Copy link
Member

wafflespeanut commented Jan 30, 2016

@bors-servo r+

Thanks!
@bors-servo
Copy link
Contributor

bors-servo commented Jan 30, 2016

📌 Commit 83a492a has been approved by Wafflespeanut
@bors-servo
Copy link
Contributor

bors-servo commented Jan 30, 2016

⌛ Testing commit 83a492a with merge 5ad96cf...
bors-servo added a commit that referenced this pull request Jan 30, 2016
@bors-servo
Auto merge of #9459 - shinglyu:testwebidl, r=Wafflespeanut
5ad96cf 
Add mach test-webidl command

I updated the `WebIDL.py` from latest mozilla-central. And add a `./mach test-webidl` command. For #9397

<!-- Reviewable:start -->
[<img src="https://reviewable.io/review_button.svg" height="40" alt="Review on Reviewable"/>](https://reviewable.io/reviews/servo/servo/9459)
<!-- Reviewable:end -->
@wafflespeanut wafflespeanut self-assigned this Jan 30, 2016
@bors-servo
Copy link
Contributor

bors-servo commented Jan 30, 2016

💔 Test failed - linux-rel
@wafflespeanut
Copy link
Member

wafflespeanut commented Jan 30, 2016

@bors-servo retry
@bors-servo
Copy link
Contributor

bors-servo commented Jan 30, 2016

⌛ Testing commit 83a492a with merge c49b2d2...
bors-servo added a commit that referenced this pull request Jan 30, 2016
@bors-servo
Auto merge of #9459 - shinglyu:testwebidl, r=Wafflespeanut
c49b2d2 
Add mach test-webidl command

I updated the `WebIDL.py` from latest mozilla-central. And add a `./mach test-webidl` command. For #9397

<!-- Reviewable:start -->
[<img src="https://reviewable.io/review_button.svg" height="40" alt="Review on Reviewable"/>](https://reviewable.io/reviews/servo/servo/9459)
<!-- Reviewable:end -->
@bors-servo
Copy link
Contributor

bors-servo commented Jan 30, 2016

💔 Test failed - linux-rel
@nox
Copy link
Member

nox commented Jan 30, 2016

@bors-servo retry #9467
@wafflespeanut
Copy link
Member

wafflespeanut commented Jan 30, 2016

@bors-servo retry
@bors-servo
Copy link
Contributor

bors-servo commented Jan 30, 2016

⌛ Testing commit 83a492a with merge 0ada7f9...
bors-servo added a commit that referenced this pull request Jan 30, 2016
@bors-servo
Auto merge of #9459 - shinglyu:testwebidl, r=Wafflespeanut
Loading status checks…
0ada7f9 
Add mach test-webidl command

I updated the `WebIDL.py` from latest mozilla-central. And add a `./mach test-webidl` command. For #9397

<!-- Reviewable:start -->
[<img src="https://reviewable.io/review_button.svg" height="40" alt="Review on Reviewable"/>](https://reviewable.io/reviews/servo/servo/9459)
<!-- Reviewable:end -->
@bors-servo
Copy link
Contributor

bors-servo commented Jan 30, 2016

💔 Test failed - mac-rel-wpt
@wafflespeanut
Copy link
Member

wafflespeanut commented Jan 30, 2016

@bors-servo retry

#8191
@bors-servo
Copy link
Contributor

bors-servo commented Jan 30, 2016

⚡ Previous build results for android, gonk, linux-dev, linux-rel, mac-dev-unit, mac-rel-css are reusable. Rebuilding only mac-rel-wpt...
@bors-servo
Copy link
Contributor

bors-servo commented Jan 30, 2016

☀️ Test successful - android, gonk, linux-dev, linux-rel, mac-dev-unit, mac-rel-css, mac-rel-wpt
@bors-servo bors-servo merged commit 83a492a into servo:master Jan 30, 2016
2 checks passed
2 checks passed
continuous-integration/travis-ci/pr The Travis CI build passed
Details
homu Test successful
Details
@wafflespeanut wafflespeanut mentioned this pull request Feb 14, 2016
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@wafflespeanut wafflespeanut

Labels
S-tests-failed
Projects
None yet
Milestone
No milestone
Linked issues

Successfully merging this pull request may close these issues.

None yet

7 participants
@shinglyu @highfive @nxnfufunezn @wafflespeanut @nox @bors-servo @jdm
You can’t perform that action at this time.