Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upIntegrate compiletest_rs #9469
Merged
Integrate compiletest_rs #9469
Conversation
highfive
commented
Jan 30, 2016
|
Thanks for the pull request, and welcome! The Servo team is excited to review your changes, and you should hear from @larsbergstrom (or someone else) soon. |
highfive
commented
Jan 30, 2016
|
|
|
Let's add |
|
Done. |
|
r? @jdm |
python/servo/testing_commands.py
Outdated
| ])) | ||
| assert len(properties) >= 100 | ||
| assert "margin-top" in properties | ||
| assert "margin" in properties |
This comment has been minimized.
This comment has been minimized.
python/servo/testing_commands.py
Outdated
|
|
||
| test_patterns = [] | ||
| for test in test_name: | ||
| # add package if 'tests/unit/<package>' |
This comment has been minimized.
This comment has been minimized.
python/servo/testing_commands.py
Outdated
| match = re.search("tests/compiletest/(\\w+)/?$", test) | ||
| if match: | ||
| packages.add(match.group(1)) | ||
| # add package & test if '<package>/<test>', 'tests/unit/<package>/<test>.rs', or similar |
This comment has been minimized.
This comment has been minimized.
|
This is really great work! If you fix the small nits I mentioned, this is ready to merge! Thanks! |
|
Thanks for the feedback! I've pushed a commit which should address it. |
|
Looks good! Please squash them and we'll merge your changes. |
|
@bors-servo r=jdm |
|
|
bors-servo
added a commit
that referenced
this pull request
Feb 4, 2016
Integrate compiletest_rs This PR integrates `compiletest_rs` as suggested in #5646. I created a new `tests/compiletest` directory which contains separate crates for the tests. Currently this PR includes `compile-fail` tests for some lints (acutally all except inheritance_integrity, beacuse I'm not sure how to include the dom stuff in a way the `#[dom_struct]` works). I gathered that there should be more crates for which compiletests make sense and would appreciate any pointers to relevant crates. <!-- Reviewable:start --> [<img src="https://reviewable.io/review_button.svg" height="40" alt="Review on Reviewable"/>](https://reviewable.io/reviews/servo/servo/9469) <!-- Reviewable:end -->
|
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
fhahn commentedJan 30, 2016
This PR integrates
compiletest_rsas suggested in #5646. I created a newtests/compiletestdirectory which contains separate crates for the tests.Currently this PR includes
compile-failtests for some lints (acutally all except inheritance_integrity, beacuse I'm not sure how to include the dom stuff in a way the#[dom_struct]works).I gathered that there should be more crates for which compiletests make sense and would appreciate any pointers to relevant crates.