Skip to content

/ servo

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix #8461 #9471

Merged
merged 1 commit into from Feb 5, 2016
Merged

fix #8461 #9471

merged 1 commit into from Feb 5, 2016

Conversation

@peterkort
Copy link
Contributor

peterkort commented Jan 31, 2016

Review on Reviewable
@peterkort
resume fn should set suspended_since back to None
Loading status checks…
9181a52
@highfive
Copy link

highfive commented Jan 31, 2016

Thanks for the pull request, and welcome! The Servo team is excited to review your changes, and you should hear from @Ms2ger (or someone else) soon.
@highfive
Copy link

highfive commented Jan 31, 2016

warning Warning warning

  • These commits modify script code, but no tests are modified. Please consider adding a test!
@jdm jdm self-assigned this Jan 31, 2016
@jdm
Copy link
Member

jdm commented Jan 31, 2016

@bors-servo: r+
Good catch! Thanks!
@bors-servo
Copy link
Contributor

bors-servo commented Jan 31, 2016

📌 Commit 9181a52 has been approved by jdm
@bors-servo
Copy link
Contributor

bors-servo commented Jan 31, 2016

⌛ Testing commit 9181a52 with merge 3fd0e03...
bors-servo added a commit that referenced this pull request Jan 31, 2016
@bors-servo
Auto merge of #9471 - peterkort:patch-1, r=jdm
3fd0e03 
fix #8461

<!-- Reviewable:start -->
[<img src="https://reviewable.io/review_button.svg" height="40" alt="Review on Reviewable"/>](https://reviewable.io/reviews/servo/servo/9471)
<!-- Reviewable:end -->
@bors-servo
Copy link
Contributor

bors-servo commented Jan 31, 2016

💔 Test failed - mac-rel-css
@jdm
Copy link
Member

jdm commented Jan 31, 2016

@bors-servo: retry
@bors-servo
Copy link
Contributor

bors-servo commented Jan 31, 2016

⚡ Previous build results for android, gonk, linux-dev, linux-rel, mac-dev-unit, mac-rel-wpt are reusable. Rebuilding only mac-rel-css...
@bors-servo
Copy link
Contributor

bors-servo commented Jan 31, 2016

💔 Test failed - mac-rel-css
@KiChjang
Copy link
Member

KiChjang commented Jan 31, 2016

@bors-servo retry
@bors-servo
Copy link
Contributor

bors-servo commented Jan 31, 2016

⚡ Previous build results for android, gonk, linux-dev, linux-rel, mac-dev-unit, mac-rel-wpt are reusable. Rebuilding only mac-rel-css...
@bors-servo
Copy link
Contributor

bors-servo commented Jan 31, 2016

💔 Test failed - mac-rel-css
@nox
Copy link
Member

nox commented Feb 1, 2016

@bors-servo retry #7910
@bors-servo
Copy link
Contributor

bors-servo commented Feb 1, 2016

⌛ Testing commit 9181a52 with merge 45e5cc4...
bors-servo added a commit that referenced this pull request Feb 1, 2016
@bors-servo
Auto merge of #9471 - peterkort:patch-1, r=jdm
45e5cc4 
fix #8461

<!-- Reviewable:start -->
[<img src="https://reviewable.io/review_button.svg" height="40" alt="Review on Reviewable"/>](https://reviewable.io/reviews/servo/servo/9471)
<!-- Reviewable:end -->
@bors-servo
Copy link
Contributor

bors-servo commented Feb 1, 2016

💔 Test failed - linux-rel
bors-servo added a commit that referenced this pull request Feb 2, 2016
@bors-servo
Auto merge of #9471 - peterkort:patch-1, r=jdm
baf19f8 
fix #8461

<!-- Reviewable:start -->
[<img src="https://reviewable.io/review_button.svg" height="40" alt="Review on Reviewable"/>](https://reviewable.io/reviews/servo/servo/9471)
<!-- Reviewable:end -->
@bors-servo
Copy link
Contributor

bors-servo commented Feb 2, 2016

💔 Test failed - mac-rel-wpt
@larsbergstrom
Copy link
Contributor

larsbergstrom commented Feb 2, 2016

@bors-servo retry
@nox nox added S-awaiting-merge and removed S-tests-failed labels Feb 2, 2016
@nox
Copy link
Member

nox commented Feb 4, 2016

@bors-servo p=0
@bors-servo
Copy link
Contributor

bors-servo commented Feb 5, 2016

⌛ Testing commit 9181a52 with merge 8a672a4...
bors-servo added a commit that referenced this pull request Feb 5, 2016
@bors-servo
Auto merge of #9471 - peterkort:patch-1, r=jdm
8a672a4 
fix #8461

<!-- Reviewable:start -->
[<img src="https://reviewable.io/review_button.svg" height="40" alt="Review on Reviewable"/>](https://reviewable.io/reviews/servo/servo/9471)
<!-- Reviewable:end -->
@bors-servo
Copy link
Contributor

bors-servo commented Feb 5, 2016

💔 Test failed - mac-rel-wpt
@KiChjang
Copy link
Member

KiChjang commented Feb 5, 2016

@bors-servo retry
@bors-servo
Copy link
Contributor

bors-servo commented Feb 5, 2016

⌛ Testing commit 9181a52 with merge c0f8639...
bors-servo added a commit that referenced this pull request Feb 5, 2016
@bors-servo
Auto merge of #9471 - peterkort:patch-1, r=jdm
c0f8639 
fix #8461

<!-- Reviewable:start -->
[<img src="https://reviewable.io/review_button.svg" height="40" alt="Review on Reviewable"/>](https://reviewable.io/reviews/servo/servo/9471)
<!-- Reviewable:end -->
@bors-servo
Copy link
Contributor

bors-servo commented Feb 5, 2016

💔 Test failed - mac-dev-unit
@larsbergstrom
Copy link
Contributor

larsbergstrom commented Feb 5, 2016

@bors-servo retry

(out of disk space on build master)
@bors-servo
Copy link
Contributor

bors-servo commented Feb 5, 2016

⌛ Testing commit 9181a52 with merge 5505bf1...
bors-servo added a commit that referenced this pull request Feb 5, 2016
@bors-servo
Auto merge of #9471 - peterkort:patch-1, r=jdm
Loading status checks…
5505bf1 
fix #8461

<!-- Reviewable:start -->
[<img src="https://reviewable.io/review_button.svg" height="40" alt="Review on Reviewable"/>](https://reviewable.io/reviews/servo/servo/9471)
<!-- Reviewable:end -->
@bors-servo
Copy link
Contributor

bors-servo commented Feb 5, 2016

☀️ Test successful - android, gonk, linux-dev, linux-rel, mac-dev-unit, mac-rel-css, mac-rel-wpt
@bors-servo bors-servo merged commit 9181a52 into servo:master Feb 5, 2016
2 checks passed
2 checks passed
continuous-integration/travis-ci/pr The Travis CI build passed
Details
homu Test successful
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@jdm jdm

Labels
S-awaiting-merge
Projects
None yet
Milestone
No milestone
Linked issues

Successfully merging this pull request may close these issues.

None yet

8 participants
@peterkort @highfive @jdm @bors-servo @KiChjang @nox @Ms2ger @larsbergstrom
You can’t perform that action at this time.