Skip to content

/ servo

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump clipboard to remove libc 0.1.z dependency #9473

Merged
merged 1 commit into from Feb 1, 2016
Merged

Bump clipboard to remove libc 0.1.z dependency #9473

merged 1 commit into from Feb 1, 2016

Conversation

@nox
Copy link
Member

nox commented Jan 31, 2016

Review on Reviewable
@KiChjang
Copy link
Member

KiChjang commented Jan 31, 2016

@bors-servo r+
@bors-servo
Copy link
Contributor

bors-servo commented Jan 31, 2016

📌 Commit b4301e6 has been approved by KiChjang
@bors-servo
Copy link
Contributor

bors-servo commented Jan 31, 2016

⌛ Testing commit b4301e6 with merge 5b5e696...
bors-servo added a commit that referenced this pull request Jan 31, 2016
@bors-servo
Auto merge of #9473 - nox:adieu-libc-1, r=KiChjang
5b5e696 
Bump clipboard to remove libc 0.1.z dependency

<!-- Reviewable:start -->
[<img src="https://reviewable.io/review_button.svg" height="40" alt="Review on Reviewable"/>](https://reviewable.io/reviews/servo/servo/9473)
<!-- Reviewable:end -->
@Ms2ger
Copy link
Contributor

Ms2ger commented Jan 31, 2016

Remove it from the whitelist?
@bors-servo
Copy link
Contributor

bors-servo commented Jan 31, 2016

💔 Test failed - linux-rel
@frewsxcv
Copy link
Member

frewsxcv commented Jan 31, 2016

Remove cocoa while you're at it too

servo/python/tidy.py

Line 171 in 46b3eb6

exceptions = ["libc", "cocoa"]

@nox
Copy link
Member Author

nox commented Jan 31, 2016

Didn't know about this thing.
@nox nox force-pushed the nox:adieu-libc-1 branch from b4301e6 to 9395463 Jan 31, 2016
python/tidy.py Outdated
@@ -178,9 +175,6 @@ def find_reverse_dependencies(dependency, version, content):
packages.setdefault(package["name"], []).append(package["version"])

for (name, versions) in packages.iteritems():
if name in exceptions or len(versions) <= 1:

This comment has been minimized.

Sign in to view
Copy link
@KiChjang

KiChjang Jan 31, 2016

Member

Do we want to keep the len(versions) <= 1 condition?

This comment has been minimized.

Sign in to view
Copy link
@nox

nox Jan 31, 2016

Author Member

Oh yes, probably.
@nox nox force-pushed the nox:adieu-libc-1 branch from 9395463 to 8abe975 Jan 31, 2016
@KiChjang
Copy link
Member

KiChjang commented Jan 31, 2016

@bors-servo r+
@bors-servo
Copy link
Contributor

bors-servo commented Jan 31, 2016

📌 Commit 8abe975 has been approved by KiChjang
@KiChjang KiChjang self-assigned this Jan 31, 2016
@nox
Copy link
Member Author

nox commented Jan 31, 2016

This is going to fail.

± ./mach test-tidy
./ports/cef/Cargo.lock:1: duplicate versions for package "cocoa"
    found dependency on version 0.1.5
    but highest version is 0.2.2
    try upgrading with ./mach cargo-update -p cocoa:0.1.5
    The following packages depend on version 0.1.5:
        embedding
@nox
Bump clipboard to remove libc 0.1.z dependency
Loading status checks…
74b6d8b
@nox nox force-pushed the nox:adieu-libc-1 branch from 8abe975 to 74b6d8b Jan 31, 2016
@KiChjang
Copy link
Member

KiChjang commented Jan 31, 2016

@bors-servo r+
@bors-servo
Copy link
Contributor

bors-servo commented Jan 31, 2016

📌 Commit 74b6d8b has been approved by KiChjang
@bors-servo
Copy link
Contributor

bors-servo commented Jan 31, 2016

⌛ Testing commit 74b6d8b with merge ec06c25...
bors-servo added a commit that referenced this pull request Jan 31, 2016
@bors-servo
Auto merge of #9473 - nox:adieu-libc-1, r=KiChjang
Loading status checks…
ec06c25 
Bump clipboard to remove libc 0.1.z dependency

<!-- Reviewable:start -->
[<img src="https://reviewable.io/review_button.svg" height="40" alt="Review on Reviewable"/>](https://reviewable.io/reviews/servo/servo/9473)
<!-- Reviewable:end -->
@bors-servo
Copy link
Contributor

bors-servo commented Feb 1, 2016

💔 Test failed - mac-rel-css
@nox
Copy link
Member Author

nox commented Feb 1, 2016

@bors-servo retry #7791
@bors-servo
Copy link
Contributor

bors-servo commented Feb 1, 2016

⚡ Previous build results for android, gonk, linux-dev, linux-rel, mac-dev-unit, mac-rel-wpt are reusable. Rebuilding only mac-rel-css...
@bors-servo
Copy link
Contributor

bors-servo commented Feb 1, 2016

☀️ Test successful - android, gonk, linux-dev, linux-rel, mac-dev-unit, mac-rel-css, mac-rel-wpt
@bors-servo bors-servo merged commit 74b6d8b into servo:master Feb 1, 2016
2 checks passed
2 checks passed
continuous-integration/travis-ci/pr The Travis CI build passed
Details
homu Test successful
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@KiChjang KiChjang

Labels
S-tests-failed
Projects
None yet
Milestone
No milestone
Linked issues

Successfully merging this pull request may close these issues.

None yet

6 participants
@nox @KiChjang @bors-servo @Ms2ger @frewsxcv @highfive
You can’t perform that action at this time.