Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix build error on AArch64 #9492

Merged
merged 1 commit into from Feb 2, 2016
Merged

Fix build error on AArch64 #9492

merged 1 commit into from Feb 2, 2016

Conversation

@mmatyas
Copy link
Contributor

mmatyas commented Feb 1, 2016

When cross compiling to AArch64, the native cc is used in the final linking step, instead of aarch64-linux-gnu-gcc. This patch fixes the issue.

Review on Reviewable

@jdm
Copy link
Member

jdm commented Feb 1, 2016

@bors-servo
Copy link
Contributor

bors-servo commented Feb 1, 2016

📌 Commit 94740c7 has been approved by jdm

@bors-servo
Copy link
Contributor

bors-servo commented Feb 2, 2016

Testing commit 94740c7 with merge 40e87c5...

bors-servo added a commit that referenced this pull request Feb 2, 2016
Fix build error on AArch64

When cross compiling to AArch64, the native `cc` is used in the final linking step, instead of `aarch64-linux-gnu-gcc`. This patch fixes the issue.

<!-- Reviewable:start -->
[<img src="https://reviewable.io/review_button.svg" height="40" alt="Review on Reviewable"/>](https://reviewable.io/reviews/servo/servo/9492)
<!-- Reviewable:end -->
@bors-servo
Copy link
Contributor

bors-servo commented Feb 2, 2016

💔 Test failed - mac-rel-css

@mmatyas
Copy link
Contributor Author

mmatyas commented Feb 2, 2016

Apparently something's wrong on the buildbot?

Edit: #9504

--- stderr
configure: WARNING:
  You will not be able to create source packages with 'make dist'
  because gtk-doc >= 1.15 is not found.
make[1]: warning: -jN forced in submake: disabling jobserver mode.
/Users/servo/.cargo/registry/src/github.com-0a35038f75765ae4/harfbuzz-sys-0.1.2/harfbuzz/missing: line 81: autoheader: command not found
WARNING: 'autoheader' is missing on your system.
         You should only need it if you modified 'acconfig.h' or
         'configure.ac' or m4 files included by 'configure.ac'.
         The 'autoheader' program is part of the GNU Autoconf package:
         <http://www.gnu.org/software/autoconf/>
         It also requires GNU m4 and Perl in order to run:
         <http://www.gnu.org/software/m4/>
         <http://www.perl.org/>
make[1]: *** [/Users/servo/.cargo/registry/src/github.com-0a35038f75765ae4/harfbuzz-sys-0.1.2/harfbuzz/config.h.in] Error 127
make: *** [all] Error 2
@larsbergstrom
Copy link
Contributor

larsbergstrom commented Feb 2, 2016

@bors-servo
Copy link
Contributor

bors-servo commented Feb 2, 2016

Testing commit 94740c7 with merge 7da425d...

bors-servo added a commit that referenced this pull request Feb 2, 2016
Fix build error on AArch64

When cross compiling to AArch64, the native `cc` is used in the final linking step, instead of `aarch64-linux-gnu-gcc`. This patch fixes the issue.

<!-- Reviewable:start -->
[<img src="https://reviewable.io/review_button.svg" height="40" alt="Review on Reviewable"/>](https://reviewable.io/reviews/servo/servo/9492)
<!-- Reviewable:end -->
@bors-servo
Copy link
Contributor

bors-servo commented Feb 2, 2016

💔 Test failed - mac-rel-css

@larsbergstrom
Copy link
Contributor

larsbergstrom commented Feb 2, 2016

@nox nox added S-awaiting-merge and removed S-tests-failed labels Feb 2, 2016
@bors-servo
Copy link
Contributor

bors-servo commented Feb 2, 2016

Testing commit 94740c7 with merge ff7df13...

bors-servo added a commit that referenced this pull request Feb 2, 2016
Fix build error on AArch64

When cross compiling to AArch64, the native `cc` is used in the final linking step, instead of `aarch64-linux-gnu-gcc`. This patch fixes the issue.

<!-- Reviewable:start -->
[<img src="https://reviewable.io/review_button.svg" height="40" alt="Review on Reviewable"/>](https://reviewable.io/reviews/servo/servo/9492)
<!-- Reviewable:end -->
@bors-servo
Copy link
Contributor

bors-servo commented Feb 2, 2016

💔 Test failed - mac-rel-css

@nox
Copy link
Member

nox commented Feb 2, 2016

@nox nox added S-awaiting-merge and removed S-tests-failed labels Feb 2, 2016
@bors-servo
Copy link
Contributor

bors-servo commented Feb 2, 2016

Testing commit 94740c7 with merge ea385fd...

bors-servo added a commit that referenced this pull request Feb 2, 2016
Fix build error on AArch64

When cross compiling to AArch64, the native `cc` is used in the final linking step, instead of `aarch64-linux-gnu-gcc`. This patch fixes the issue.

<!-- Reviewable:start -->
[<img src="https://reviewable.io/review_button.svg" height="40" alt="Review on Reviewable"/>](https://reviewable.io/reviews/servo/servo/9492)
<!-- Reviewable:end -->
@bors-servo
Copy link
Contributor

bors-servo commented Feb 2, 2016

💔 Test failed - mac-rel-wpt

@KiChjang
Copy link
Member

KiChjang commented Feb 2, 2016

@bors-servo
Copy link
Contributor

bors-servo commented Feb 2, 2016

Previous build results for android, gonk, linux-dev, linux-rel, mac-dev-unit, mac-rel-css are reusable. Rebuilding only mac-rel-wpt...

@bors-servo
Copy link
Contributor

bors-servo commented Feb 2, 2016

@bors-servo bors-servo merged commit 94740c7 into servo:master Feb 2, 2016
2 checks passed
2 checks passed
continuous-integration/travis-ci/pr The Travis CI build passed
Details
homu Test successful
Details
@mmatyas mmatyas deleted the mmatyas:arm64_linker_fix branch Nov 14, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

7 participants
You can’t perform that action at this time.