Skip to content

/ servo

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ensure that text nodes don't inherit opacity. #9503

Merged
merged 1 commit into from Feb 4, 2016
Merged

Ensure that text nodes don't inherit opacity. #9503

merged 1 commit into from Feb 4, 2016

Conversation

@glennw
Copy link
Member

glennw commented Feb 2, 2016

Review on Reviewable
@gw3583
Ensure that text nodes don't inherit opacity.
Loading status checks…
b954432
@glennw
Copy link
Member Author

glennw commented Feb 2, 2016

r? @mbrubeck or @pcwalton
@highfive
Copy link

highfive commented Feb 2, 2016

Heads up! This PR modifies the following files:

  • @bholley: components/style/properties.mako.rs
@pcwalton
Copy link
Contributor

pcwalton commented Feb 2, 2016

@bors-servo: r+
@bors-servo
Copy link
Contributor

bors-servo commented Feb 2, 2016

📌 Commit b954432 has been approved by pcwalton
@bors-servo
Copy link
Contributor

bors-servo commented Feb 2, 2016

⌛ Testing commit b954432 with merge 0cb745b...
bors-servo added a commit that referenced this pull request Feb 2, 2016
@bors-servo
Auto merge of #9503 - glennw:fix-text-node-opacity, r=pcwalton
0cb745b 
Ensure that text nodes don't inherit opacity.

<!-- Reviewable:start -->
[<img src="https://reviewable.io/review_button.svg" height="40" alt="Review on Reviewable"/>](https://reviewable.io/reviews/servo/servo/9503)
<!-- Reviewable:end -->
@bors-servo
Copy link
Contributor

bors-servo commented Feb 2, 2016

💔 Test failed - mac-rel-css
@larsbergstrom
Copy link
Contributor

larsbergstrom commented Feb 2, 2016

@bors-servo retry
@nox nox added S-awaiting-merge and removed S-tests-failed labels Feb 2, 2016
@bors-servo
Copy link
Contributor

bors-servo commented Feb 3, 2016

⌛ Testing commit b954432 with merge 62c6daa...
bors-servo added a commit that referenced this pull request Feb 3, 2016
@bors-servo
Auto merge of #9503 - glennw:fix-text-node-opacity, r=pcwalton
62c6daa 
Ensure that text nodes don't inherit opacity.

<!-- Reviewable:start -->
[<img src="https://reviewable.io/review_button.svg" height="40" alt="Review on Reviewable"/>](https://reviewable.io/reviews/servo/servo/9503)
<!-- Reviewable:end -->
@bors-servo
Copy link
Contributor

bors-servo commented Feb 3, 2016

💔 Test failed - mac-rel-css
@KiChjang
Copy link
Member

KiChjang commented Feb 3, 2016

@bors-servo retry
@bors-servo
Copy link
Contributor

bors-servo commented Feb 3, 2016

⚡ Previous build results for android, gonk, linux-dev, linux-rel, mac-dev-unit, mac-rel-wpt are reusable. Rebuilding only mac-rel-css...
@bors-servo
Copy link
Contributor

bors-servo commented Feb 3, 2016

💔 Test failed - mac-rel-css
@jdm
Copy link
Member

jdm commented Feb 3, 2016

@bors-servo: retry
@bors-servo
Copy link
Contributor

bors-servo commented Feb 3, 2016

⌛ Testing commit b954432 with merge 1ad2a20...
@bors-servo
Copy link
Contributor

bors-servo commented Feb 4, 2016

⌛ Testing commit b954432 with merge b0747fe...
bors-servo added a commit that referenced this pull request Feb 4, 2016
@bors-servo
Auto merge of #9503 - glennw:fix-text-node-opacity, r=pcwalton
b0747fe 
Ensure that text nodes don't inherit opacity.

<!-- Reviewable:start -->
[<img src="https://reviewable.io/review_button.svg" height="40" alt="Review on Reviewable"/>](https://reviewable.io/reviews/servo/servo/9503)
<!-- Reviewable:end -->
@bors-servo
Copy link
Contributor

bors-servo commented Feb 4, 2016

💔 Test failed - linux-rel
@KiChjang
Copy link
Member

KiChjang commented Feb 4, 2016

@bors-servo retry
@bors-servo
Copy link
Contributor

bors-servo commented Feb 4, 2016

⌛ Testing commit b954432 with merge 0d5c47f...
bors-servo added a commit that referenced this pull request Feb 4, 2016
@bors-servo
Auto merge of #9503 - glennw:fix-text-node-opacity, r=pcwalton
0d5c47f 
Ensure that text nodes don't inherit opacity.

<!-- Reviewable:start -->
[<img src="https://reviewable.io/review_button.svg" height="40" alt="Review on Reviewable"/>](https://reviewable.io/reviews/servo/servo/9503)
<!-- Reviewable:end -->
@bors-servo
Copy link
Contributor

bors-servo commented Feb 4, 2016

💔 Test failed - linux-rel
@KiChjang
Copy link
Member

KiChjang commented Feb 4, 2016

@bors-servo retry
@bors-servo
Copy link
Contributor

bors-servo commented Feb 4, 2016

⌛ Testing commit b954432 with merge a9f6ab2...
bors-servo added a commit that referenced this pull request Feb 4, 2016
@bors-servo
Auto merge of #9503 - glennw:fix-text-node-opacity, r=pcwalton
Loading status checks…
a9f6ab2 
Ensure that text nodes don't inherit opacity.

<!-- Reviewable:start -->
[<img src="https://reviewable.io/review_button.svg" height="40" alt="Review on Reviewable"/>](https://reviewable.io/reviews/servo/servo/9503)
<!-- Reviewable:end -->
@bors-servo
Copy link
Contributor

bors-servo commented Feb 4, 2016

💔 Test failed - linux-rel
@KiChjang
Copy link
Member

KiChjang commented Feb 4, 2016

@bors-servo retry
@bors-servo
Copy link
Contributor

bors-servo commented Feb 4, 2016

⚡ Previous build results for android, gonk, linux-dev, mac-dev-unit, mac-rel-css, mac-rel-wpt are reusable. Rebuilding only linux-rel...
@bors-servo
Copy link
Contributor

bors-servo commented Feb 4, 2016

☀️ Test successful - android, gonk, linux-dev, linux-rel, mac-dev-unit, mac-rel-css, mac-rel-wpt
@bors-servo bors-servo merged commit b954432 into servo:master Feb 4, 2016
2 checks passed
2 checks passed
continuous-integration/travis-ci/pr The Travis CI build passed
Details
homu Test successful
Details
@mbrubeck mbrubeck mentioned this pull request Feb 25, 2016
Closed
@pcwalton pcwalton mentioned this pull request May 20, 2016
Closed
@glennw glennw deleted the glennw:fix-text-node-opacity branch Dec 12, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@mbrubeck mbrubeck

Labels
S-tests-failed
Projects
None yet
Milestone
No milestone
Linked issues

Successfully merging this pull request may close these issues.

None yet

10 participants
@glennw @highfive @pcwalton @bors-servo @larsbergstrom @KiChjang @jdm @mbrubeck @nox @gw3583
You can’t perform that action at this time.